Add a default yield :head to layouts/application.html.erb #50527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good pattern that most applications should be using.
|
Unrelated flaky test failures. |
dhh
added a commit
to skipkayhil/rails
that referenced
this pull request
Jan 2, 2024
* main: Add a default yield :head to layouts/application.html.erb (rails#50527) Switch to new enum syntax in example code [ci-skip] Utilize new enum syntax Apply autocorrection by RuboCop to files generated by `bin/rails generate` (rails#50506) Add brakeman as development dependency Fix skipped rubocop test typo (rails#50519) Update the puma startup message docs: remove unneeded whitespace from start of code blocks Add changelog entry for rails#50512 Remove unnecessary require Fix railspect not validating alphabetical order
4 tasks
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
May 4, 2024
Follow up to [rails#50527][] Highlight the presence of the `yield :head` pattern established by `turbo-rails` and adopted by Rails as part of [rails#50527][]. New applications will generate their application layout with `yield :head`, so mention that in the documentation. Also include the `yield :head` call in generated plugin layouts. [rails#50527]: rails#50527
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
May 6, 2024
Follow up to [rails#50527][] Highlight the presence of the `yield :head` pattern established by `turbo-rails` and adopted by Rails as part of [rails#50527][]. New applications will generate their application layout with `yield :head`, so mention that in the documentation. Also include the `yield :head` call in generated plugin layouts. [rails#50527]: rails#50527
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
May 6, 2024
Follow up to [rails#50527][] Highlight the presence of the `yield :head` pattern established by `turbo-rails` and adopted by Rails as part of [rails#50527][]. New applications will generate their application layout with `yield :head`, so mention that in the documentation. Also include the `yield :head` call in generated plugin layouts. [rails#50527]: rails#50527
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
Jun 14, 2024
Follow up to [rails#50527][] Highlight the presence of the `yield :head` pattern established by `turbo-rails` and adopted by Rails as part of [rails#50527][]. New applications will generate their application layout with `yield :head`, so mention that in the documentation. Also include the `yield :head` call in generated plugin layouts. [rails#50527]: rails#50527
Set2005
pushed a commit
to Set2005/fix-association-initialize-order
that referenced
this pull request
Jul 8, 2024
Follow up to [rails#50527][] Highlight the presence of the `yield :head` pattern established by `turbo-rails` and adopted by Rails as part of [rails#50527][]. New applications will generate their application layout with `yield :head`, so mention that in the documentation. Also include the `yield :head` call in generated plugin layouts. [rails#50527]: rails#50527
DanielaVelasquez
pushed a commit
to DanielaVelasquez/rails
that referenced
this pull request
Oct 3, 2024
Follow up to [rails#50527][] Highlight the presence of the `yield :head` pattern established by `turbo-rails` and adopted by Rails as part of [rails#50527][]. New applications will generate their application layout with `yield :head`, so mention that in the documentation. Also include the `yield :head` call in generated plugin layouts. [rails#50527]: rails#50527
yoones
pushed a commit
to yoones/rails
that referenced
this pull request
Mar 6, 2025
* Add a default yield :head Good pattern that most applications should be using. * Make test more resilient * Appease RuboCop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good pattern that most applications should be using. It allows templates rendered inside of the application layout to add tags to the head. Like additional meta tags. Used by turbo-rails, for example.