Fix uninitialized constant error on Puma boot #49325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
railties/lib/rails/generators/rails/app/templates/config/puma.rb.tt
Outdated
Show resolved
Hide resolved
Before, using the default `puma/config.rb` generated by `rails new`, Puma would fail to boot in production with this error: ``` ./config/puma.rb:16:in `block in _load_from': uninitialized constant Puma::DSL::Concurrent (NameError) from ./config/puma.rb:16:in `fetch' from ./config/puma.rb:16:in `_load_from' ``` This was because `Concurrent.physical_processor_count` was being referenced before the `Concurrent` constant was initialized. Fix by requiring `concurrent-ruby` just before the `Concurrent` constant is needed. Fixes rails#49323
a15a9c5 to
39ccb97
Compare
|
@guilleiguaran I accepted your suggestion and squashed down to 1 commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created to fix #49323: Puma fails to boot in production with default config due to missing
Concurrencyconstant (Rails 7.1.0.beta1)Detail
Before, using the default
puma/config.rbgenerated byrails new, Puma would fail to boot in production with this error:This was because
Concurrent.physical_processor_countwas being referenced before theConcurrentconstant was initialized.Fix by requiring
concurrent-rubyjust before theConcurrentconstant is needed.Fixes #49323
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]Tests are added or updated if you fix a bug or add a feature.The original PR that introducedConcurrent.physical_processor_countdid not have any tests