add a note on the postgres limit [ci skip] #49897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we should be recommending gems in the guides based off this one edge case, IMO. |
|
I disagree, if we know a limitation of the framework and a possible solution, why no let people know? It's always up to the person to decide whether or not they want to use the "recommended" gem. |
|
If I remove the gem recommendation would you approve @zzak? |
|
Yeah, I think it makes sense to call out any limitations here for the particular adapter in question. It seems like there is some ongoing discussion in #49634 that I think we should wait on before providing any solutions or workarounds in the docs. |
|
are you happy now @zzak? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Now more than before, with the upcoming Solid Queue, developers might not want to have Redis as a dependency.
The PostgreSQL adapter for ActionCable plays an important role on this transition, allowing people to transmit data over the database.
One limitation needs to be considered though, PostgreSQL has a 8000 bytes limit on
NOTIFY.This PR documents that and links a possible solution: the actioncable-enhanced-postgresql-adapter gem.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]