Skip to content

Bumped minimum version of Python to 3.10 and updated infrastructure #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jun 11, 2025
Merged

Bumped minimum version of Python to 3.10 and updated infrastructure #951

merged 24 commits into from
Jun 11, 2025

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Jun 10, 2025 •
edited
Loading

Changes:

  • Moved workaround for casa back inside the tox file to avoid having to special case this in GitHub actions, and so that it can easily be run locally
  • Fixed compatibility with recent versions of dask which raise a FutureWarning when trying to access a view of a dask array inside Quantity
  • Use proper fix for Numpy 2.0+ compatibility in relation to copying arrays in Quantity (use copy=COPY_IF_NEEDED instead of copy=False)
  • Un-xfailed a couple of tests which now pass
  • Fixed compatibility with joblib 1.5+
  • Simplify CI configuration by using OpenAstronomy workflow - several of the CI job names did not match the actual tox environment used, and there was a duplicate, so this makes it simpler to spot any issues.
  • Updated minimum Python to 3.10
  • Specify minimum versions for most dependencies and use tox-uv to define an -oldestdeps factor (and add this to the CI)
  • Migrated setup.cfg to pyproject.toml
  • Use wheels for dev versions

@astrofrog astrofrog force-pushed the update-infrastructure branch from f99e42e to 7b83368 Compare June 10, 2025 10:39
@codecov Codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.76%. Comparing base (bdd4f66) to head (0e70938).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
spectral_cube/base_class.py 75.00% 2 Missing ⚠️
spectral_cube/spectral_cube.py 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
- Coverage   79.81%   79.76%   -0.05%     
==========================================
  Files          23       23              
  Lines        6035     6050      +15     
==========================================
+ Hits         4817     4826       +9     
- Misses       1218     1224       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@astrofrog astrofrog changed the title Infrastructure updates Bumped minimum version of Python to 3.10 and updated infrastructure Jun 10, 2025
@astrofrog astrofrog mentioned this pull request Jun 10, 2025
Closed
@astrofrog astrofrog force-pushed the update-infrastructure branch from 3bd57bb to 9852197 Compare June 10, 2025 22:32
@astrofrog astrofrog marked this pull request as ready for review June 10, 2025 23:04
@astrofrog astrofrog requested a review from e-koch June 10, 2025 23:04
@astrofrog astrofrog requested a review from keflavich June 10, 2025 23:04
e-koch
e-koch reviewed Jun 10, 2025
View reviewed changes
Copy link
Contributor

@e-koch e-koch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor questions to follow up with. Otherwise LGTM.

@astrofrog @e-koch
Add comment
a778947 
Co-authored-by: Eric Koch <koch.eric.w@gmail.com>
@astrofrog astrofrog merged commit f95ba1c into radio-astro-tools:master Jun 11, 2025
21 checks passed
@petrzjunior petrzjunior mentioned this pull request Aug 10, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-koch e-koch e-koch approved these changes

@keflavich keflavich Awaiting requested review from keflavich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astrofrog @e-koch