feat(event): Callstack for VirtualAlloc event #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callstack for VirtualAlloc events is enabled with this change. Sadly, MapViewFile/UnmapViewFile events don't yield userspace stack address, so we can't consider them useful.
1701790 to
dec4059
Compare
These events don't contain the thread id parameter, so trying to adjust the tid will always yield to an invalid value.
dec4059 to
a2ee03d
Compare
Except when the LoadImage event is emitted by the System process, all other events are safe to ignore callstack symbolization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
Enable callstack enrichment for the
VirtualAllocevent. As part of this changeset, a few optimizations are introduced to dropstack enrichment for the events generated by the
Systemprocess.What type of change does this PR introduce?
/kind feature (non-breaking change which adds functionality)
Any specific area of the project related to this PR?
/area telemetry
/area event
Special notes for the reviewer
Does this PR introduce a user-facing change?