Skip to content

Ensure Rack::ETag correctly updates response body. #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Apr 12, 2025

Fixes #2323.

We should consider back porting this to 3.x and 3.1.

@ioquatix ioquatix requested review from jeremyevans and Copilot April 12, 2025 22:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@ericproulx
Copy link

@ioquatix I've tested it locally and it works perfectly :)

@ioquatix ioquatix force-pushed the rack-etag-body-replace-fix branch from 3e22d08 to 938aaa3 Compare April 13, 2025 12:09
@ioquatix ioquatix merged commit d73095f into main Apr 13, 2025
31 checks passed
@ioquatix ioquatix deleted the rack-etag-body-replace-fix branch April 13, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mounted Grape App -> Rack::Lint::LintError: Response body is already closed
3 participants