Limit file extension length of multipart tempfiles #2069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
approved these changes
Apr 18, 2023
ioquatix
reviewed
Apr 18, 2023
|
Btw. this problem popped recently on rubygems.org again. |
f966951 to
31ee3c9
Compare
|
This makes me wonder why #1874 wasn't accepted. My next plan was to move handling files to "user land" to make this exception (or even custom one) easy to handle in rails base controller for example. |
jeremyevans
approved these changes
Apr 19, 2023
|
@simi sorry about past PRs where the outcome might have been different. Everyone's contributions are valued and we do our best as maintainers to ensure that we keep moving forward. If there are additions or improvements in #1874 that you think we should apply, please consider opening a new PR and we appreciate the time you invest in such endeavours. |
dentarg
added a commit
to dentarg/rack
that referenced
this pull request
Apr 25, 2023
ioquatix
pushed a commit
that referenced
this pull request
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1968