Revert the unapproved QueryParser#unescape change #2055
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was only made because Samuel couldn't figure out how to make the tests pass without the change. This reverts the code and fixes the tests.
|
I don't think we should do this, it looks objectively worse to me to use conditional requires. It's fairly easy for this to break. That doesn't mean I don't think what I did was the best or that we shouldn't do something better. But I don't think query parser should depend on utils. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was only made because @ioquatix couldn't figure out how to make the tests pass without the change. This reverts the code and fixes the tests.