Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rack/rack-session
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.1.0
Choose a base ref
...
head repository: rack/rack-session
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.2.0
Choose a head ref
  • 6 commits
  • 13 files changed
  • 2 contributors

Commits on May 2, 2022

  1. Various Fixes (#1)

    * Make rack/session setup autoloads
    
    These are the same autoloads previously used when the session
    support was included in rack.
    
    Remove the duplicate constant definitions to avoid constant
    warnings when rack is also in use (which it must be for this
    to work, as parts of rack-session depend on rack).
    
    * Define constants under Rack::Session, so they don't conflict with Rack constants
    
    * Load rack/session/constants in files that use the constants
    
    * Support backwards compatibility for Rack::Session::Cookie :secret option
    
    Previously, :secret was used to store the HMAC secret.  If it is
    used, use it as a fallback to set both the encryption secret and
    the legacy HMAC secret.
    
    From a cryptographic perspective, it's best to avoid sharing
    secrets like this, even though I'm guessing it is not vulnerable
    (note: this is not an educated guess).  I think this is better
    than completely breaking backwards compatibility.
    
    The best way to handle conversion from legacy HMAC would be to
    specify :secrets in addition to :secret (or :legacy_hmac_secret),
    then remove :secret/:legacy_hmac_secret after all sessions have
    been upgraded.
    
    * Avoid unnecessary arguments to Dir.glob in gemspec
    
    FNM_DOTMATCH is not needed (no additional files would match with
    it).  base keyword is what breaks CI on Ruby 2.4, and is not needed
    as gem is generally build already in the same directory as the
    gemspec.
    jeremyevans authored May 2, 2022
    Configuration menu
    Copy the full SHA
    7071f65 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. Configuration menu
    Copy the full SHA
    c35a928 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. Configuration menu
    Copy the full SHA
    e86e4a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d7b679f View commit details
    Browse the repository at this point in the history
  3. Add rack ~> 3.0 to gemspec.

    ioquatix committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    6df4373 View commit details
    Browse the repository at this point in the history
  4. Bump minor version.

    ioquatix committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    b7d6127 View commit details
    Browse the repository at this point in the history
Loading