Suppress 'found an unsupported model' warning #1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not needed anymore, as #1845 reports on missing identifiers and roborocks are covered by a wildcard matcher in devicefactory
Codecov Report
@@ Coverage Diff @@
## master #1850 +/- ##
==========================================
- Coverage 81.41% 81.40% -0.02%
==========================================
Files 193 193
Lines 18556 18563 +7
Branches 4024 4025 +1
==========================================
+ Hits 15108 15111 +3
+ Misses 3173 3171 -2
- Partials 275 281 +6
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not needed anymore, as #1845 reports on missing identifiers and roborocks are covered by a wildcard matcher in devicefactory.
The original reason for adding this warning was to gather a list of devices that we should add to the supported devices list for devicefactory, but I think we are well covered now at least for roborock (closing the issues below, other integrations need to be adapted to use wildcards where feasible).
Closes #1843
Closes #1840
Closes #1833
Closes #1820
Closes #1797
Closes #1652
Closes #1844