Skip to content

Support pydantic v2 using v1 shims #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2023
Merged

Support pydantic v2 using v1 shims #1816

merged 1 commit into from
Aug 28, 2023

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Aug 28, 2023 •
edited
Loading

Fixes #1815

@codecov
Copy link

codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Merging #1816 (196cb54) into master (f7ef60f) will decrease coverage by 0.05%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##           master    #1816      +/-   ##
==========================================
- Coverage   80.87%   80.82%   -0.05%     
==========================================
  Files         192      192              
  Lines       18526    18541      +15     
  Branches     4014     4014              
==========================================
+ Hits        14982    14985       +3     
- Misses       3266     3278      +12     
  Partials      278      278
Files Changed Coverage Δ
miio/devtools/simulators/miiosimulator.py 0.00% <0.00%> (ø)
miio/devtools/simulators/miotsimulator.py 0.00% <0.00%> (ø)
miio/cloud.py 66.91% <50.00%> (-0.78%) ⬇️
miio/miot_cloud.py 75.64% <50.00%> (-1.70%) ⬇️
miio/miot_models.py 74.48% <50.00%> (-0.52%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti force-pushed the janitor/pydantic_v2_support branch from 28830fa to 196cb54 Compare August 28, 2023 16:29
@rytilahti rytilahti merged commit 2546b04 into master Aug 28, 2023
@rytilahti rytilahti deleted the janitor/pydantic_v2_support branch August 28, 2023 16:36
@rytilahti rytilahti mentioned this pull request Aug 28, 2023
Open
st7105 added a commit to st7105/python-miio that referenced this pull request Oct 4, 2023
@st7105
Revert "Support pydantic v2 using v1 shims (rytilahti#1816)"
0801956 
This reverts commit 2546b04.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for pydantic v2 using v1 shims
1 participant
@rytilahti