Skip to content

Clarify the ambiguous process-level CryptoProvider error #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

Clarify the ambiguous process-level CryptoProvider error #2558

merged 1 commit into from
Jul 14, 2025

Conversation

JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Jul 13, 2025 •
edited
Loading

I have personally hit this error after adding a new dependency that enabled the ring feature without me realizing.
I think the instruction of the error, to call CryptoProvider::install_default(), does not help the user understand why this error suddenly appeared.

Yesterday I saw this reddit thread hit the same problem, so lets fix this. I'm open to different wording than I came up with, I'm not an expert on this crate.

This is how the new error appears:

thread 'main' panicked at /home/jonathan/Projects/rustls/rustls/src/crypto/mod.rs:249:14:

Could not automatically determine the process-level CryptoProvider from Rustls crate features.
Call CryptoProvider::install_default() before this point to select a provider manually, or make sure exactly one of the 'aws-lc-rs' and 'ring' features is enabled.
See the documentation of the CryptoProvider type for more information.
            
stack backtrace:
   0: __rustc::rust_begin_unwind
             at /rustc/71e4c005caa812a16fcb08d0bf1e6f1eda7c8381/library/std/src/panicking.rs:697:5
   1: core::panicking::panic_fmt
             at /rustc/71e4c005caa812a16fcb08d0bf1e6f1eda7c8381/library/core/src/panicking.rs:75:14
   2: core::panicking::panic_display
             at /rustc/71e4c005caa812a16fcb08d0bf1e6f1eda7c8381/library/core/src/panicking.rs:268:5
   3: core::option::expect_failed
             at /rustc/71e4c005caa812a16fcb08d0bf1e6f1eda7c8381/library/core/src/option.rs:2081:5
   4: core::option::Option<T>::expect
             at /home/jonathan/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/option.rs:960:21
   5: rustls::crypto::CryptoProvider::get_default_or_install_from_crate_features
             at /home/jonathan/Projects/rustls/rustls/src/crypto/mod.rs:249:14
   6: rustls::server::server_conn::ServerConfig::builder_with_protocol_versions
             at /home/jonathan/Projects/rustls/rustls/src/server/server_conn.rs:480:13
   7: rust_test::main
             at ./src/main.rs:4:20
   8: core::ops::function::FnOnce::call_once
             at /home/jonathan/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Process finished with exit code 101

@codecov Codecov
Copy link

codecov bot commented Jul 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (e49d0ff) to head (f9505a9).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2558   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files          97       97           
  Lines       21460    21464    +4     
=======================================
+ Hits        20463    20467    +4     
  Misses        997      997

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

djc
djc approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, thanks!

I think we should backport this to rel-0.23.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jul 14, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3125302 3174592 ⚠️ 49290 (1.58%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1756449 1781875 ⚠️ 25426 (1.45%) 1.04%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4291800 4342117 ⚠️ 50317 (1.17%) 0.64%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10429973 10506423 76450 (0.73%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11370963 11333164 -37799 (-0.33%) 1.01%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 63757218 63550291 -206927 (-0.32%) 0.75%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 63528702 63331801 -196901 (-0.31%) 0.55%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 63754113 63567925 -186188 (-0.29%) 0.73%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49167616 49063466 -104150 (-0.21%) 0.49%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49165702 49062158 -103544 (-0.21%) 0.59%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 47840789 47742504 -98285 (-0.21%) 0.48%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 63758986 63628769 -130217 (-0.20%) 0.88%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 63428555 63530183 101628 (0.16%) 0.66%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49206904 49129187 -77717 (-0.16%) 0.49%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9498182 9510170 11988 (0.13%) 1.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4295243 4289941 -5302 (-0.12%) 1.11%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11346354 11333208 -13146 (-0.12%) 0.87%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 47779494 47830343 50849 (0.11%) 0.62%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 63373454 63432089 58635 (0.09%) 0.84%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 63447418 63390689 -56729 (-0.09%) 0.54%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 63470355 63427995 -42360 (-0.07%) 0.59%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 47812041 47841328 29287 (0.06%) 0.56%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9531480 9525756 -5724 (-0.06%) 1.01%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 47838957 47810642 -28315 (-0.06%) 0.39%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3301709 3303629 1920 (0.06%) 0.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 63592658 63626108 33450 (0.05%) 0.63%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 47861144 47840102 -21042 (-0.04%) 0.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49112335 49129188 16853 (0.03%) 0.37%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2661759 2660999 -760 (-0.03%) 0.35%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 63393127 63409361 16234 (0.03%) 0.46%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 47773699 47782027 8328 (0.02%) 0.37%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3131982 3131482 -500 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 63698911 63704383 5472 (0.01%) 0.82%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2658530 2658310 -220 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1759039 1759144 105 (0.01%) 1.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49137769 49140451 2682 (0.01%) 0.58%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3303104 3303020 -84 (-0.00%) 0.23%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49127458 49127181 -277 (-0.00%) 0.42%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1283640 1283634 -6 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1282466 1282469 3 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1721618 1721622 4 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7214678 7214691 13 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 63642572 63642539 -33 (-0.00%) 0.89%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34742536 34742553 17 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45915926 45915935 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92548261 92548271 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58019269 58019263 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80247213 80247221 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92536633 92536642 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80363478 80363471 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46017299 46017303 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92546624 92546632 8 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105026293 105026301 8 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104980556 104980563 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46119457 46119454 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92597364 92597359 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58137203 58137200 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46010414 46010412 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46171698 46171700 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46172703 46172701 -2 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117356812 117356817 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80352544 80352541 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58010556 58010558 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58079446 58079444 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58127201 58127199 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80244039 80244037 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80252187 80252185 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46009149 46009148 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46182992 46182991 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92587360 92587358 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92598661 92598663 2 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57916880 57916879 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58022183 58022184 1 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117314566 117314568 2 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30448699 30448699 0 (0.00%) 0.30%
handshake_no_resume_ring_1.3_rsa_chacha_server 11118352 11118352 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_server 1033061 1033061 0 (0.00%) 0.75%
handshake_session_id_ring_1.3_rsa_aes_server 31679979 31679979 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7212717 7212717 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31561082 31561082 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4170418 4170418 0 (0.00%) 0.47%
handshake_session_id_1.2_no_crypto_client 1157093 1157093 0 (0.00%) 0.74%
handshake_no_resume_ring_1.2_rsa_aes_server 10987217 10987217 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3765784 3765784 0 (0.00%) 0.28%
handshake_session_id_ring_1.3_rsa_aes_client 30455647 30455647 0 (0.00%) 0.30%
handshake_no_resume_1.3_no_crypto_server 101580 101580 0 (0.00%) 0.73%
handshake_session_id_1.3_no_crypto_server 2088856 2088856 0 (0.00%) 1.21%
handshake_no_resume_1.2_no_crypto_client 102538 102538 0 (0.00%) 0.25%
handshake_tickets_ring_1.3_ecdsap384_aes_server 31992908 31992908 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11112591 11112591 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4668958 4668958 0 (0.00%) 0.29%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30451633 30451633 0 (0.00%) 0.30%
handshake_no_resume_1.3_no_crypto_client 111938 111938 0 (0.00%) 1.23%
handshake_tickets_ring_1.3_rsa_aes_server 31990125 31990125 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31557999 31557999 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_client 2216132 2216132 0 (0.00%) 1.99%
handshake_tickets_ring_1.3_rsa_aes_client 30562109 30562109 0 (0.00%) 0.30%
handshake_tickets_ring_1.3_ecdsap256_aes_client 30557871 30557871 0 (0.00%) 0.29%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3671300 3671300 0 (0.00%) 0.46%
handshake_tickets_ring_1.3_rsa_chacha_client 30490478 30490478 0 (0.00%) 0.30%
handshake_tickets_1.2_no_crypto_client 1242008 1242008 0 (0.00%) 1.92%
handshake_session_id_ring_1.3_rsa_chacha_client 30363997 30363997 0 (0.00%) 0.30%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31560900 31560900 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_server 78127 78127 0 (0.00%) 0.62%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31682880 31682880 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 31887885 31887885 0 (0.00%) 0.20%
handshake_session_id_1.3_no_crypto_client 2197442 2197442 0 (0.00%) 2.00%
handshake_tickets_ring_1.2_rsa_aes_client 4566038 4566038 0 (0.00%) 0.33%
handshake_tickets_ring_1.3_ecdsap256_aes_server 31992886 31992886 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2243324 2243324 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31683062 31683062 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34740820 34740820 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4079656 4079656 0 (0.00%) 0.34%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4873032 4873032 0 (0.00%) 0.39%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30359983 30359983 0 (0.00%) 0.30%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30357049 30357049 0 (0.00%) 0.30%
handshake_tickets_1.2_no_crypto_server 1193060 1193060 0 (0.00%) 0.69%
handshake_no_resume_ring_1.3_rsa_aes_client 2337626 2337626 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 31890646 31890646 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58137218 58137218 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4176985 4176985 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 30483045 30483045 0 (0.00%) 0.30%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80352186 80352186 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 30486240 30486240 0 (0.00%) 0.30%
handshake_tickets_1.3_no_crypto_server 2052959 2052959 0 (0.00%) 1.21%
handshake_tickets_ring_1.3_ecdsap384_aes_client 30554655 30554655 0 (0.00%) 0.30%
handshake_no_resume_ring_1.3_rsa_chacha_client 2343280 2343280 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 31890668 31890668 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_1.3_no_crypto 85.78 µs 83.15 µs -2.63 µs (-3.07%) 10.04%
handshake_no_resume_1.2_no_crypto 77.31 µs 75.22 µs -2.09 µs (-2.70%) 10.55%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.64 ms 4.57 ms -0.07 ms (-1.54%) 4.45%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.33 ms 5.25 ms -0.07 ms (-1.36%) 4.29%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.28 ms 5.20 ms -0.07 ms (-1.36%) 4.92%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.40 ms 5.33 ms -0.07 ms (-1.25%) 4.47%
transfer_no_resume_ring_1.2_rsa_aes 5.81 ms 5.74 ms -0.07 ms (-1.20%) 3.54%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.06 ms 5.00 ms -0.06 ms (-1.19%) 4.60%
transfer_no_resume_ring_1.3_rsa_aes 5.89 ms 5.82 ms -0.07 ms (-1.17%) 4.05%
handshake_tickets_1.3_no_crypto 623.10 µs 617.05 µs -6.04 µs (-0.97%) 4.11%
handshake_no_resume_ring_1.3_ecdsap256_chacha 458.03 µs 453.75 µs -4.27 µs (-0.93%) 2.93%
handshake_no_resume_ring_1.3_ecdsap256_aes 462.36 µs 458.56 µs -3.80 µs (-0.82%) 2.75%
handshake_tickets_1.2_no_crypto 374.42 µs 371.34 µs -3.08 µs (-0.82%) 4.01%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 585.65 µs 581.06 µs -4.59 µs (-0.78%) 3.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 582.26 µs 577.77 µs -4.49 µs (-0.77%) 2.48%
transfer_no_resume_1.3_no_crypto 11.85 ms 11.76 ms -0.08 ms (-0.70%) 3.38%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.49 ms 8.43 ms -0.06 ms (-0.69%) 2.66%
handshake_session_id_1.2_no_crypto 338.88 µs 337.05 µs -1.83 µs (-0.54%) 3.24%
transfer_no_resume_1.2_no_crypto 11.75 ms 11.69 ms -0.06 ms (-0.54%) 2.04%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.10 ms 13.03 ms -0.07 ms (-0.53%) 2.01%
handshake_session_id_1.3_no_crypto 645.25 µs 641.84 µs -3.42 µs (-0.53%) 4.72%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.79 ms 13.72 ms -0.07 ms (-0.52%) 1.60%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.75 ms 13.68 ms -0.07 ms (-0.51%) 1.97%
transfer_no_resume_ring_1.3_rsa_chacha 13.45 ms 13.38 ms -0.07 ms (-0.50%) 1.58%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.95 ms 12.89 ms -0.06 ms (-0.47%) 1.91%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.05 ms 15.98 ms -0.07 ms (-0.41%) 1.42%
handshake_no_resume_ring_1.3_rsa_chacha 950.58 µs 947.23 µs -3.34 µs (-0.35%) 1.16%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.23 ms 1.22 ms -0.00 ms (-0.34%) 7.39%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.23 ms 1.23 ms -0.00 ms (-0.32%) 9.87%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.57 ms 1.57 ms -0.00 ms (-0.30%) 6.56%
handshake_no_resume_ring_1.2_rsa_aes 943.09 µs 940.42 µs -2.67 µs (-0.28%) 1.11%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.43 ms 8.41 ms -0.02 ms (-0.26%) 1.40%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.73 ms 1.73 ms -0.00 ms (-0.25%) 5.68%
handshake_no_resume_ring_1.3_rsa_aes 949.23 µs 946.92 µs -2.31 µs (-0.24%) 1.11%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.28 ms 9.26 ms -0.02 ms (-0.24%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.26 ms 1.25 ms -0.00 ms (-0.24%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.11 ms 9.09 ms -0.02 ms (-0.23%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms -0.00 ms (-0.22%) 8.62%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.59 ms 8.57 ms -0.02 ms (-0.21%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.39 ms 5.37 ms -0.01 ms (-0.21%) 1.17%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.21 ms 9.20 ms -0.02 ms (-0.19%) 1.63%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.25 ms 9.23 ms -0.02 ms (-0.19%) 1.65%
handshake_tickets_ring_1.2_rsa_aes 1.55 ms 1.54 ms -0.00 ms (-0.18%) 2.14%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.27 ms 1.26 ms -0.00 ms (-0.18%) 1.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.38 ms 8.36 ms -0.02 ms (-0.18%) 1.52%
handshake_session_id_ring_1.3_rsa_chacha 5.88 ms 5.87 ms -0.01 ms (-0.18%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.55 ms 8.54 ms -0.01 ms (-0.17%) 1.17%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.10 ms 9.08 ms -0.01 ms (-0.16%) 1.37%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 9.05 ms 9.04 ms -0.01 ms (-0.14%) 1.31%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.22 ms 9.21 ms -0.01 ms (-0.13%) 1.30%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.55 ms 3.55 ms -0.00 ms (-0.12%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.42 ms 5.42 ms -0.01 ms (-0.12%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.55 ms -0.00 ms (-0.11%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.05 ms 9.04 ms -0.01 ms (-0.10%) 1.54%
handshake_session_id_ring_1.3_rsa_aes 5.90 ms 5.89 ms -0.01 ms (-0.09%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.52 ms 8.51 ms -0.01 ms (-0.09%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.41 ms 5.40 ms -0.00 ms (-0.08%) 1.12%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.47 ms 8.46 ms -0.01 ms (-0.07%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 5.92 ms 5.92 ms -0.00 ms (-0.07%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 5.95 ms 5.94 ms -0.00 ms (-0.06%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.46 ms 5.45 ms -0.00 ms (-0.06%) 1.16%
handshake_tickets_ring_1.3_ecdsap384_aes 8.55 ms 8.55 ms -0.00 ms (-0.03%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.49 ms 8.49 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.46 ms 1.46 ms -0.00 ms (-0.00%) 1.47%

Additional information

Historical results

Checkout details:

@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Jul 14, 2025 •
edited
Loading

Sounds good, let me know if there's anything I need to do to make that happen. Should I rebase on that branch?

ctz
ctz approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cpu
cpu approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@cpu cpu mentioned this pull request Jul 14, 2025
Merged
@cpu
Copy link
Member

cpu commented Jul 14, 2025

Sounds good, let me know if there's anything I need to do to make that happen. Should I rebase on that branch?

Thanks for the offer. I went ahead and opened the backport PR to make life easy: #2561

@cpu cpu added this pull request to the merge queue Jul 14, 2025
Merged via the queue into rustls:main with commit 6ff3ee0 Jul 14, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JonathanBrouwer @cpu @djc @ctz