Skip to content

Improve compactness of Debug impl for extensions #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Improve compactness of Debug impl for extensions #2546

merged 1 commit into from
Jul 7, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented Jul 7, 2025

This changes a typical log output from:

[2025-07-07T11:12:48Z TRACE rustls::client::hs] We got ServerHello ServerHelloPayload {
        legacy_version: TLSv1_2,
        random: 7788fd3dbfbdc71ccdc498ca9481063b3465aa2cd4ba6dafbbdd2c62c6240305,
        session_id: d0644d0ad008c9ce3c1fc4ac53a27b4e541629e2812dbda296e700e277a8b54b,
        cipher_suite: TLS13_AES_256_GCM_SHA384,
        compression_method: Null,
        extensions: ServerExtensions {
            ec_point_formats: None,
            server_name_ack: None,
            session_ticket_ack: None,
            renegotiation_info: None,
            selected_protocol: None,
            key_share: Some(
                KeyShareEntry {
                    group: X25519,
                    payload: a77c33030bc849e5c28bccc77baab971515180b488d691dca7218eb30dba8e6c,
                },
            ),
            preshared_key: None,
            client_certificate_type: None,
            server_certificate_type: None,
            extended_master_secret_ack: None,
            certificate_status_request_ack: None,
            selected_version: Some(
                TLSv1_3,
            ),
            transport_parameters: None,
            transport_parameters_draft: None,
            early_data_ack: None,
            encrypted_client_hello_ack: None,
            unknown_extensions: {},
        },
    }

to

[2025-07-07T11:14:27Z TRACE rustls::client::hs] We got ServerHello ServerHelloPayload {
        legacy_version: TLSv1_2,
        random: 99939331b6c6651f8fb629d2c9638af54c58678c23f971779e6e1afe798da72c,
        session_id: 8d40fe95171707857c8316b6fe4b674f7143185fc8ac190024a7a09b536c483f,
        cipher_suite: TLS13_AES_256_GCM_SHA384,
        compression_method: Null,
        extensions: ServerExtensions {
            key_share: KeyShareEntry {
                group: X25519,
                payload: 53465c231a1dd33dc148d5734eb253d8728773826e5a41182ade9a1e11209070,
            },
            selected_version: TLSv1_3,
            unknown_extensions: {},
            ..
        },
    }

by eliding mentions of extensions that are not present.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jul 7, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3108253 3158145 ⚠️ 49892 (1.61%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_1.2_no_crypto_server 1047471 1050981 3510 (0.34%) 0.62%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11316596 11280762 -35834 (-0.32%) 0.87%
handshake_tickets_1.2_no_crypto_server 1207931 1211291 3360 (0.28%) 0.65%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9490191 9467666 -22525 (-0.24%) 1.02%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9502596 9487322 -15274 (-0.16%) 0.94%
handshake_no_resume_1.2_no_crypto_server 74751 74866 115 (0.15%) 0.41%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3752661 3758031 5370 (0.14%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4886998 4893868 6870 (0.14%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10471676 10457353 -14323 (-0.14%) 1.00%
handshake_no_resume_1.3_no_crypto_server 98037 98148 111 (0.11%) 0.92%
handshake_tickets_1.3_no_crypto_server 2064924 2067234 2310 (0.11%) 1.54%
handshake_session_id_1.3_no_crypto_server 2100894 2103204 2310 (0.11%) 1.51%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 64154978 64087225 -67753 (-0.11%) 0.69%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46124476 46164157 39681 (0.09%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4160360 4163870 3510 (0.08%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 64342531 64395038 52507 (0.08%) 0.69%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 64075968 64127324 51356 (0.08%) 0.60%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 64394885 64344694 -50191 (-0.08%) 0.50%
handshake_tickets_ring_1.2_rsa_aes_server 4614664 4618064 3400 (0.07%) 0.20%
handshake_session_id_1.2_no_crypto_client 1154032 1154872 840 (0.07%) 0.74%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 64148168 64193571 45403 (0.07%) 0.58%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3833267 3835967 2700 (0.07%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 64329808 64285907 -43901 (-0.07%) 0.58%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 64167097 64123447 -43650 (-0.07%) 0.25%
handshake_tickets_1.2_no_crypto_client 1241714 1242554 840 (0.07%) 1.92%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 47801312 47769249 -32063 (-0.07%) 0.50%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4165591 4168291 2700 (0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49146803 49177958 31155 (0.06%) 0.35%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 47770338 47797786 27448 (0.06%) 0.54%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 47846617 47871127 24510 (0.05%) 0.39%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3100081 3101661 1580 (0.05%) 0.20%
handshake_session_id_1.3_no_crypto_client 2214002 2215112 1110 (0.05%) 1.81%
handshake_tickets_1.3_no_crypto_client 2232548 2233658 1110 (0.05%) 1.80%
handshake_no_resume_1.2_no_crypto_client 98600 98648 48 (0.05%) 0.25%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 47819652 47799550 -20102 (-0.04%) 0.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49175198 49154920 -20278 (-0.04%) 0.37%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49103149 49086380 -16769 (-0.03%) 0.49%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 64362906 64383352 20446 (0.03%) 0.68%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49146280 49161627 15347 (0.03%) 0.47%
handshake_no_resume_1.3_no_crypto_client 111481 111514 33 (0.03%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2663904 2664635 731 (0.03%) 0.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1755224 1755689 465 (0.03%) 0.58%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49156289 49168032 11743 (0.02%) 0.51%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4273140 4272223 -917 (-0.02%) 1.19%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 64417596 64430742 13146 (0.02%) 0.64%
handshake_session_id_ring_1.2_rsa_aes_client 4240296 4241136 840 (0.02%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4493621 4494461 840 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2661216 2660900 -316 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 47849646 47854656 5010 (0.01%) 0.53%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 64129638 64136346 6708 (0.01%) 0.62%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3299154 3299455 301 (0.01%) 0.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 47872684 47877019 4335 (0.01%) 0.51%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1285062 1285173 111 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49130706 49134867 4161 (0.01%) 0.59%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 64183148 64188499 5351 (0.01%) 0.70%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1286244 1286343 99 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31507383 31509693 2310 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31510264 31512574 2310 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31510572 31512882 2310 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31629363 31631673 2310 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31632244 31634554 2310 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31632552 31634862 2310 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 31965040 31967350 2310 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 31967828 31970138 2310 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 31967841 31970151 2310 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32067280 32069590 2310 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32070068 32072378 2310 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32070081 32072391 2310 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4270882 4271162 280 (0.01%) 0.32%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717594 1717700 106 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30533121 30534231 1110 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30536005 30537115 1110 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30540127 30541237 1110 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30624771 30625881 1110 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30627685 30628795 1110 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30631807 30632917 1110 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 30852545 30853655 1110 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 30855864 30856974 1110 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 30859972 30861082 1110 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 30924155 30925265 1110 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 30927519 30928629 1110 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 30931627 30932737 1110 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3298056 3297955 -101 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 64361658 64359730 -1928 (-0.00%) 0.82%
handshake_no_resume_ring_1.2_rsa_aes_client 2243169 2243217 48 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7210684 7210805 121 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7208723 7208834 111 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2325254 2325287 33 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2330905 2330938 33 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57901361 57900717 -644 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58110319 58109675 -644 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58120284 58119640 -644 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58006216 58005574 -642 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57995386 57994746 -640 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58003240 58002603 -637 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58115019 58114381 -638 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58057382 58056745 -637 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10987644 10987759 115 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11108604 11108715 111 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11114365 11114476 111 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11355483 11355592 109 (0.00%) 1.50%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92580442 92579795 -647 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92576466 92575825 -641 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92521475 92520836 -639 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92530607 92529968 -639 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92532302 92531663 -639 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92570472 92569834 -638 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117342504 117341864 -640 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117295303 117294665 -638 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1758018 1758014 -4 (-0.00%) 1.38%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34729678 34729725 47 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34727959 34727992 33 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45917931 45917924 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46176183 46176177 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80245469 80245479 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46186564 46186560 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80367037 80367043 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46013169 46013172 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80238176 80238171 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80356948 80356944 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46003290 46003288 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80249974 80249977 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46176459 46176460 1 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105032246 105032248 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80356027 80356026 -1 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104985037 104985036 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46010589 46010589 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.24 ms 1.28 ms 0.04 ms (2.83%) 9.16%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.10 ms 0.03 ms (2.37%) 8.62%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.76 ms 1.80 ms 0.04 ms (2.23%) 5.68%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.24 ms 1.26 ms 0.02 ms (1.90%) 7.45%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.60 ms 1.63 ms 0.03 ms (1.80%) 6.45%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 4.99 ms 5.07 ms 0.08 ms (1.70%) 3.48%
handshake_no_resume_1.2_no_crypto 76.90 µs 78.17 µs 1.27 µs (1.65%) 9.70%
transfer_no_resume_1.3_no_crypto 11.72 ms 11.89 ms 0.17 ms (1.49%) 3.11%
handshake_no_resume_1.3_no_crypto 85.71 µs 86.94 µs 1.24 µs (1.44%) 11.32%
handshake_tickets_1.3_no_crypto 632.69 µs 640.69 µs 8.00 µs (1.26%) 4.29%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.20 ms 5.26 ms 0.06 ms (1.10%) 3.63%
handshake_tickets_1.2_no_crypto 374.91 µs 378.63 µs 3.73 µs (0.99%) 4.04%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.54 ms 4.57 ms 0.03 ms (0.74%) 4.36%
transfer_no_resume_ring_1.2_rsa_aes 5.71 ms 5.75 ms 0.04 ms (0.71%) 3.02%
handshake_session_id_1.3_no_crypto 653.72 µs 658.24 µs 4.52 µs (0.69%) 5.16%
transfer_no_resume_ring_1.3_rsa_aes 5.78 ms 5.82 ms 0.04 ms (0.68%) 3.80%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.30 ms 5.33 ms 0.03 ms (0.62%) 3.71%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.23 ms 5.26 ms 0.03 ms (0.61%) 3.27%
handshake_session_id_1.2_no_crypto 345.44 µs 347.39 µs 1.95 µs (0.56%) 4.10%
handshake_no_resume_ring_1.3_ecdsap256_chacha 455.07 µs 457.16 µs 2.09 µs (0.46%) 2.64%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.67 ms 13.73 ms 0.06 ms (0.45%) 1.26%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.40 ms 8.43 ms 0.04 ms (0.42%) 2.42%
transfer_no_resume_ring_1.3_rsa_chacha 13.34 ms 13.39 ms 0.05 ms (0.35%) 1.36%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.85 ms 12.90 ms 0.04 ms (0.33%) 1.85%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.00 ms 13.04 ms 0.04 ms (0.30%) 1.29%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.69 ms 13.73 ms 0.04 ms (0.29%) 1.15%
handshake_session_id_ring_1.2_rsa_aes 1.47 ms 1.48 ms 0.00 ms (0.29%) 1.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.60 ms 8.57 ms -0.02 ms (-0.28%) 1.18%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 577.06 µs 578.63 µs 1.57 µs (0.27%) 2.43%
transfer_no_resume_1.2_no_crypto 11.67 ms 11.70 ms 0.03 ms (0.25%) 2.04%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.27 ms 9.25 ms -0.02 ms (-0.24%) 1.05%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.14 ms 9.12 ms -0.02 ms (-0.24%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 578.77 µs 580.13 µs 1.36 µs (0.23%) 2.45%
transfer_no_resume_ring_1.3_ecdsap384_chacha 15.95 ms 15.99 ms 0.04 ms (0.22%) 1.24%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.64 ms 8.62 ms -0.02 ms (-0.22%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.47 ms 5.45 ms -0.01 ms (-0.21%) 1.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 9.08 ms 9.06 ms -0.02 ms (-0.20%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 947.38 µs 949.19 µs 1.80 µs (0.19%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.46 ms 8.44 ms -0.01 ms (-0.17%) 1.19%
handshake_tickets_ring_1.3_ecdsap256_aes 5.50 ms 5.49 ms -0.01 ms (-0.17%) 1.08%
handshake_no_resume_ring_1.3_rsa_aes 947.27 µs 948.86 µs 1.59 µs (0.17%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 941.30 µs 942.75 µs 1.44 µs (0.15%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.32 ms 9.31 ms -0.01 ms (-0.14%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 5.95 ms 5.95 ms -0.01 ms (-0.13%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.55 ms 1.56 ms 0.00 ms (0.12%) 2.16%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.25 ms 1.26 ms 0.00 ms (0.12%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.10 ms 9.11 ms 0.01 ms (0.11%) 1.24%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.40 ms 8.40 ms -0.01 ms (-0.10%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.56 ms 8.55 ms -0.01 ms (-0.10%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.27 ms 9.28 ms 0.01 ms (0.10%) 1.02%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.15 ms 9.16 ms 0.01 ms (0.10%) 1.47%
handshake_tickets_ring_1.3_rsa_aes 5.98 ms 5.98 ms -0.01 ms (-0.10%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.50 ms 8.49 ms -0.01 ms (-0.09%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_aes 459.93 µs 460.34 µs 0.42 µs (0.09%) 2.44%
handshake_tickets_ring_1.3_ecdsap384_aes 8.59 ms 8.58 ms -0.01 ms (-0.07%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.53 ms 8.52 ms -0.01 ms (-0.07%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.55 ms 3.56 ms 0.00 ms (0.06%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 5.90 ms 5.89 ms -0.00 ms (-0.06%) 1.08%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.55 ms 0.00 ms (0.05%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.26 ms 1.26 ms 0.00 ms (0.04%) 1.10%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.40 ms 5.40 ms -0.00 ms (-0.04%) 1.35%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.31 ms 9.31 ms 0.00 ms (0.03%) 1.56%
handshake_session_id_ring_1.3_ecdsap256_aes 5.43 ms 5.43 ms 0.00 ms (0.01%) 1.15%
handshake_session_id_ring_1.3_rsa_aes 5.93 ms 5.93 ms 0.00 ms (0.01%) 1.00%

Additional information

Historical results

Checkout details:

djc
djc approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov Codecov
Copy link

codecov bot commented Jul 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (a5433a1) to head (b9ad54f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2546   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files          97       97           
  Lines       21607    21615    +8     
=======================================
+ Hits        20591    20599    +8     
  Misses       1016     1016

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cpu
cpu approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ctz ctz added this pull request to the merge queue Jul 7, 2025
Merged via the queue into main with commit efa2066 Jul 7, 2025
34 checks passed
@ctz ctz deleted the jbp-ext-impl-debug branch July 7, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu