Skip to content

Adopt webpki 0.103.4 #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

Adopt webpki 0.103.4 #2531

merged 2 commits into from
Jul 10, 2025

Conversation

djc
Copy link
Member

@djc djc commented Jun 30, 2025 •
edited
Loading

Proposed release notes

  • Improved errors for invalid signature algorithms; added variants to both CertificateError and CertRevocationError to replace the UnsupportedSignatureAlgorithm variant (now deprecated) in order to provide more context.
  • Added support for post-quantum ML-DSA signature schemes when compiled with the aws-lc-rs-unstable Cargo feature.

Depends on:

@djc djc requested review from cpu and ctz June 30, 2025 11:15
@djc djc marked this pull request as draft June 30, 2025 11:15
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jun 30, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_1.2_no_crypto_client 1154872 1162312 ⚠️ 7440 (0.64%) 0.45%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3834107 3842357 ⚠️ 8250 (0.22%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_1.3_no_crypto_client 2204012 2225072 21060 (0.96%) 1.81%
handshake_tickets_1.3_no_crypto_client 2222558 2243618 21060 (0.95%) 1.80%
handshake_tickets_1.2_no_crypto_client 1242554 1250624 8070 (0.65%) 0.69%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 63400808 63715317 314509 (0.50%) 0.81%
handshake_session_id_1.2_no_crypto_server 1051191 1046631 -4560 (-0.43%) 0.62%
handshake_tickets_1.2_no_crypto_server 1211501 1206551 -4950 (-0.41%) 0.65%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 63608535 63807280 198745 (0.31%) 0.52%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 47831443 47973196 141753 (0.30%) 0.39%
handshake_no_resume_1.3_no_crypto_client 112142 112443 301 (0.27%) 1.23%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 63609058 63768534 159476 (0.25%) 0.83%
handshake_no_resume_1.2_no_crypto_server 74873 74693 -180 (-0.24%) 0.41%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4166431 4175311 8880 (0.21%) 0.26%
handshake_tickets_ring_1.2_rsa_aes_client 4494461 4503431 8970 (0.20%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 63480760 63355781 -124979 (-0.20%) 0.60%
handshake_session_id_ring_1.2_rsa_aes_client 4241136 4249476 8340 (0.20%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10470518 10488676 18158 (0.17%) 1.03%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49139394 49224469 85075 (0.17%) 0.34%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 47829951 47753460 -76491 (-0.16%) 0.54%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 63507425 63606457 99032 (0.16%) 0.73%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 63555362 63639323 83961 (0.13%) 0.82%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49130753 49194817 64064 (0.13%) 0.48%
handshake_session_id_ring_1.2_rsa_aes_server 4164080 4159090 -4990 (-0.12%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4618274 4612894 -5380 (-0.12%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3756381 3752061 -4320 (-0.12%) 0.20%
handshake_no_resume_1.2_no_crypto_client 98648 98750 102 (0.10%) 0.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 63707141 63768868 61727 (0.10%) 0.81%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4890568 4885858 -4710 (-0.10%) 0.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 47910508 47873685 -36823 (-0.08%) 0.53%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 47836207 47870211 34004 (0.07%) 0.50%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 63537130 63492152 -44978 (-0.07%) 0.62%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305287 3307578 2291 (0.07%) 0.25%
handshake_no_resume_1.3_no_crypto_server 98327 98263 -64 (-0.07%) 0.73%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49084977 49113022 28045 (0.06%) 0.59%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49159194 49131162 -28032 (-0.06%) 0.49%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30304555 30320605 16050 (0.05%) 0.30%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30301795 30317841 16046 (0.05%) 0.30%
handshake_session_id_ring_1.3_rsa_chacha_client 30308677 30324697 16020 (0.05%) 0.30%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30393445 30409491 16046 (0.05%) 0.30%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30396235 30412255 16020 (0.05%) 0.30%
handshake_session_id_ring_1.3_rsa_aes_client 30400357 30416347 15990 (0.05%) 0.30%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 30558624 30574688 16064 (0.05%) 0.30%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 30555367 30571415 16048 (0.05%) 0.30%
handshake_tickets_ring_1.3_rsa_chacha_client 30562736 30578770 16034 (0.05%) 0.30%
handshake_tickets_ring_1.3_ecdsap384_aes_client 30626977 30643025 16048 (0.05%) 0.30%
handshake_tickets_ring_1.3_ecdsap256_aes_client 30630279 30646319 16040 (0.05%) 0.29%
handshake_tickets_ring_1.3_rsa_aes_client 30634391 30650401 16010 (0.05%) 0.30%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3306078 3304418 -1660 (-0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4292841 4294975 2134 (0.05%) 0.43%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 63724252 63696517 -27735 (-0.04%) 0.72%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11320236 11315376 -4860 (-0.04%) 1.50%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4296904 4295311 -1593 (-0.04%) 2.12%
handshake_session_id_1.3_no_crypto_server 2108510 2109290 780 (0.04%) 1.21%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11335327 11331168 -4159 (-0.04%) 1.08%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3123962 3125066 1104 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 63366679 63388075 21396 (0.03%) 0.31%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49186972 49203537 16565 (0.03%) 0.45%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 47889907 47874771 -15136 (-0.03%) 0.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9521638 9518819 -2819 (-0.03%) 0.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2661745 2660998 -747 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 63730922 63748779 17857 (0.03%) 0.72%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1758114 1757782 -332 (-0.02%) 1.38%
handshake_tickets_1.3_no_crypto_server 2072423 2072783 360 (0.02%) 1.21%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1285340 1285130 -210 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 31975097 31970057 -5040 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32077337 32072297 -5040 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 31975088 31970078 -5010 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32077328 32072318 -5010 (-0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 31972292 31967312 -4980 (-0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32074532 32069552 -4980 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1286510 1286312 -198 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31517634 31513014 -4620 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31639614 31634994 -4620 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31514503 31509943 -4560 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2338946 2339284 338 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31636483 31631923 -4560 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31517252 31512722 -4530 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333295 2333630 335 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31639232 31634702 -4530 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1755451 1755685 234 (0.01%) 0.57%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49170972 49165689 -5283 (-0.01%) 0.51%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9516235 9515520 -715 (-0.01%) 1.08%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 47776345 47772856 -3489 (-0.01%) 0.23%
handshake_no_resume_ring_1.2_rsa_aes_client 2243217 2243361 144 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717638 1717733 95 (0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46011157 46009151 -2006 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45917925 45915927 -1998 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46012423 46010421 -2002 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46019297 46017298 -1999 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46176667 46174665 -2002 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46124479 46122482 -1997 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46174699 46172703 -1996 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46187605 46185616 -1989 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58056742 58058631 1889 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57900718 57902595 1877 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2664066 2664147 81 (0.00%) 0.27%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7209001 7208797 -204 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 63503232 63501458 -1774 (-0.00%) 0.90%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7210953 7210766 -187 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80254185 80252179 -2006 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80368092 80366085 -2007 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80246037 80244037 -2000 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80249222 80247222 -2000 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80357151 80355149 -2002 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80354538 80352546 -1992 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34737710 34738551 841 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736004 34736821 817 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11108882 11108668 -214 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11114643 11114429 -214 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105030685 105029322 -1363 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104985035 104983676 -1359 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10987766 10987629 -137 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58004370 58004908 538 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58122304 58122839 535 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57995661 57996192 531 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58112304 58112836 532 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58007292 58007823 531 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58122326 58122855 529 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92582462 92582998 536 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92531741 92532272 531 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92533378 92533909 531 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92521751 92522281 530 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92583766 92584296 530 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92572474 92572996 522 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3131709 3131693 -16 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117341923 117342451 528 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117294663 117294561 -102 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.28 ms 1.24 ms -0.04 ms (-3.23%) 10.61%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.06 ms -0.03 ms (-2.77%) 8.71%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.62 ms 1.57 ms -0.04 ms (-2.71%) 6.56%
handshake_no_resume_1.3_no_crypto 85.66 µs 83.38 µs -2.28 µs (-2.66%) 9.97%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.26 ms 1.23 ms -0.03 ms (-2.61%) 7.84%
handshake_no_resume_1.2_no_crypto 76.04 µs 74.20 µs -1.84 µs (-2.42%) 9.61%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.77 ms 1.73 ms -0.04 ms (-2.35%) 6.14%
handshake_session_id_1.2_no_crypto 341.76 µs 336.95 µs -4.81 µs (-1.41%) 3.77%
transfer_no_resume_1.3_no_crypto 11.86 ms 11.70 ms -0.16 ms (-1.35%) 3.10%
handshake_session_id_ring_1.2_rsa_aes 1.47 ms 1.46 ms -0.01 ms (-0.78%) 1.47%
handshake_tickets_1.3_no_crypto 626.48 µs 622.46 µs -4.02 µs (-0.64%) 5.05%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.24 ms 9.28 ms 0.04 ms (0.48%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.54 ms 1.54 ms -0.01 ms (-0.48%) 2.64%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.55 ms 8.59 ms 0.04 ms (0.47%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.51 ms 8.55 ms 0.04 ms (0.45%) 1.15%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.00 ms 4.98 ms -0.02 ms (-0.45%) 4.60%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 580.17 µs 577.62 µs -2.54 µs (-0.44%) 2.40%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.20 ms 9.24 ms 0.04 ms (0.43%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_aes 459.07 µs 457.11 µs -1.95 µs (-0.43%) 2.74%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.39 ms 8.42 ms 0.03 ms (0.35%) 1.21%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.21 ms 5.19 ms -0.02 ms (-0.34%) 4.92%
handshake_no_resume_ring_1.2_rsa_aes 941.69 µs 938.55 µs -3.14 µs (-0.33%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.06 ms 9.09 ms 0.03 ms (0.33%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 454.58 µs 453.09 µs -1.49 µs (-0.33%) 2.62%
handshake_no_resume_ring_1.3_rsa_aes 948.30 µs 945.36 µs -2.94 µs (-0.31%) 1.00%
handshake_session_id_1.3_no_crypto 643.91 µs 645.89 µs 1.99 µs (0.31%) 5.14%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.35 ms 8.38 ms 0.03 ms (0.30%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 9.02 ms 9.05 ms 0.03 ms (0.30%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.52 ms 4.53 ms 0.01 ms (0.21%) 4.36%
transfer_no_resume_ring_1.2_rsa_aes 5.71 ms 5.72 ms 0.01 ms (0.18%) 3.24%
transfer_no_resume_ring_1.3_rsa_aes 5.78 ms 5.79 ms 0.01 ms (0.18%) 3.89%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 576.76 µs 575.77 µs -0.99 µs (-0.17%) 2.02%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.26 ms 1.26 ms -0.00 ms (-0.17%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.07 ms 9.05 ms -0.01 ms (-0.16%) 1.42%
handshake_session_id_ring_1.3_rsa_chacha 5.87 ms 5.86 ms -0.01 ms (-0.16%) 1.01%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.55 ms 3.55 ms -0.01 ms (-0.15%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 947.03 µs 945.62 µs -1.41 µs (-0.15%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.22 ms 5.23 ms 0.01 ms (0.15%) 3.59%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.25 ms 9.26 ms 0.01 ms (0.14%) 1.52%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.26 ms 1.25 ms -0.00 ms (-0.12%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.69 ms 13.67 ms -0.02 ms (-0.11%) 1.82%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.55 ms -0.00 ms (-0.10%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.38 ms 5.37 ms -0.01 ms (-0.10%) 1.17%
handshake_session_id_ring_1.3_ecdsap256_aes 5.40 ms 5.40 ms -0.01 ms (-0.10%) 1.15%
transfer_no_resume_ring_1.3_rsa_chacha 13.33 ms 13.35 ms 0.01 ms (0.09%) 1.39%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.46 ms 8.45 ms -0.01 ms (-0.09%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 5.89 ms 5.89 ms -0.00 ms (-0.08%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.54 ms 8.55 ms 0.01 ms (0.07%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.43 ms 5.42 ms -0.00 ms (-0.06%) 1.10%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.11 ms 9.10 ms -0.01 ms (-0.06%) 1.46%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.30 ms 5.30 ms -0.00 ms (-0.06%) 3.92%
handshake_session_id_ring_1.3_ecdsap384_aes 8.49 ms 8.48 ms -0.00 ms (-0.05%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.46 ms 5.45 ms -0.00 ms (-0.05%) 1.16%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.68 ms 13.69 ms 0.01 ms (0.05%) 1.54%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.23 ms 9.23 ms 0.00 ms (0.04%) 1.30%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.40 ms 8.39 ms -0.00 ms (-0.03%) 2.44%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.85 ms 12.86 ms 0.00 ms (0.03%) 1.88%
transfer_no_resume_1.2_no_crypto 11.67 ms 11.66 ms -0.00 ms (-0.03%) 1.80%
handshake_tickets_1.2_no_crypto 372.26 µs 372.17 µs -0.08 µs (-0.02%) 3.43%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.52 ms 8.51 ms -0.00 ms (-0.02%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.00 ms 13.01 ms 0.00 ms (0.02%) 1.57%
transfer_no_resume_ring_1.3_ecdsap384_chacha 15.95 ms 15.95 ms 0.00 ms (0.01%) 1.40%
handshake_tickets_ring_1.3_rsa_aes 5.94 ms 5.95 ms 0.00 ms (0.01%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 5.91 ms 5.91 ms 0.00 ms (0.00%) 1.00%

Additional information

Historical results

Checkout details:

@djc djc force-pushed the sig-alg-ctx-errors branch 2 times, most recently from ddab3c3 to cc87270 Compare June 30, 2025 11:29
@djc djc changed the title Propagate context for webpki signature algorithm errors Adopt webpki 0.103.4 Jun 30, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.78626% with 16 lines in your changes missing coverage. Please review.

Project coverage is 95.25%. Comparing base (c84675e) to head (32cfadb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/webpki/mod.rs 74.19% 16 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2531      +/-   ##
==========================================
- Coverage   95.30%   95.25%   -0.06%     
==========================================
  Files          97       97              
  Lines       21639    21763     +124     
==========================================
+ Hits        20623    20730     +107     
- Misses       1016     1033      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc djc force-pushed the sig-alg-ctx-errors branch from cc87270 to 70f5d3e Compare June 30, 2025 11:48
ctz
ctz reviewed Jun 30, 2025
View reviewed changes
@djc djc force-pushed the sig-alg-ctx-errors branch 4 times, most recently from b10c0b3 to da5ab68 Compare June 30, 2025 14:58
@djc djc force-pushed the sig-alg-ctx-errors branch from da5ab68 to 95105c1 Compare July 3, 2025 15:05
djc
djc commented Jul 3, 2025
View reviewed changes
@djc djc requested a review from ctz July 3, 2025 15:07
@djc
Copy link
Member Author

djc commented Jul 3, 2025 •
edited
Loading

@ctz added a commit for adding ML-DSA and release notes. Suppose that makes this complete and ready for release?

@djc
Copy link
Member Author

djc commented Jul 3, 2025

@ctz added a commit for adding ML-DSA and release notes. Suppose that makes this complete and ready for release?

Any suggestions on how we should defend the new feature in CI?

ctz
ctz reviewed Jul 3, 2025
View reviewed changes
@djc djc force-pushed the sig-alg-ctx-errors branch from 95105c1 to 0ef39d1 Compare July 10, 2025 08:49
@djc djc force-pushed the sig-alg-ctx-errors branch from 0ef39d1 to 32cfadb Compare July 10, 2025 11:27
@djc djc marked this pull request as ready for review July 10, 2025 11:32
@djc djc added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit 4e0b5fe Jul 10, 2025
33 of 34 checks passed
@djc djc deleted the sig-alg-ctx-errors branch July 10, 2025 11:48
@djc
Copy link
Member Author

djc commented Jul 10, 2025

  • Published rustls v0.23.29 at registry crates-io
  • [new tag] v/0.23.29 -> v/0.23.29
  • Release notes

@cpu cpu mentioned this pull request Jul 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

@cpu cpu Awaiting requested review from cpu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djc @ctz