Skip to content

add From<Arc<CertifiedKey>> for SingleCertAndKey #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

add From<Arc<CertifiedKey>> for SingleCertAndKey #2535

merged 1 commit into from
Jul 1, 2025

Conversation

stormshield-gt
Copy link
Contributor

For my use case, the Arc<CertifiedKey> is shared between the client and server certificate resolver.
This commit avoid cloning the CertifiedKey

@codecov Codecov
Copy link

codecov bot commented Jul 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.30%. Comparing base (41be2eb) to head (e1f9d7a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/crypto/signer.rs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2535      +/-   ##
==========================================
- Coverage   95.31%   95.30%   -0.02%     
==========================================
  Files          97       97              
  Lines       21517    21520       +3     
==========================================
  Hits        20510    20510              
- Misses       1007     1010       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jul 1, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3107678 3156882 ⚠️ 49204 (1.58%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10454656 10506158 51502 (0.49%) 1.24%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 64878467 64606597 -271870 (-0.42%) 0.58%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9475772 9504943 29171 (0.31%) 0.91%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49559812 49411306 -148506 (-0.30%) 0.38%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11318761 11297071 -21690 (-0.19%) 1.62%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11325585 11338711 13126 (0.12%) 0.94%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 64769270 64703620 -65650 (-0.10%) 0.76%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 64511132 64447701 -63431 (-0.10%) 0.60%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 64396452 64451666 55214 (0.09%) 0.51%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4274337 4277671 3334 (0.08%) 0.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 64394425 64443224 48799 (0.08%) 0.42%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49490921 49458204 -32717 (-0.07%) 0.40%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 48167166 48135336 -31830 (-0.07%) 0.47%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 48052933 48081967 29034 (0.06%) 0.38%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1761137 1762157 1020 (0.06%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9506449 9501340 -5109 (-0.05%) 1.05%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 48112147 48136737 24590 (0.05%) 0.42%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4278652 4280073 1421 (0.03%) 1.10%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3114032 3113064 -968 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 64693623 64712964 19341 (0.03%) 0.59%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1763920 1764350 430 (0.02%) 1.26%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 64435469 64448597 13128 (0.02%) 0.29%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 64568253 64580679 12426 (0.02%) 0.78%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 48084223 48090549 6326 (0.01%) 0.28%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49379402 49385554 6152 (0.01%) 0.49%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49415718 49411566 -4152 (-0.01%) 0.52%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2667239 2667078 -161 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 64523024 64525123 2099 (0.00%) 0.54%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 64338326 64336289 -2037 (-0.00%) 0.47%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2670188 2670108 -80 (-0.00%) 0.23%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49340081 49341306 1225 (0.00%) 0.47%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 48031991 48030988 -1003 (-0.00%) 0.51%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1291219 1291241 22 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 48132282 48133019 737 (0.00%) 0.40%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 64457559 64456743 -816 (-0.00%) 0.56%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49366551 49366902 351 (0.00%) 0.54%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 64572770 64573144 374 (0.00%) 0.76%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1290045 1290049 4 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3304427 3304419 -8 (-0.00%) 0.23%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303149 3303155 6 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45917935 45917924 -11 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46124480 46124488 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57994755 57994747 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58056743 58056751 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46176470 46176464 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57900717 57900724 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46010595 46010590 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58114384 58114378 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80238168 80238176 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80356016 80356023 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46176179 46176182 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80249971 80249976 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80356944 80356939 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92575822 92575817 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92579796 92579801 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46003290 46003288 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80367039 80367042 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58002603 58002601 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58005576 58005574 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58119641 58119643 2 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117294666 117294662 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80245476 80245474 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58109675 58109676 1 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117341861 117341859 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92520832 92520831 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92569831 92569832 1 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104985035 104985034 -1 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105032246 105032245 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46013173 46013173 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_server 2068224 2068224 0 (0.00%) 2.28%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92529959 92529959 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_client 1151902 1151902 0 (0.00%) 2.08%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31735402 31735402 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31149291 31149291 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31084675 31084675 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31735636 31735636 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31080572 31080572 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11113591 11113591 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31077681 31077681 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32192921 32192921 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32292807 32292807 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31857616 31857616 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32295161 32295161 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34732983 34732983 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30764928 30764928 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3751431 3751431 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30761070 30761070 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31156330 31156330 0 (0.00%) 0.20%
handshake_tickets_1.2_no_crypto_server 1205861 1205861 0 (0.00%) 0.65%
handshake_session_id_1.3_no_crypto_server 2104314 2104314 0 (0.00%) 2.26%
handshake_tickets_ring_1.3_rsa_chacha_server 32190567 32190567 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4613444 4613444 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31732777 31732777 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32192906 32192906 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30757951 30757951 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_server 1045521 1045521 0 (0.00%) 0.62%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30852750 30852750 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2330277 2330277 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31854757 31854757 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_client 98547 98547 0 (0.00%) 0.37%
handshake_session_id_ring_1.2_rsa_aes_server 4159220 4159220 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30849601 30849601 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11119352 11119352 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32295146 32295146 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3831857 3831857 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46186560 46186560 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4492301 4492301 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4238976 4238976 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2335928 2335928 0 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_server 98122 98122 0 (0.00%) 1.55%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4164181 4164181 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34734699 34734699 0 (0.00%) 0.20%
handshake_session_id_1.3_no_crypto_client 2216462 2216462 0 (0.00%) 2.75%
handshake_no_resume_1.3_no_crypto_client 111581 111581 0 (0.00%) 1.32%
handshake_tickets_1.2_no_crypto_client 1239584 1239584 0 (0.00%) 2.08%
handshake_no_resume_ring_1.2_rsa_aes_client 2243095 2243095 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30856608 30856608 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7213712 7213712 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92531662 92531662 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7215671 7215671 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31857382 31857382 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_server 74674 74674 0 (0.00%) 1.28%
handshake_no_resume_ring_1.2_rsa_aes_server 10987546 10987546 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717574 1717574 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4885648 4885648 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31152227 31152227 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_client 2235008 2235008 0 (0.00%) 2.72%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_1.2_no_crypto 75.93 µs 77.67 µs 1.74 µs (2.29%) 10.28%
handshake_no_resume_1.3_no_crypto 84.86 µs 86.79 µs 1.93 µs (2.27%) 11.33%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.54 ms 4.58 ms 0.04 ms (0.95%) 4.48%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.23 ms 5.27 ms 0.05 ms (0.88%) 3.92%
handshake_tickets_1.3_no_crypto 624.39 µs 629.80 µs 5.41 µs (0.87%) 4.11%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.19 ms 5.24 ms 0.04 ms (0.84%) 3.80%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 4.98 ms 5.02 ms 0.04 ms (0.80%) 3.56%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.31 ms 5.35 ms 0.04 ms (0.74%) 4.00%
transfer_no_resume_ring_1.2_rsa_aes 5.72 ms 5.76 ms 0.04 ms (0.67%) 3.02%
handshake_session_id_1.3_no_crypto 645.24 µs 649.49 µs 4.25 µs (0.66%) 5.14%
transfer_no_resume_ring_1.3_rsa_aes 5.80 ms 5.83 ms 0.04 ms (0.62%) 3.80%
handshake_no_resume_ring_1.3_ecdsap256_chacha 454.24 µs 456.83 µs 2.59 µs (0.57%) 2.69%
handshake_no_resume_ring_1.3_ecdsap256_aes 457.48 µs 460.01 µs 2.53 µs (0.55%) 2.45%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.40 ms 8.44 ms 0.04 ms (0.51%) 2.64%
handshake_session_id_1.2_no_crypto 340.44 µs 342.08 µs 1.64 µs (0.48%) 4.37%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 576.90 µs 579.40 µs 2.51 µs (0.43%) 3.16%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 577.92 µs 580.37 µs 2.45 µs (0.42%) 3.05%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.59 ms 8.62 ms 0.03 ms (0.40%) 1.33%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 9.08 ms 9.11 ms 0.03 ms (0.38%) 1.83%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.41 ms 8.44 ms 0.03 ms (0.37%) 1.96%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.09 ms 9.12 ms 0.03 ms (0.34%) 2.46%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.13 ms 9.17 ms 0.03 ms (0.33%) 1.09%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.59 ms 1.60 ms 0.01 ms (0.33%) 6.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.27 ms 9.30 ms 0.03 ms (0.32%) 1.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.63 ms 8.66 ms 0.03 ms (0.32%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.14 ms 9.16 ms 0.03 ms (0.31%) 2.25%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.46 ms 8.49 ms 0.03 ms (0.31%) 1.41%
transfer_no_resume_1.2_no_crypto 11.67 ms 11.70 ms 0.04 ms (0.31%) 2.03%
transfer_no_resume_ring_1.3_rsa_chacha 13.35 ms 13.39 ms 0.04 ms (0.30%) 1.36%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.01 ms 13.05 ms 0.04 ms (0.30%) 1.56%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.32 ms 9.35 ms 0.03 ms (0.29%) 1.18%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.67 ms 13.71 ms 0.04 ms (0.29%) 1.40%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.69 ms 13.73 ms 0.04 ms (0.29%) 1.39%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.86 ms 12.90 ms 0.04 ms (0.29%) 1.86%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.27 ms 9.30 ms 0.03 ms (0.27%) 2.46%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.23 ms 1.23 ms 0.00 ms (0.25%) 6.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.25 ms 1.26 ms 0.00 ms (0.25%) 1.00%
transfer_no_resume_1.3_no_crypto 11.85 ms 11.88 ms 0.03 ms (0.24%) 2.74%
transfer_no_resume_ring_1.3_ecdsap384_chacha 15.96 ms 16.00 ms 0.04 ms (0.24%) 1.43%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.30 ms 9.32 ms 0.02 ms (0.24%) 2.48%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.74 ms 1.75 ms 0.00 ms (0.23%) 4.52%
handshake_tickets_ring_1.2_rsa_aes 1.55 ms 1.55 ms 0.00 ms (0.21%) 1.27%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.24 ms 1.24 ms 0.00 ms (0.21%) 8.52%
handshake_no_resume_ring_1.3_rsa_aes 947.70 µs 949.41 µs 1.71 µs (0.18%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 947.74 µs 949.40 µs 1.66 µs (0.18%) 1.05%
handshake_no_resume_ring_1.2_rsa_aes 939.22 µs 940.76 µs 1.54 µs (0.16%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.47 ms 1.47 ms 0.00 ms (0.15%) 1.49%
handshake_tickets_1.2_no_crypto 372.70 µs 373.26 µs 0.56 µs (0.15%) 4.06%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.26 ms 1.26 ms 0.00 ms (0.15%) 1.27%
handshake_tickets_ring_1.3_rsa_chacha 5.95 ms 5.96 ms 0.01 ms (0.10%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.07 ms 0.00 ms (0.10%) 7.61%
handshake_tickets_ring_1.3_rsa_aes 5.98 ms 5.99 ms 0.01 ms (0.10%) 1.04%
handshake_session_id_ring_1.3_rsa_chacha 5.89 ms 5.90 ms 0.01 ms (0.09%) 1.08%
handshake_session_id_ring_1.3_rsa_aes 5.93 ms 5.93 ms 0.00 ms (0.08%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.56 ms 8.56 ms 0.01 ms (0.07%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.47 ms 5.47 ms 0.00 ms (0.06%) 1.27%
handshake_tickets_ring_1.3_ecdsap256_aes 5.50 ms 5.50 ms 0.00 ms (0.05%) 1.11%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.55 ms 3.56 ms 0.00 ms (0.04%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.59 ms 8.59 ms 0.00 ms (0.04%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.44 ms 5.44 ms 0.00 ms (0.03%) 1.23%
handshake_session_id_ring_1.3_ecdsap384_aes 8.53 ms 8.53 ms 0.00 ms (0.03%) 1.02%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.50 ms 8.50 ms 0.00 ms (0.02%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.55 ms 0.00 ms (0.02%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.41 ms 5.41 ms 0.00 ms (0.00%) 1.24%

Additional information

Historical results

Checkout details:

djc
djc approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@ctz ctz added this pull request to the merge queue Jul 1, 2025
Merged via the queue into rustls:main with commit f2bbec6 Jul 1, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stormshield-gt @djc @cpu @ctz