Simplify the simpleserver example by using rustls::Stream #2522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2522 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 97 97
Lines 21514 21514
=======================================
Hits 20507 20507
Misses 1007 1007 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ctz
approved these changes
Jun 25, 2025
There was a problem hiding this comment.
I think this is OK. I think we don't generally want to encourage rustls::Stream use, as it's pretty narrowly applicable and very hard to make a robust program with (especially for a server!) but actually this is mostly a comment about blocking IO and thread-per-client models.
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
cpu
approved these changes
Jun 25, 2025
There was a problem hiding this comment.
Thanks 👍
I agree with ctz's points that the Stream abstraction's applicability is narrow, but having this example maintain symmetry with the simple client example that uses it makes sense.
Tested locally with tlscient-mio (the simpleclient example is too simple to use a non-system root CA without code changes)
$ RUST_LOG=rustls=trace cargo run --package rustls-examples --bin simpleserver -- test-ca/ecdsa-p256/end.fullchain test-ca/ecdsa-p256/end.key
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.08s
Running `target/debug/simpleserver test-ca/ecdsa-p256/end.fullchain test-ca/ecdsa-p256/end.key`
Received message from client: [71, 69, 84, 32, 47, 32, 72, 84, 84, 80, 47, 49, 46, 48, 13, 10, 72, 111, 115, 116, 58, 32, 108, 111, 99, 97, 108, 104, 111, 115, 116, 13, 10, 67, 111, 110, 110, 101, 99, 116, 105, 111, 110, 58, 32, 99, 108, 111, 115, 101, 13, 10, 65, 99, 99, 101, 112, 116, 45, 69, 110, 99, 111, 100]
$ cargo run --package rustls-examples --bin tlsclient-mio -- --http --port 4443 --cafile test-ca/ecdsa-p256/ca.cert localhost
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.08s
Running `target/debug/tlsclient-mio --http --port 4443 --cafile test-ca/ecdsa-p256/ca.cert localhost`
Hello from the serverEOF
Connection closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2520
This should hopefully make it easier to understand what the idiomatic way to use rustls in the most basic way (as a wrapper over an existing
impl Read+Write) is.cc @cpu