Skip to content

client: refactor client handshake some more #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 25, 2025
Merged

client: refactor client handshake some more #2521

merged 4 commits into from
Jun 25, 2025

Conversation

djc
Copy link
Member

@djc djc commented Jun 25, 2025

No description provided.

@djc djc requested review from cpu and ctz June 25, 2025 09:58
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jun 25, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3822017 3831857 ⚠️ 9840 (0.26%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4154311 4164181 ⚠️ 9870 (0.24%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4229046 4238976 ⚠️ 9930 (0.23%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4482341 4492301 ⚠️ 9960 (0.22%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_1.2_no_crypto_client 1142782 1151902 9120 (0.80%) 2.22%
handshake_tickets_1.2_no_crypto_client 1230434 1239584 9150 (0.74%) 2.74%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10419005 10475404 56399 (0.54%) 0.82%
handshake_session_id_1.3_no_crypto_client 2206472 2216462 9990 (0.45%) 4.27%
handshake_tickets_1.3_no_crypto_client 2225018 2235008 9990 (0.45%) 4.23%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11342216 11300770 -41446 (-0.37%) 1.04%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9490439 9524748 34309 (0.36%) 0.88%
handshake_no_resume_1.3_no_crypto_client 111209 111577 368 (0.33%) 2.13%
handshake_no_resume_1.2_no_crypto_server 74897 74657 -240 (-0.32%) 1.55%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 64397218 64594409 197191 (0.31%) 0.58%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 64701203 64552376 -148827 (-0.23%) 0.69%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 64595733 64704409 108676 (0.17%) 0.27%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49460197 49378433 -81764 (-0.17%) 0.38%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 48107586 48184967 77381 (0.16%) 0.38%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11332543 11349865 17322 (0.15%) 1.59%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 64543141 64445192 -97949 (-0.15%) 0.57%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 64709567 64619882 -89685 (-0.14%) 0.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9482728 9495090 12362 (0.13%) 0.73%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 48186029 48129858 -56171 (-0.12%) 0.49%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 64432585 64500839 68254 (0.11%) 0.42%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49454633 49402331 -52302 (-0.11%) 0.49%
handshake_no_resume_1.2_no_crypto_client 98444 98536 92 (0.09%) 1.86%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49371201 49416567 45366 (0.09%) 0.32%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 64616896 64671773 54877 (0.08%) 0.50%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3301927 3304339 2412 (0.07%) 0.33%
handshake_session_id_1.3_no_crypto_server 2102484 2103924 1440 (0.07%) 7.17%
handshake_tickets_1.3_no_crypto_server 2066514 2067834 1320 (0.06%) 7.35%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1761722 1760650 -1072 (-0.06%) 1.05%
handshake_session_id_1.2_no_crypto_server 1045611 1045011 -600 (-0.06%) 3.68%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 48134267 48161098 26831 (0.06%) 0.42%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 64468655 64500777 32122 (0.05%) 0.57%
handshake_tickets_1.2_no_crypto_server 1205951 1205351 -600 (-0.05%) 2.65%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1764270 1763401 -869 (-0.05%) 1.11%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 64648491 64679712 31221 (0.05%) 0.68%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 48080716 48103210 22494 (0.05%) 0.43%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49435434 49456111 20677 (0.04%) 0.45%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49391892 49411761 19869 (0.04%) 0.28%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 64324793 64345335 20542 (0.03%) 0.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4279747 4278735 -1012 (-0.02%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3107559 3107038 -521 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 64624540 64634594 10054 (0.02%) 0.50%
handshake_session_id_ring_1.3_rsa_chacha_client 30760278 30764928 4650 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30851958 30856608 4650 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30753331 30757951 4620 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30756450 30761070 4620 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30844981 30849601 4620 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30848130 30852750 4620 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31080039 31084675 4636 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31151694 31156330 4636 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31073065 31077681 4616 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31075966 31080572 4606 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31144675 31149291 4616 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31147621 31152227 4606 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32192187 32187537 -4650 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32193356 32188706 -4650 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32193371 32188721 -4650 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32294427 32289777 -4650 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32295596 32290946 -4650 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32295611 32290961 -4650 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31734277 31729747 -4530 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31735732 31731202 -4530 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31735966 31731436 -4530 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31856257 31851727 -4530 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31857712 31853182 -4530 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31857946 31853416 -4530 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1290059 1289908 -151 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1291245 1291100 -145 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2669999 2669701 -298 (-0.01%) 0.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 64433989 64441173 7184 (0.01%) 0.26%
handshake_no_resume_ring_1.3_rsa_aes_client 2330042 2330279 237 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2335693 2335930 237 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 48082999 48079038 -3961 (-0.01%) 0.21%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717440 1717569 129 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 48031890 48034669 2779 (0.01%) 0.31%
handshake_session_id_ring_1.2_rsa_aes_server 4153100 4153310 210 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2667193 2667070 -123 (-0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4607324 4607534 210 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3113255 3113396 141 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49393829 49391857 -1972 (-0.00%) 0.36%
handshake_no_resume_ring_1.2_rsa_aes_client 2243015 2243090 75 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58058669 58056741 -1928 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57902639 57900717 -1922 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3744561 3744681 120 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_server 98105 98108 3 (0.00%) 3.96%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4878778 4878898 120 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10987610 10987349 -261 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7215695 7215530 -165 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7213726 7213571 -155 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117296578 117294666 -1912 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4276572 4276639 67 (0.00%) 0.43%
handshake_no_resume_ring_1.3_rsa_aes_server 11113644 11113489 -155 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11119405 11119250 -155 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34732756 34732983 227 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34734482 34734699 217 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303038 3303037 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57994746 57994755 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58119635 58119644 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46186558 46186565 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46124480 46124486 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92569831 92569842 11 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46010590 46010593 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92520829 92520834 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58005576 58005573 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58109674 58109677 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80245472 80245476 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46176185 46176183 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92575828 92575824 -4 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104985030 104985034 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58002603 58002601 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58114378 58114380 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92579796 92579799 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80249977 80249975 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80356016 80356018 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80356950 80356948 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80367048 80367046 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45917925 45917924 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46003288 46003287 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46013168 46013169 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46176463 46176462 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92529968 92529966 -2 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117341861 117341861 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92531662 92531662 0 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105032246 105032246 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80238176 80238176 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.24 ms 1.29 ms 0.04 ms (3.52%) 8.14%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.75 ms 1.81 ms 0.06 ms (3.19%) 4.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.10 ms 0.03 ms (3.17%) 7.24%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.24 ms 1.27 ms 0.03 ms (2.56%) 5.79%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.60 ms 1.62 ms 0.02 ms (1.54%) 5.53%
handshake_session_id_1.2_no_crypto 349.11 µs 343.99 µs -5.13 µs (-1.47%) 9.62%
handshake_tickets_1.3_no_crypto 642.41 µs 635.99 µs -6.42 µs (-1.00%) 8.95%
handshake_no_resume_1.3_no_crypto 88.26 µs 89.14 µs 0.88 µs (1.00%) 9.25%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.30 ms 5.34 ms 0.04 ms (0.81%) 6.84%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.10 ms 5.14 ms 0.04 ms (0.78%) 5.95%
handshake_session_id_1.3_no_crypto 660.54 µs 657.09 µs -3.45 µs (-0.52%) 8.36%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.18 ms 9.22 ms 0.04 ms (0.42%) 3.05%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.65 ms 8.62 ms -0.03 ms (-0.35%) 2.18%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.47 ms 8.44 ms -0.03 ms (-0.32%) 2.06%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.50 ms 5.49 ms -0.02 ms (-0.28%) 1.46%
transfer_no_resume_ring_1.3_rsa_aes 5.90 ms 5.91 ms 0.02 ms (0.28%) 5.78%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.33 ms 9.30 ms -0.03 ms (-0.27%) 2.13%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.79 ms 13.82 ms 0.03 ms (0.23%) 2.63%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.60 ms 8.58 ms -0.02 ms (-0.23%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.44 ms 5.43 ms -0.01 ms (-0.22%) 1.26%
handshake_no_resume_1.2_no_crypto 80.20 µs 80.37 µs 0.17 µs (0.22%) 6.09%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 9.14 ms 9.12 ms -0.02 ms (-0.21%) 2.08%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.68 ms 8.66 ms -0.02 ms (-0.20%) 2.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 585.58 µs 584.40 µs -1.18 µs (-0.20%) 3.07%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.34 ms 9.36 ms 0.02 ms (0.20%) 2.33%
handshake_tickets_ring_1.3_rsa_chacha 5.99 ms 5.98 ms -0.01 ms (-0.20%) 1.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.27 ms 1.27 ms 0.00 ms (0.19%) 1.66%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.37 ms 9.35 ms -0.02 ms (-0.18%) 1.56%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.53 ms 8.52 ms -0.02 ms (-0.18%) 1.28%
handshake_session_id_ring_1.3_rsa_chacha 5.93 ms 5.92 ms -0.01 ms (-0.18%) 1.17%
handshake_tickets_ring_1.2_rsa_aes 1.56 ms 1.56 ms -0.00 ms (-0.15%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_aes 463.54 µs 464.20 µs 0.65 µs (0.14%) 3.09%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.14 ms 9.15 ms 0.01 ms (0.13%) 2.63%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.50 ms 8.49 ms -0.01 ms (-0.13%) 2.26%
handshake_no_resume_ring_1.3_rsa_aes 951.58 µs 952.82 µs 1.25 µs (0.13%) 1.57%
transfer_no_resume_1.2_no_crypto 11.77 ms 11.79 ms 0.01 ms (0.12%) 2.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 584.45 µs 583.74 µs -0.70 µs (-0.12%) 3.23%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.32 ms 9.33 ms 0.01 ms (0.11%) 2.62%
handshake_no_resume_ring_1.2_rsa_aes 944.38 µs 945.29 µs 0.91 µs (0.10%) 1.14%
handshake_session_id_ring_1.3_ecdsap384_aes 8.57 ms 8.56 ms -0.01 ms (-0.09%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.18 ms 9.17 ms -0.01 ms (-0.08%) 1.76%
transfer_no_resume_ring_1.2_rsa_aes 5.83 ms 5.84 ms 0.00 ms (0.08%) 4.08%
handshake_no_resume_ring_1.3_rsa_chacha 952.03 µs 952.78 µs 0.75 µs (0.08%) 1.73%
handshake_session_id_ring_1.3_rsa_aes 5.97 ms 5.97 ms 0.00 ms (0.07%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.46 ms 13.47 ms 0.01 ms (0.06%) 2.67%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.42 ms 5.42 ms 0.00 ms (0.06%) 6.67%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.51 ms 8.51 ms 0.00 ms (0.06%) 4.45%
handshake_tickets_ring_1.3_rsa_aes 6.03 ms 6.03 ms 0.00 ms (0.05%) 1.03%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.13 ms 13.13 ms 0.01 ms (0.04%) 2.49%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.34 ms 5.34 ms 0.00 ms (0.04%) 7.01%
handshake_tickets_ring_1.3_ecdsap384_aes 8.63 ms 8.63 ms -0.00 ms (-0.03%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.81 ms 13.81 ms 0.00 ms (0.03%) 2.38%
transfer_no_resume_1.3_no_crypto 11.82 ms 11.83 ms 0.00 ms (0.03%) 3.43%
handshake_tickets_ring_1.3_ecdsap256_aes 5.54 ms 5.54 ms 0.00 ms (0.03%) 1.08%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.56 ms 3.56 ms 0.00 ms (0.03%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.48 ms 1.48 ms 0.00 ms (0.02%) 1.82%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.98 ms 12.98 ms 0.00 ms (0.02%) 2.62%
handshake_no_resume_ring_1.3_ecdsap256_chacha 461.16 µs 461.06 µs -0.10 µs (-0.02%) 3.05%
handshake_session_id_ring_1.3_ecdsap256_aes 5.47 ms 5.47 ms -0.00 ms (-0.02%) 1.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.26 ms 1.26 ms -0.00 ms (-0.01%) 1.39%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.07 ms 16.08 ms 0.00 ms (0.01%) 2.28%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.56 ms 3.56 ms 0.00 ms (0.01%) 1.00%
handshake_tickets_1.2_no_crypto 377.73 µs 377.70 µs -0.03 µs (-0.01%) 9.75%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.65 ms 4.65 ms -0.00 ms (-0.01%) 8.61%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Jun 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.25926% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.31%. Comparing base (4b3c053) to head (1381576).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/client/hs.rs 99.15% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2521   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files          97       97           
  Lines       21504    21514   +10     
=======================================
+ Hits        20496    20507   +11     
+ Misses       1008     1007    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc djc added this pull request to the merge queue Jun 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 25, 2025
@djc djc force-pushed the client-hs-tweaks branch from 8308f78 to 1381576 Compare June 25, 2025 12:59
@djc djc enabled auto-merge June 25, 2025 13:00
@djc djc added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit 8366265 Jun 25, 2025
34 checks passed
@djc djc deleted the client-hs-tweaks branch June 25, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

@cpu cpu Awaiting requested review from cpu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djc @ctz