Skip to content

Delete unusable no-std ticketer code #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

Delete unusable no-std ticketer code #2500

merged 2 commits into from
Jun 16, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented Jun 16, 2025

This code didn't compile since its introduction in 0.23.5:

$ cargo check --lib --no-default-features --features hashbrown,ring,aws-lc-rs
error[E0405]: cannot find trait `TimeProvider` in this scope
  --> rustls/src/crypto/ring/ticketer.rs:41:37
   |
41 |         time_provider: &'static dyn TimeProvider,
   |                                     ^^^^^^^^^^^^ not found in this scope
   |
help: consider importing this trait
   |
1  + use crate::time_provider::TimeProvider;
   |

error[E0405]: cannot find trait `TimeProvider` in this scope
  --> rustls/src/crypto/aws_lc_rs/ticketer.rs:51:37
   |
51 |         time_provider: &'static dyn TimeProvider,
   |                                     ^^^^^^^^^^^^ not found in this scope
   |
help: consider importing this trait
   |
1  + use crate::time_provider::TimeProvider;
   |

Therefore we can conclude deleting it is not a breaking change, and affects no users.

ctz added 2 commits June 16, 2025 13:29
@ctz
Remove no-std ticketer code that didn't compile
25d217a 
This was feature gated under `hashbrown` and `not(feature = std)` but
didn't actually compile for that combination of features.  That means
we can a) conclude nobody ever used this, and b) withdraw this code
in a non-breaking change.
@ctz
ci: extend to check no-std-specific code compiles
f9fb07f
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jun 16, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 64445444 64277319 ✅ -168125 (-0.26%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 64684817 64520450 ✅ -164367 (-0.25%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 64379170 64536544 ⚠️ 157374 (0.24%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10477254 10438757 -38497 (-0.37%) 0.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9522914 9504676 -18238 (-0.19%) 0.92%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11350309 11372010 21701 (0.19%) 1.56%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 64616679 64502990 -113689 (-0.18%) 0.25%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 48232369 48148369 -84000 (-0.17%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49565090 49483147 -81943 (-0.17%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 48255872 48334567 78695 (0.16%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 64363523 64264073 -99450 (-0.15%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49542893 49486064 -56829 (-0.11%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 48201937 48152616 -49321 (-0.10%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 64698506 64751979 53473 (0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 64368808 64419222 50414 (0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 64468916 64419028 -49888 (-0.08%) 0.39%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 64491539 64446445 -45094 (-0.07%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3115585 3113757 -1828 (-0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49599750 49626564 26814 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 48202045 48227123 25078 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 48303304 48278721 -24583 (-0.05%) 0.27%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 48305399 48281645 -23754 (-0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4278528 4276694 -1834 (-0.04%) 0.96%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3108625 3107375 -1250 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 64583407 64559329 -24078 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1766453 1765812 -641 (-0.04%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9505009 9501937 -3072 (-0.03%) 0.56%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2671297 2672125 828 (0.03%) 0.77%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11372879 11369960 -2919 (-0.03%) 1.06%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49524677 49512627 -12050 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4279715 4279039 -676 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3301706 3301972 266 (0.01%) 0.27%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 64687781 64684031 -3750 (-0.01%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2674556 2674710 154 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 64636442 64639279 2837 (0.00%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1767735 1767808 73 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49604642 49602923 -1719 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49580497 49581684 1187 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296047 1296059 12 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305155 3305133 -22 (-0.00%) 0.29%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58008834 58008826 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80361107 80361097 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58070830 58070823 -7 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34733898 34733902 4 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57914804 57914798 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80245472 80245480 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92583911 92583920 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92593876 92593885 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92534905 92534913 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92545741 92545733 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92589908 92589900 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80240656 80240650 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80249978 80249972 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46009953 46009950 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46015087 46015090 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46128690 46128687 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92544046 92544040 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80356016 80356021 5 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117308745 117308738 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58016681 58016678 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58133723 58133720 -3 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104989076 104989071 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46176183 46176181 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46186557 46186559 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58123753 58123755 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80367048 80367046 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46005129 46005130 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58019654 58019655 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58128459 58128460 1 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105032244 105032245 1 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32441189 32441189 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30838268 30838268 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31062278 31062278 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7218304 7218304 0 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_client 112260 112260 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31881263 31881263 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30739481 30739481 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31137842 31137842 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_server 2219015 2219015 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4522443 4522443 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_client 2215824 2215824 0 (0.00%) 0.20%
handshake_session_id_1.3_no_crypto_client 2197255 2197255 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32003243 32003243 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32337295 32337295 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2244009 2244009 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32439580 32439580 0 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_server 102885 102885 0 (0.00%) 0.20%
handshake_session_id_1.3_no_crypto_server 2255135 2255135 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30834070 30834070 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32338732 32338732 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_client 99572 99572 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4261362 4261362 0 (0.00%) 0.20%
handshake_tickets_1.2_no_crypto_server 1311738 1311738 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4982714 4982714 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2331124 2331124 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11129905 11129905 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34735614 34735614 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1718590 1718590 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4707790 4707790 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30746588 30746588 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45922130 45922130 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3857786 3857786 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31130537 31130537 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31058927 31058927 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46180618 46180618 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31879502 31879502 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11124144 11124144 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32338904 32338904 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32440972 32440972 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7220263 7220263 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4197640 4197640 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_client 1176713 1176713 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31133933 31133933 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3846827 3846827 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_server 83949 83949 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_server 1149724 1149724 0 (0.00%) 0.20%
handshake_tickets_1.2_no_crypto_client 1272590 1272590 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30831131 30831131 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32001482 32001482 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30742390 30742390 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31066187 31066187 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1294877 1294877 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32003200 32003200 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31881220 31881220 0 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117355940 117355940 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4252216 4252216 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10996408 10996408 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2336775 2336775 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_1.3_no_crypto 88.68 µs 90.22 µs 1.53 µs (1.73%) 5.00%
handshake_no_resume_1.2_no_crypto 79.98 µs 81.24 µs 1.26 µs (1.58%) 5.00%
handshake_tickets_1.2_no_crypto 394.99 µs 398.61 µs 3.62 µs (0.92%) 5.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.82 ms 1.83 ms 0.01 ms (0.70%) 2.86%
handshake_session_id_1.2_no_crypto 361.85 µs 363.75 µs 1.90 µs (0.52%) 5.00%
handshake_no_resume_ring_1.3_ecdsap256_aes 462.45 µs 464.71 µs 2.26 µs (0.49%) 3.69%
handshake_no_resume_ring_1.3_ecdsap256_chacha 459.69 µs 461.93 µs 2.24 µs (0.49%) 3.71%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.38 ms 9.41 ms 0.04 ms (0.42%) 2.73%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.67 ms 8.71 ms 0.04 ms (0.42%) 2.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.36 ms 9.40 ms 0.04 ms (0.42%) 1.75%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.51 ms 8.54 ms 0.03 ms (0.37%) 1.60%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.33 ms 9.36 ms 0.03 ms (0.36%) 2.39%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.35 ms 9.39 ms 0.03 ms (0.34%) 2.50%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.62 ms 4.63 ms 0.02 ms (0.33%) 7.55%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.65 ms 8.68 ms 0.03 ms (0.33%) 2.41%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.18 ms 9.21 ms 0.03 ms (0.32%) 1.26%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.38 ms 5.40 ms 0.02 ms (0.32%) 4.51%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.26 ms 1.27 ms 0.00 ms (0.32%) 1.72%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.47 ms 8.50 ms 0.03 ms (0.32%) 2.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 582.34 µs 584.13 µs 1.79 µs (0.31%) 3.29%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.23 ms 9.26 ms 0.03 ms (0.30%) 2.37%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 9.14 ms 9.17 ms 0.03 ms (0.30%) 1.86%
transfer_no_resume_ring_1.3_rsa_aes 5.87 ms 5.88 ms 0.02 ms (0.28%) 4.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 583.63 µs 585.25 µs 1.62 µs (0.28%) 3.58%
handshake_no_resume_ring_1.3_rsa_chacha 951.72 µs 954.31 µs 2.58 µs (0.27%) 1.79%
handshake_session_id_1.3_no_crypto 676.36 µs 678.15 µs 1.79 µs (0.26%) 5.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.19 ms 9.22 ms 0.02 ms (0.26%) 2.54%
transfer_no_resume_1.3_no_crypto 11.94 ms 11.97 ms 0.03 ms (0.23%) 5.00%
transfer_no_resume_ring_1.2_rsa_aes 5.80 ms 5.81 ms 0.01 ms (0.22%) 4.69%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.31 ms 5.32 ms 0.01 ms (0.22%) 6.37%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.11 ms 5.12 ms 0.01 ms (0.21%) 5.83%
handshake_tickets_ring_1.2_rsa_aes 1.57 ms 1.58 ms 0.00 ms (0.20%) 1.17%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.48 ms 8.49 ms 0.02 ms (0.19%) 4.18%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.26 ms 1.26 ms 0.00 ms (0.17%) 1.55%
handshake_tickets_1.3_no_crypto 660.29 µs 661.30 µs 1.00 µs (0.15%) 5.00%
handshake_no_resume_ring_1.2_rsa_aes 943.96 µs 945.39 µs 1.43 µs (0.15%) 1.40%
handshake_session_id_ring_1.2_rsa_aes 1.50 ms 1.50 ms 0.00 ms (0.10%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.09 ms 13.10 ms 0.01 ms (0.09%) 2.49%
handshake_no_resume_ring_1.3_rsa_aes 952.34 µs 953.19 µs 0.85 µs (0.09%) 1.46%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.31 ms 5.32 ms 0.00 ms (0.09%) 6.08%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.29 ms 1.29 ms 0.00 ms (0.08%) 5.08%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.65 ms 1.65 ms 0.00 ms (0.08%) 4.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 12.95 ms 0.01 ms (0.07%) 1.93%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.10 ms 1.10 ms -0.00 ms (-0.07%) 4.40%
transfer_no_resume_1.2_no_crypto 11.75 ms 11.76 ms 0.01 ms (0.07%) 5.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.78 ms 13.79 ms 0.01 ms (0.07%) 2.38%
transfer_no_resume_ring_1.3_rsa_chacha 13.43 ms 13.44 ms 0.01 ms (0.07%) 1.83%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.55 ms 0.00 ms (0.06%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.56 ms 8.57 ms 0.00 ms (0.06%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.55 ms 3.56 ms 0.00 ms (0.05%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 5.99 ms 5.98 ms -0.00 ms (-0.05%) 1.22%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.79 ms 13.80 ms 0.01 ms (0.04%) 2.13%
handshake_session_id_ring_1.3_rsa_chacha 5.93 ms 5.93 ms 0.00 ms (0.04%) 1.72%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.58 ms 8.58 ms -0.00 ms (-0.03%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.44 ms 5.44 ms -0.00 ms (-0.03%) 1.71%
handshake_tickets_ring_1.3_ecdsap256_aes 5.53 ms 5.53 ms 0.00 ms (0.03%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 5.97 ms 5.97 ms -0.00 ms (-0.03%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.53 ms 8.52 ms -0.00 ms (-0.03%) 1.29%
handshake_tickets_ring_1.3_ecdsap384_aes 8.62 ms 8.62 ms -0.00 ms (-0.02%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.04 ms 16.04 ms 0.00 ms (0.02%) 2.01%
handshake_tickets_ring_1.3_rsa_aes 6.03 ms 6.02 ms -0.00 ms (-0.01%) 1.08%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.27 ms 1.27 ms -0.00 ms (-0.00%) 5.52%
handshake_session_id_ring_1.3_ecdsap256_aes 5.47 ms 5.47 ms 0.00 ms (0.00%) 1.28%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.50 ms 5.50 ms -0.00 ms (-0.00%) 1.56%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Jun 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.40%. Comparing base (12fe0c1) to head (f9fb07f).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2500   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          97       97           
  Lines       21881    21881           
=======================================
  Hits        20875    20875           
  Misses       1006     1006

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz ctz added this pull request to the merge queue Jun 16, 2025
Merged via the queue into main with commit 834cb11 Jun 16, 2025
34 checks passed
@ctz ctz deleted the jbp-delete-unusable-ticketer-code branch June 16, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu