Skip to content

Further precursor refactors from "Improve TLS extension representation" #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 10, 2025
Merged

Further precursor refactors from "Improve TLS extension representation" #2482

merged 5 commits into from
Jun 10, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented Jun 9, 2025

Some more changes sloughed off from #1475

@ctz ctz mentioned this pull request Jun 9, 2025
Closed
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jun 9, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 64839066 64541014 ✅ -298052 (-0.46%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 64805162 64543429 ✅ -261733 (-0.40%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49687190 49539068 ✅ -148122 (-0.30%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49661813 49530389 ✅ -131424 (-0.26%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 64591673 64757032 ⚠️ 165359 (0.26%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 64621354 64764556 ⚠️ 143202 (0.22%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 64516594 64658463 ⚠️ 141869 (0.22%) 0.21%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10479631 10437549 -42082 (-0.40%) 1.43%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9479371 9507244 27873 (0.29%) 1.25%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11352303 11377567 25264 (0.22%) 1.14%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 64447549 64563535 115986 (0.18%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49562021 49645641 83620 (0.17%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 64472570 64373933 -98637 (-0.15%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 64670457 64573597 -96860 (-0.15%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 48352134 48424360 72226 (0.15%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49606672 49679075 72403 (0.15%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 48268197 48327611 59414 (0.12%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4275245 4279815 4570 (0.11%) 1.01%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 48318137 48270279 -47858 (-0.10%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49629549 49582054 -47495 (-0.10%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 64510582 64460086 -50496 (-0.08%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4282834 4279593 -3241 (-0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 64361855 64317006 -44849 (-0.07%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 64399322 64354801 -44521 (-0.07%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305640 3303427 -2213 (-0.07%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9497293 9502260 4967 (0.05%) 0.60%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 48345823 48321902 -23921 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 48214912 48193829 -21083 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 48240929 48220048 -20881 (-0.04%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4298146 4299946 1800 (0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1767705 1768440 735 (0.04%) 1.26%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3869091 3870591 1500 (0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2673047 2673989 942 (0.04%) 0.84%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11321240 11324240 3000 (0.03%) 1.26%
handshake_tickets_ring_1.2_rsa_aes_server 4757454 4758624 1170 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1770727 1770341 -386 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5011030 5011840 810 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3109424 3109897 473 (0.02%) 1.22%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3116100 3116445 345 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4220676 4221036 360 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304603 3304384 -219 (-0.01%) 0.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2676761 2676922 161 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58160532 58163734 3202 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58123154 58126353 3199 (0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58154764 58157964 3200 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58130367 58133565 3198 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58237703 58240906 3203 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58262524 58265723 3199 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3878761 3878971 210 (0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4307830 4307620 -210 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58240566 58243130 2564 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32449863 32451183 1320 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32452630 32453950 1320 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32452672 32453992 1320 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32551818 32553138 1320 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32554540 32555860 1320 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32554627 32555947 1320 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296476 1296527 51 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92668622 92671823 3201 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92691088 92694289 3201 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92659490 92662689 3199 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92697861 92701061 3200 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92700090 92703290 3200 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92723958 92727154 3196 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58036067 58037987 1920 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31986430 31987420 990 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31989482 31990472 990 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31989585 31990575 990 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32108080 32109070 990 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32111132 32112122 990 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32111235 32112225 990 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295297 1295335 38 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30838844 30839674 830 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30842898 30843728 830 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30930134 30930964 830 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30934188 30935018 830 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31157528 31158354 826 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31161516 31162342 826 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31228799 31229625 826 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31232787 31233613 826 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30835915 30836725 810 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30927205 30928015 810 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31154191 31154999 808 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31225441 31226249 808 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 64736962 64735840 -1122 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1720113 1720137 24 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4571268 4571208 -60 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246502 2246518 16 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49655854 49656166 312 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334250 2334263 13 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339899 2339912 13 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7221011 7221051 40 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7222972 7223000 28 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10996538 10996575 37 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11124674 11124709 35 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11130435 11130470 35 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34738039 34738011 -28 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736341 34736327 -14 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46289092 46289081 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284273 46284263 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46457828 46457821 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80633224 80633214 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80638305 80638295 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80644235 80644240 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533867 80533871 4 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189285 46189287 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294221 46294219 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46401604 46401606 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46453379 46453378 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46464403 46464404 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80538689 80538690 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80543188 80543189 1 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.05 ms -0.01 ms (-1.40%) 1.88%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.34 ms 5.41 ms 0.07 ms (1.37%) 6.32%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.57 ms 4.63 ms 0.06 ms (1.33%) 7.65%
transfer_no_resume_ring_1.2_rsa_aes 5.77 ms 5.85 ms 0.08 ms (1.32%) 5.66%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.24 ms 1.22 ms -0.01 ms (-1.20%) 2.94%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.26 ms 5.33 ms 0.06 ms (1.17%) 6.43%
transfer_no_resume_ring_1.3_rsa_aes 5.83 ms 5.89 ms 0.07 ms (1.13%) 5.73%
handshake_no_resume_ring_1.3_ecdsap256_aes 462.73 µs 467.67 µs 4.94 µs (1.07%) 3.97%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.24 ms 1.23 ms -0.01 ms (-1.07%) 2.41%
handshake_no_resume_ring_1.3_ecdsap256_chacha 460.39 µs 465.13 µs 4.74 µs (1.03%) 3.61%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 583.39 µs 588.79 µs 5.40 µs (0.93%) 4.07%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.02 ms 5.07 ms 0.05 ms (0.91%) 6.62%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.62 ms 1.60 ms -0.01 ms (-0.91%) 3.28%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.47 ms 8.54 ms 0.07 ms (0.86%) 3.94%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.23 ms 5.26 ms 0.03 ms (0.67%) 6.41%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 583.16 µs 586.71 µs 3.55 µs (0.61%) 4.60%
handshake_no_resume_ring_1.3_rsa_aes 950.41 µs 955.70 µs 5.29 µs (0.56%) 1.56%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.90 ms 12.97 ms 0.07 ms (0.54%) 2.55%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.04 ms 13.11 ms 0.07 ms (0.53%) 2.55%
transfer_no_resume_ring_1.3_rsa_chacha 13.39 ms 13.46 ms 0.07 ms (0.53%) 2.54%
handshake_no_resume_ring_1.2_rsa_aes 947.66 µs 952.55 µs 4.89 µs (0.52%) 1.37%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.72 ms 13.79 ms 0.07 ms (0.48%) 2.63%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.50 ms 5.52 ms 0.03 ms (0.47%) 1.36%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.03 ms 16.10 ms 0.07 ms (0.43%) 2.22%
handshake_session_id_ring_1.3_ecdsap256_aes 5.53 ms 5.55 ms 0.02 ms (0.41%) 1.56%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.69 ms 13.75 ms 0.06 ms (0.41%) 2.41%
handshake_session_id_ring_1.3_rsa_chacha 5.99 ms 6.02 ms 0.02 ms (0.41%) 1.75%
handshake_no_resume_ring_1.3_rsa_chacha 950.61 µs 954.30 µs 3.70 µs (0.39%) 1.77%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.78 ms 1.77 ms -0.01 ms (-0.38%) 3.09%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.73 ms 8.76 ms 0.03 ms (0.37%) 4.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.71 ms 8.74 ms 0.03 ms (0.36%) 3.83%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.63 ms 8.66 ms 0.03 ms (0.35%) 1.01%
handshake_tickets_ring_1.3_rsa_aes 6.09 ms 6.11 ms 0.02 ms (0.33%) 1.61%
handshake_session_id_ring_1.3_rsa_aes 6.03 ms 6.05 ms 0.02 ms (0.33%) 1.45%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.42 ms 9.44 ms 0.03 ms (0.30%) 4.23%
handshake_session_id_ring_1.3_ecdsap384_aes 8.67 ms 8.69 ms 0.02 ms (0.28%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.56 ms 5.58 ms 0.02 ms (0.28%) 1.91%
handshake_tickets_ring_1.3_rsa_chacha 6.06 ms 6.07 ms 0.02 ms (0.28%) 1.36%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.38 ms 9.41 ms 0.03 ms (0.27%) 3.59%
handshake_tickets_ring_1.3_ecdsap256_aes 5.60 ms 5.61 ms 0.02 ms (0.27%) 1.94%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.23 ms 9.25 ms 0.02 ms (0.25%) 4.21%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.55 ms 8.57 ms 0.02 ms (0.23%) 4.54%
handshake_tickets_ring_1.2_rsa_aes 1.59 ms 1.59 ms 0.00 ms (0.23%) 1.22%
handshake_tickets_ring_1.3_ecdsap384_aes 8.73 ms 8.75 ms 0.02 ms (0.19%) 1.29%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 9.20 ms 9.21 ms 0.02 ms (0.18%) 3.70%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.52 ms 8.54 ms 0.01 ms (0.16%) 3.86%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.70 ms 8.72 ms 0.01 ms (0.16%) 1.02%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.51 ms -0.00 ms (-0.13%) 1.09%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.10%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.27 ms 1.27 ms 0.00 ms (0.09%) 2.03%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.23 ms 9.23 ms 0.00 ms (0.05%) 4.21%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.38 ms 9.39 ms 0.00 ms (0.05%) 3.71%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.05%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.20 ms 9.20 ms -0.00 ms (-0.04%) 3.53%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.26 ms 1.26 ms -0.00 ms (-0.02%) 1.76%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.40 ms 9.40 ms -0.00 ms (-0.00%) 4.29%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.39%. Comparing base (3cdc0b0) to head (efde3ce).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2482      +/-   ##
==========================================
- Coverage   95.40%   95.39%   -0.01%     
==========================================
  Files          97       97              
  Lines       21841    21859      +18     
==========================================
+ Hits        20838    20853      +15     
- Misses       1003     1006       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz ctz added this pull request to the merge queue Jun 10, 2025
Merged via the queue into main with commit 568b2c6 Jun 10, 2025
34 checks passed
@ctz ctz deleted the jbp-ext-precursors branch June 10, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctz @djc