Skip to content

Support secp256r1mlkem768 #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2025
Merged

Support secp256r1mlkem768 #2471

merged 4 commits into from
May 27, 2025
+70 −2

Conversation

ctz
Copy link
Member

@ctz ctz commented May 26, 2025

This adds rustls::crypto::aws_lc_rs::kx_group::SECP256R1MLKEM768. It is added to ALL_KX_GROUPS, but not DEFAULT_KX_GROUPS; this means that -- for now -- it requires explicit action to use (like plain MLKEM768).

Generally I don't expect this to be widely deployed, and (eg) isn't supported right now by pq.cloudflareresearch.com. But I found that openquantumsafe.org does support it, so add a quick interop test with that server.

This also acts as a regression test for #2470

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented May 26, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003766 2010518 ⚠️ 6752 (0.34%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4748665 4763616 ⚠️ 14951 (0.31%) 0.21%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9977411 9941330 -36081 (-0.36%) 0.87%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9971331 9946934 -24397 (-0.24%) 0.63%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2910641 2904812 -5829 (-0.20%) 0.79%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11563123 11584904 21781 (0.19%) 1.31%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305303 3301139 -4164 (-0.13%) 0.27%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78436692 78477545 40853 (0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78651237 78688987 37750 (0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78701532 78734553 33021 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55203667 55225363 21696 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78702132 78729848 27716 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56547408 56566096 18688 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78536501 78510669 -25832 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11556828 11560555 3727 (0.03%) 1.52%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3580246 3579176 -1070 (-0.03%) 1.22%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56562328 56578940 16612 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2907941 2907117 -824 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56590469 56605684 15215 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78485171 78504794 19623 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55302005 55289201 -12804 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78495933 78478152 -17781 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4746943 4747880 937 (0.02%) 0.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78422440 78436877 14437 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55288401 55298287 9886 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78678235 78665263 -12972 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55290585 55281608 -8977 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55208464 55215554 7090 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001049 2001282 233 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56559054 56552577 -6477 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10460666 10461366 700 (0.01%) 1.13%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3586308 3586540 232 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78427085 78428553 1468 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78724253 78723159 -1094 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56609714 56609009 -705 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55207730 55208413 683 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295247 1295242 -5 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719927 1719923 -4 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56588994 56588898 -96 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7222922 7222912 -10 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34738035 34738002 -33 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736309 34736331 22 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304405 3304407 2 (0.00%) 0.23%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58226794 58226779 -15 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284263 46284273 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46459284 46459275 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58124573 58124583 10 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58035384 58035393 9 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7220960 7220961 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452696 46452702 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80632574 80632584 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80538690 80538681 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92662821 92662830 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637657 80637664 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58229018 58229013 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58251601 58251606 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294219 46294222 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397764 46397767 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92691433 92691428 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80643603 80643599 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80543179 80543182 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58117360 58117362 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92653699 92653696 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92693663 92693666 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92717525 92717522 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189286 46189285 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46289081 46289082 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46448257 46448256 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157299 58157298 -1 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31991282 31991282 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339895 2339895 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4298386 4298386 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012380 5012380 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296416 1296416 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10999871 10999871 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553370 32553370 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30841908 30841908 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31160526 31160526 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451502 32451502 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533871 80533871 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3876271 3876271 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451460 32451460 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31153199 31153199 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31991415 31991415 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30837854 30837854 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31988230 31988230 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933198 30933198 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31156538 31156538 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32113065 32113065 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11127905 11127905 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78679336 78679336 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334246 2334246 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31227809 31227809 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553457 32553457 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224449 31224449 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867861 3867861 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31231797 31231797 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550648 32550648 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4306090 4306090 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58148972 58148972 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4218366 4218366 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246478 2246478 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112932 32112932 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32448693 32448693 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4757724 4757724 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109880 32109880 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926215 30926215 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133666 11133666 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30834925 30834925 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4569708 4569708 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92685298 92685298 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929144 30929144 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.81 ms 1.82 ms 0.01 ms (0.80%) 3.40%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.72 ms 4.76 ms 0.04 ms (0.75%) 5.06%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.41 ms 5.45 ms 0.04 ms (0.72%) 4.03%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.12 ms 5.16 ms 0.03 ms (0.64%) 4.82%
transfer_no_resume_ring_1.3_rsa_aes 5.90 ms 5.94 ms 0.04 ms (0.63%) 4.15%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.39 ms 5.43 ms 0.03 ms (0.63%) 4.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.64 ms 1.65 ms 0.01 ms (0.55%) 3.33%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.42 ms 5.45 ms 0.03 ms (0.53%) 4.11%
transfer_no_resume_ring_1.2_rsa_aes 5.87 ms 5.90 ms 0.03 ms (0.51%) 4.45%
handshake_tickets_ring_1.2_rsa_aes 1.59 ms 1.60 ms 0.01 ms (0.50%) 1.60%
handshake_tickets_ring_1.3_rsa_aes 6.09 ms 6.06 ms -0.03 ms (-0.43%) 1.17%
handshake_session_id_ring_1.3_rsa_aes 6.04 ms 6.01 ms -0.02 ms (-0.41%) 1.39%
handshake_tickets_ring_1.3_rsa_chacha 6.05 ms 6.03 ms -0.02 ms (-0.41%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_aes 465.69 µs 467.49 µs 1.80 µs (0.39%) 4.03%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.52 ms 8.55 ms 0.03 ms (0.37%) 2.38%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.56 ms 5.54 ms -0.02 ms (-0.36%) 1.27%
handshake_tickets_ring_1.3_ecdsap256_aes 5.60 ms 5.58 ms -0.02 ms (-0.35%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.08 ms 1.09 ms 0.00 ms (0.35%) 1.89%
handshake_no_resume_ring_1.3_ecdsap256_chacha 463.65 µs 465.21 µs 1.55 µs (0.33%) 3.73%
handshake_session_id_ring_1.3_ecdsap256_aes 5.53 ms 5.51 ms -0.02 ms (-0.33%) 1.45%
handshake_session_id_ring_1.3_rsa_chacha 6.00 ms 5.98 ms -0.02 ms (-0.33%) 1.09%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.50 ms 5.49 ms -0.02 ms (-0.32%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.51 ms 0.00 ms (0.32%) 2.17%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.60 ms 10.57 ms -0.03 ms (-0.31%) 1.24%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.19 ms 13.23 ms 0.04 ms (0.31%) 1.73%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.64 ms 10.61 ms -0.03 ms (-0.30%) 1.38%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 655.05 µs 656.88 µs 1.82 µs (0.28%) 4.17%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.33 ms 11.30 ms -0.03 ms (-0.28%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.29 ms 11.26 ms -0.03 ms (-0.28%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.98 ms 13.02 ms 0.03 ms (0.27%) 1.75%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.87 ms 13.91 ms 0.04 ms (0.27%) 1.76%
handshake_session_id_ring_1.3_ecdsap384_aes 8.63 ms 8.61 ms -0.02 ms (-0.25%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.27 ms 11.24 ms -0.03 ms (-0.25%) 1.38%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.61 ms 8.58 ms -0.02 ms (-0.25%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.83 ms 10.80 ms -0.03 ms (-0.25%) 1.13%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.79 ms 10.77 ms -0.03 ms (-0.25%) 1.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.32 ms 11.29 ms -0.03 ms (-0.24%) 1.19%
handshake_tickets_ring_1.3_ecdsap384_aes 8.70 ms 8.68 ms -0.02 ms (-0.24%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.48 ms 11.45 ms -0.03 ms (-0.23%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.66 ms 8.64 ms -0.02 ms (-0.23%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.08 ms 16.12 ms 0.03 ms (0.20%) 1.23%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.51 ms 11.49 ms -0.02 ms (-0.20%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.48 ms 13.50 ms 0.03 ms (0.20%) 1.78%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.32 ms 1.32 ms 0.00 ms (0.20%) 2.39%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.46 ms 11.44 ms -0.02 ms (-0.19%) 1.13%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.51 ms 11.49 ms -0.02 ms (-0.17%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.34 ms 1.34 ms 0.00 ms (0.17%) 1.52%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.88 ms 13.90 ms 0.02 ms (0.17%) 1.64%
handshake_no_resume_ring_1.3_rsa_chacha 957.47 µs 955.97 µs -1.50 µs (-0.16%) 1.67%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 654.74 µs 655.41 µs 0.67 µs (0.10%) 4.01%
handshake_no_resume_ring_1.3_rsa_aes 957.47 µs 956.84 µs -0.63 µs (-0.07%) 1.48%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.57 ms 3.57 ms 0.00 ms (0.04%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.33 ms 1.33 ms 0.00 ms (0.04%) 1.84%
handshake_no_resume_ring_1.2_rsa_aes 953.85 µs 954.20 µs 0.35 µs (0.04%) 1.27%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.56 ms 3.56 ms 0.00 ms (0.01%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.33 ms 1.33 ms 0.00 ms (0.00%) 1.52%

Additional information

Historical results

Checkout details:

@djc
Copy link
Member

djc commented May 26, 2025

Nice!

@codecov Codecov
Copy link

codecov bot commented May 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (9b8f254) to head (a297381).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2471      +/-   ##
==========================================
+ Coverage   95.27%   95.30%   +0.03%     
==========================================
  Files          97       97              
  Lines       21359    21359              
==========================================
+ Hits        20349    20356       +7     
+ Misses       1010     1003       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz
Exercise each of ALL_KX_GROUPS against itself
a297381 
"Exercise" is used pointedly here to avoid suggestion that this is
a meaningful test.
@ctz
Copy link
Member Author

ctz commented May 26, 2025

(added commit to exercise/cover this)

cpu
cpu approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A manual kick of the daily-tests run seems happy too.

@ctz ctz added this pull request to the merge queue May 27, 2025
Merged via the queue into main with commit 75f94f0 May 27, 2025
45 checks passed
@ctz ctz deleted the jbp-secp256-hybrid branch May 27, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu