Skip to content

Eliminate redundant HandshakeMessagePayload::typ field #2478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025
Merged

Conversation

ctz
Copy link
Member

@ctz ctz commented Jun 2, 2025

This is quite a big but somewhat uninteresting change.

ctz added 2 commits June 2, 2025 16:23
We encode the handshake type in the `HandshakePayload` variant,
so repeating it is duplicative.

`HandshakeMessagePayload` itself is retained as a privacy barrier
for `HandshakePayload`.
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.40%. Comparing base (2e7f326) to head (0047899).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2478      +/-   ##
==========================================
- Coverage   95.43%   95.40%   -0.03%     
==========================================
  Files          97       97              
  Lines       21959    21834     -125     
==========================================
- Hits        20956    20831     -125     
  Misses       1003     1003              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

rustls-benchmarking bot commented Jun 2, 2025

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2914186 2907678 -6508 (-0.22%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11558296 11574327 16031 (0.14%) 1.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4750588 4747092 -3496 (-0.07%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11571587 11563874 -7713 (-0.07%) 1.32%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78714066 78761994 47928 (0.06%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3303578 3305472 1894 (0.06%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9983298 9978283 -5015 (-0.05%) 0.60%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78474345 78441111 -33234 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78678411 78710876 32465 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56599211 56622433 23222 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78472680 78504531 31851 (0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9965863 9961847 -4016 (-0.04%) 0.87%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78727728 78697262 -30466 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78757534 78728229 -29305 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3587518 3586194 -1324 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003906 2003167 -739 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55220151 55199998 -20153 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56597508 56581297 -16211 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56553551 56569017 15466 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56619138 56603735 -15403 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10453120 10450288 -2832 (-0.03%) 1.16%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55275178 55289162 13984 (0.03%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4299226 4298146 -1080 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3580102 3580968 866 (0.02%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4758564 4757454 -1110 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78530772 78512549 -18223 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001074 2001536 462 (0.02%) 1.19%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78468234 78450468 -17766 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4220016 4219146 -870 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78666264 78681634 15370 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55227329 55216579 -10750 (-0.02%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4572138 4571268 -870 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3877921 3877231 -690 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55295407 55285740 -9667 (-0.02%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4308520 4307830 -690 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5009710 5008960 -750 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78474825 78463324 -11501 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55279218 55271392 -7826 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56545922 56552902 6980 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4747493 4747944 451 (0.01%) 0.94%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867921 3867561 -360 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55206887 55202276 -4611 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78700095 78706410 6315 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78433526 78428123 -5403 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2904493 2904363 -130 (-0.00%) 0.84%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304327 3304454 127 (0.00%) 0.25%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56556005 56558177 2172 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30837059 30835915 -1144 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30928349 30927205 -1144 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30839984 30838844 -1140 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30844038 30842898 -1140 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30931274 30930134 -1140 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30935328 30934188 -1140 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31155335 31154191 -1144 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31226585 31225441 -1144 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31158668 31157528 -1140 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31162656 31161516 -1140 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31229939 31228799 -1140 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31233927 31232787 -1140 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719947 1719908 -39 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157974 58156691 -1283 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58037346 58036067 -1279 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246529 2246486 -43 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334276 2334234 -42 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339925 2339883 -42 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295291 1295277 -14 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296465 1296459 -6 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31989675 31989585 -90 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32111325 32111235 -90 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32449953 32449863 -90 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32452720 32452630 -90 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32452762 32452672 -90 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32554630 32554540 -90 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7221012 7220993 -19 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7222973 7222955 -18 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736367 34736281 -86 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31986490 31986430 -60 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31989542 31989482 -60 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32108140 32108080 -60 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32111192 32111132 -60 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34738065 34738009 -56 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11127954 11127938 -16 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133715 11133699 -16 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32551863 32551818 -45 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32554672 32554627 -45 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189285 46189295 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58232583 58232573 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80632575 80632584 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46448255 46448260 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46459283 46459278 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58235448 58235454 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80538690 80538682 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92699451 92699460 9 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10999803 10999802 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294220 46294224 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58123157 58123152 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92659489 92659482 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92668621 92668614 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58130366 58130370 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58257402 58257406 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80543188 80543183 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92691086 92691091 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92723318 92723313 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46289083 46289081 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637658 80637655 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92697219 92697222 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533864 80533862 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80643597 80643595 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58154765 58154766 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452700 46452700 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397766 46397766 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284262 46284262 0 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_ring_1.3_ecdsap256_chacha 5.47 ms 5.53 ms ⚠️ 0.06 ms (1.16%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.57 ms 5.63 ms ⚠️ 0.06 ms (1.09%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.03 ms 6.09 ms ⚠️ 0.06 ms (1.03%) 1.00%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.61 ms 10.48 ms -0.13 ms (-1.18%) 1.54%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.53 ms 5.60 ms 0.07 ms (1.18%) 1.37%
handshake_session_id_ring_1.3_ecdsap256_aes 5.50 ms 5.56 ms 0.06 ms (1.15%) 1.29%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.56 ms 10.44 ms -0.12 ms (-1.10%) 1.28%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.78 ms 10.66 ms -0.12 ms (-1.09%) 1.38%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.75 ms 10.63 ms -0.12 ms (-1.09%) 1.63%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.29 ms 11.17 ms -0.11 ms (-1.00%) 1.34%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.48 ms 11.36 ms -0.11 ms (-1.00%) 1.28%
handshake_session_id_ring_1.3_rsa_aes 6.00 ms 6.06 ms 0.06 ms (0.99%) 1.06%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.23 ms 11.12 ms -0.11 ms (-0.99%) 1.32%
handshake_session_id_ring_1.3_rsa_chacha 5.96 ms 6.02 ms 0.06 ms (0.99%) 1.15%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.27 ms 11.16 ms -0.11 ms (-0.98%) 1.33%
handshake_tickets_ring_1.3_rsa_aes 6.07 ms 6.12 ms 0.06 ms (0.95%) 1.04%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.43 ms 11.33 ms -0.11 ms (-0.94%) 1.21%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.42 ms 11.32 ms -0.11 ms (-0.94%) 1.12%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.22 ms 11.12 ms -0.10 ms (-0.91%) 1.27%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.40 ms 11.30 ms -0.10 ms (-0.84%) 1.28%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.56 ms 8.63 ms 0.07 ms (0.80%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.66 ms 8.73 ms 0.07 ms (0.79%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.63 ms 8.70 ms 0.07 ms (0.78%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.59 ms 8.66 ms 0.06 ms (0.75%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 649.27 µs 645.36 µs -3.90 µs (-0.60%) 3.79%
handshake_no_resume_ring_1.3_ecdsap256_chacha 459.11 µs 461.82 µs 2.72 µs (0.59%) 3.41%
handshake_no_resume_ring_1.3_ecdsap256_aes 462.14 µs 464.08 µs 1.93 µs (0.42%) 4.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 647.58 µs 645.48 µs -2.10 µs (-0.32%) 4.01%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.62 ms 1.62 ms -0.01 ms (-0.32%) 2.73%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.29 ms 1.29 ms -0.00 ms (-0.28%) 1.90%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.34 ms 1.34 ms 0.00 ms (0.21%) 1.72%
transfer_no_resume_ring_1.2_rsa_aes 5.78 ms 5.79 ms 0.01 ms (0.21%) 5.34%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.30 ms 1.30 ms -0.00 ms (-0.20%) 1.48%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.33 ms 1.33 ms 0.00 ms (0.19%) 1.69%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.34 ms 5.33 ms -0.01 ms (-0.19%) 5.98%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.29 ms 5.28 ms -0.01 ms (-0.18%) 6.16%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.64 ms 4.64 ms -0.01 ms (-0.16%) 6.94%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.56 ms 3.56 ms 0.01 ms (0.15%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.34 ms 5.34 ms 0.01 ms (0.12%) 5.98%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.79 ms 1.79 ms 0.00 ms (0.12%) 3.21%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.02 ms 5.02 ms 0.00 ms (0.09%) 6.27%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms -0.00 ms (-0.08%) 1.81%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.89 ms 12.90 ms 0.01 ms (0.07%) 2.24%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.56 ms 3.56 ms 0.00 ms (0.07%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 5.83 ms 5.83 ms -0.00 ms (-0.05%) 5.66%
transfer_no_resume_ring_1.3_rsa_chacha 13.39 ms 13.40 ms 0.01 ms (0.04%) 2.42%
handshake_no_resume_ring_1.2_rsa_aes 949.80 µs 950.21 µs 0.41 µs (0.04%) 1.26%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.75 ms 13.75 ms -0.00 ms (-0.03%) 2.12%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.51 ms 0.00 ms (0.03%) 1.09%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.44 ms 8.44 ms 0.00 ms (0.03%) 3.18%
handshake_no_resume_ring_1.3_rsa_aes 953.36 µs 953.61 µs 0.26 µs (0.03%) 1.60%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms -0.00 ms (-0.01%) 1.60%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.79 ms 13.79 ms 0.00 ms (0.01%) 2.34%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.10 ms 13.10 ms -0.00 ms (-0.01%) 2.51%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.00 ms 16.00 ms -0.00 ms (-0.01%) 1.78%
handshake_no_resume_ring_1.3_rsa_chacha 952.57 µs 952.62 µs 0.05 µs (0.00%) 1.67%

Additional information

Historical results

Checkout details:

@ctz ctz enabled auto-merge June 3, 2025 08:26
@ctz ctz added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit f1a2702 Jun 3, 2025
64 checks passed
@ctz ctz deleted the jbp-remove-hs-typ branch June 3, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants