feat: expose the number of received TLS1.3 resumption tickets #2476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2476 +/- ##
=======================================
Coverage 95.33% 95.33%
=======================================
Files 97 97
Lines 21504 21518 +14
=======================================
+ Hits 20500 20514 +14
Misses 1004 1004 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djc
approved these changes
May 30, 2025
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
|
(Please squash your commits.) |
412a054 to
0d8fd4d
Compare
0d8fd4d to
2dfeb64
Compare
This adds a public function to get the count of TLS1.3 resumption tickets that were received in a client-side rustls session. Before, this information was not available outside of the session store. Downstream users may want to access this, though, to keep a connection open until tickets are received. When doing a 0RTT connection, it may happen that the application-side logic is done before the tickets are received. In that case, if expecting to do further 0rtt connections in the future, it may be beneficial to keep the connection open until the tickets are received. With this patch, this is possible without having to wrap or hack around the session store.
2dfeb64 to
5475803
Compare
cpu
approved these changes
May 30, 2025
ctz
approved these changes
Jun 2, 2025
There was a problem hiding this comment.
Thanks!
Just a note on the use case -- there's no guarantee that a server will send tickets, nor when it will do so. So be cautious keeping a connection up indefinitely waiting for this to happen. But using this API to keep the connection open an extra few RTTs seems like a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a public function to get the count of TLS1.3 resumption tickets that were received in a client-side rustls session.
Currently, this information is not available outside of the session store. Downstream users may want to access this, though, to keep a connection open until tickets are received. When doing a 0RTT connection, it may happen that the application-side logic is done before the tickets are received. In that case, if expecting to do further 0rtt connections in the future, it may be beneficial to keep the connection open until the tickets are received. With this patch, this is possible without having to wrap or hack around the session store.