Skip to content

Prefer x.clone() to Arc::clone(&x) #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

Prefer x.clone() to Arc::clone(&x) #2475

merged 1 commit into from
May 29, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented May 29, 2025

No description provided.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented May 29, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11556240 11603726 47486 (0.41%) 1.32%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3593581 3580242 -13339 (-0.37%) 1.23%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305634 3301354 -4280 (-0.13%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9942205 9931168 -11037 (-0.11%) 0.94%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9961607 9971679 10072 (0.10%) 0.60%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3302190 3304348 2158 (0.07%) 0.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78501834 78553011 51177 (0.07%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78713678 78762056 48378 (0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78467911 78422422 -45489 (-0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55293530 55319025 25495 (0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56596062 56621620 25558 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55219402 55196485 -22917 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78509125 78477842 -31283 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4748025 4749870 1845 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78765235 78738813 -26422 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78704800 78678601 -26199 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55300255 55284558 -15697 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2904004 2904763 759 (0.03%) 0.83%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3587660 3586796 -864 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56630291 56616876 -13415 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56564035 56550986 -13049 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11569093 11566452 -2641 (-0.02%) 1.29%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10468958 10471220 2262 (0.02%) 1.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2907286 2907889 603 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78708717 78693543 -15174 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003773 2003465 -308 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78688476 78699863 11387 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56574177 56566614 -7563 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78754707 78746721 -7986 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56565818 56571552 5734 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4748234 4747889 -345 (-0.01%) 0.32%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78433414 78439018 5604 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56626548 56622641 -3907 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001579 2001464 -115 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719927 1720017 90 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55214005 55216605 2600 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78414619 78417150 2531 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55290995 55292612 1617 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55201336 55202473 1137 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58229015 58229654 639 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7222912 7222930 18 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295247 1295244 -3 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34738002 34738052 50 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78514076 78514115 39 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736301 34736316 15 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7220960 7220963 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46289091 46289081 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58226783 58226794 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637666 80637657 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58035394 58035400 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452703 46452699 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189296 46189293 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92662823 92662817 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533867 80533862 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80632575 80632579 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80643598 80643602 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284266 46284268 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294221 46294219 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92685293 92685289 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157302 58157304 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92691430 92691433 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80543188 80543186 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92717524 92717522 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397763 46397764 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46459276 46459275 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58117360 58117361 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58124575 58124574 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58148973 58148972 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58251607 58251608 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92653696 92653697 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92693662 92693661 -1 (-0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4298386 4298386 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31227809 31227809 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10999871 10999871 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31160526 31160526 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867861 3867861 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3876271 3876271 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4757724 4757724 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553370 32553370 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31991282 31991282 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451460 32451460 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32113065 32113065 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339895 2339895 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224449 31224449 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933198 30933198 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32448693 32448693 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109880 32109880 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4218366 4218366 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246478 2246478 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46448256 46448256 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553457 32553457 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012380 5012380 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334246 2334246 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929144 30929144 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31991415 31991415 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11127905 11127905 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30837854 30837854 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30834925 30834925 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30841908 30841908 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296426 1296426 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31153199 31153199 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31156538 31156538 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550648 32550648 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926215 30926215 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4306090 4306090 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80538690 80538690 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31988230 31988230 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451502 32451502 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31231797 31231797 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133666 11133666 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4569708 4569708 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112932 32112932 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 651.43 µs 655.72 µs 4.29 µs (0.66%) 3.07%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.38 ms 5.41 ms 0.03 ms (0.62%) 4.99%
transfer_no_resume_ring_1.3_rsa_aes 5.87 ms 5.90 ms 0.03 ms (0.57%) 4.93%
transfer_no_resume_ring_1.2_rsa_aes 5.82 ms 5.85 ms 0.03 ms (0.50%) 5.30%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.38 ms 5.40 ms 0.03 ms (0.49%) 5.27%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.48 ms 8.52 ms 0.04 ms (0.48%) 3.09%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.64 ms 1.65 ms 0.01 ms (0.47%) 2.79%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.69 ms 4.71 ms 0.02 ms (0.46%) 6.14%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.36 ms 5.38 ms 0.02 ms (0.45%) 4.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 651.56 µs 654.38 µs 2.82 µs (0.43%) 3.98%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.09 ms 5.11 ms 0.02 ms (0.39%) 4.83%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.08 ms 1.09 ms 0.00 ms (0.39%) 1.77%
handshake_no_resume_ring_1.3_ecdsap256_chacha 461.80 µs 463.58 µs 1.77 µs (0.38%) 3.73%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.33 ms 1.33 ms 0.00 ms (0.35%) 1.56%
handshake_no_resume_ring_1.3_ecdsap256_aes 463.59 µs 465.07 µs 1.48 µs (0.32%) 3.99%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.81 ms 1.82 ms 0.01 ms (0.32%) 2.90%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 12.97 ms 0.03 ms (0.26%) 1.97%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.56 ms 3.57 ms 0.01 ms (0.25%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.82 ms 13.85 ms 0.03 ms (0.23%) 1.69%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.83 ms 13.86 ms 0.03 ms (0.23%) 1.96%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.59 ms 10.61 ms 0.02 ms (0.22%) 1.23%
handshake_no_resume_ring_1.2_rsa_aes 950.46 µs 952.49 µs 2.02 µs (0.21%) 1.45%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.56 ms 3.57 ms 0.01 ms (0.21%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.51 ms 0.00 ms (0.21%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.34 ms 1.34 ms 0.00 ms (0.21%) 1.56%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.15 ms 13.18 ms 0.03 ms (0.21%) 1.92%
transfer_no_resume_ring_1.3_rsa_chacha 13.43 ms 13.46 ms 0.03 ms (0.19%) 2.17%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.05 ms 16.08 ms 0.03 ms (0.19%) 1.48%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.32 ms 1.32 ms 0.00 ms (0.18%) 1.95%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.55 ms 10.57 ms 0.02 ms (0.18%) 1.24%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.28 ms 11.30 ms 0.02 ms (0.18%) 1.13%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.27 ms 11.29 ms 0.02 ms (0.17%) 1.19%
handshake_session_id_ring_1.3_rsa_aes 6.02 ms 6.01 ms -0.01 ms (-0.16%) 1.13%
handshake_tickets_ring_1.3_rsa_chacha 6.04 ms 6.03 ms -0.01 ms (-0.16%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.07 ms 6.06 ms -0.01 ms (-0.15%) 1.06%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.22 ms 11.24 ms 0.02 ms (0.15%) 1.15%
handshake_session_id_ring_1.3_rsa_chacha 5.98 ms 5.98 ms -0.01 ms (-0.14%) 1.09%
handshake_no_resume_ring_1.3_rsa_chacha 953.73 µs 955.09 µs 1.36 µs (0.14%) 1.66%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.24 ms 11.26 ms 0.02 ms (0.14%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.46 ms 11.48 ms 0.02 ms (0.14%) 1.14%
handshake_no_resume_ring_1.3_rsa_aes 954.48 µs 955.77 µs 1.29 µs (0.14%) 1.59%
handshake_tickets_ring_1.3_ecdsap256_aes 5.58 ms 5.57 ms -0.01 ms (-0.13%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.78 ms 10.79 ms 0.01 ms (0.13%) 1.38%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.55 ms 5.54 ms -0.01 ms (-0.12%) 1.27%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.47 ms 11.48 ms 0.01 ms (0.09%) 1.13%
handshake_tickets_ring_1.2_rsa_aes 1.59 ms 1.59 ms 0.00 ms (0.08%) 1.70%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.43 ms 11.44 ms 0.01 ms (0.07%) 1.08%
handshake_session_id_ring_1.3_ecdsap256_aes 5.52 ms 5.51 ms -0.00 ms (-0.06%) 1.29%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.49 ms 5.49 ms -0.00 ms (-0.06%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.75 ms 10.75 ms 0.01 ms (0.06%) 1.47%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.32 ms 1.33 ms 0.00 ms (0.05%) 1.13%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.42 ms 11.43 ms 0.01 ms (0.05%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.62 ms 8.61 ms -0.00 ms (-0.04%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.59 ms 8.59 ms 0.00 ms (0.03%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.64 ms 8.64 ms -0.00 ms (-0.02%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.67 ms 8.67 ms 0.00 ms (0.01%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented May 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.33%. Comparing base (5f7c467) to head (ee4d022).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2475      +/-   ##
==========================================
- Coverage   95.33%   95.33%   -0.01%     
==========================================
  Files          97       97              
  Lines       21506    21504       -2     
==========================================
- Hits        20502    20500       -2     
  Misses       1004     1004

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cpu
cpu approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good riddance 🧹

@djc djc added this pull request to the merge queue May 29, 2025
Merged via the queue into main with commit ca468df May 29, 2025
34 checks passed
@djc djc deleted the jbp-arc-clone branch May 29, 2025 17:54
@AMDmi3
Copy link

AMDmi3 commented Jun 16, 2025

Out of curiosity, what's the profit of it? I though Arc::clone was preferred for explicitness.

@cpu
Copy link
Member

cpu commented Jun 17, 2025

@AMDmi3 See #2474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ctz @AMDmi3 @cpu @djc