Skip to content

Nightly clippy fixes #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 20, 2025
Merged

Nightly clippy fixes #2461

merged 8 commits into from
May 20, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented May 19, 2025 •
edited
Loading

@ctz ctz marked this pull request as draft May 19, 2025 14:23
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented May 19, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2923538 2910995 ✅ -12543 (-0.43%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003907 2009820 ⚠️ 5913 (0.30%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4751331 4762624 ⚠️ 11293 (0.24%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11549577 11512296 -37281 (-0.32%) 1.17%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9956216 9980662 24446 (0.25%) 0.71%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11587147 11563035 -24112 (-0.21%) 1.30%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10441726 10454381 12655 (0.12%) 0.93%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4748601 4745763 -2838 (-0.06%) 0.24%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78718484 78673762 -44722 (-0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56576386 56554044 -22342 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78428313 78455334 27021 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55205332 55218696 13364 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9961333 9959050 -2283 (-0.02%) 0.68%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3580362 3581068 706 (0.02%) 1.34%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001483 2001168 -315 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3587307 3586778 -529 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2913199 2913624 425 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78681421 78670664 -10757 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78734078 78723448 -10630 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78711291 78721303 10012 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78446068 78455893 9825 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56605000 56598345 -6655 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55206158 55212054 5896 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78514586 78506521 -8065 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56549505 56544163 -5342 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56601768 56606774 5006 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55296864 55292855 -4009 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78496077 78501302 5225 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78426380 78431559 5179 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55279374 55281972 2598 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304465 3304313 -152 (-0.00%) 0.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55207382 55209778 2396 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719752 1719790 38 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305665 3305730 65 (0.00%) 0.26%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296656 1296666 10 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78663332 78663740 408 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78483189 78482839 -350 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56550247 56550493 246 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55284385 55284186 -199 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56593586 56593449 -137 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246307 2246303 -4 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78697214 78697074 -140 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334066 2334062 -4 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339715 2339711 -4 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34742294 34742279 -15 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227117 7227114 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92685298 92685288 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58226784 58226790 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80645566 80645573 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46291024 46291020 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92691433 92691425 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58117363 58117368 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80545420 80545414 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58035398 58035394 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58148971 58148975 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80634525 80634520 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157301 58157304 3 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189317 46189315 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294535 46294533 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397783 46397781 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46450203 46450205 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58227325 58227327 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533888 80533890 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80540621 80540619 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284290 46284289 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92691972 92691970 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92662823 92662822 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92717525 92717524 -1 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30837796 30837796 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92653696 92653696 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30835051 30835051 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000039 11000039 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926341 30926341 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553048 32553048 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451138 32451138 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46461251 46461251 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295482 1295482 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109433 32109433 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31153265 31153265 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4298144 4298144 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4218640 4218640 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933264 30933264 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4569978 4569978 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31987783 31987783 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452707 46452707 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3876537 3876537 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637667 80637667 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743983 34743983 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31231793 31231793 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31227743 31227743 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58124575 58124575 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012134 5012134 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112394 32112394 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32448134 32448134 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133847 11133847 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31160522 31160522 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4306434 4306434 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32112593 32112593 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31156472 31156472 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229066 7229066 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451180 32451180 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30841974 30841974 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224515 31224515 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128086 11128086 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553135 32553135 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31990943 31990943 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58251608 58251608 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31990744 31990744 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867855 3867855 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929086 30929086 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4757720 4757720 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550089 32550089 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.13 ms 5.17 ms 0.03 ms (0.67%) 4.75%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.42 ms 5.46 ms 0.04 ms (0.66%) 3.35%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.42 ms 5.45 ms 0.03 ms (0.59%) 3.43%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.65 ms 1.64 ms -0.01 ms (-0.59%) 2.73%
transfer_no_resume_ring_1.2_rsa_aes 5.85 ms 5.88 ms 0.03 ms (0.58%) 3.73%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.40 ms 5.43 ms 0.03 ms (0.57%) 4.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.74 ms 4.76 ms 0.03 ms (0.54%) 3.77%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.83 ms 1.82 ms -0.01 ms (-0.46%) 3.01%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.01 ms (-0.40%) 2.52%
handshake_no_resume_ring_1.3_ecdsap256_chacha 477.51 µs 479.40 µs 1.89 µs (0.40%) 2.11%
handshake_no_resume_ring_1.3_ecdsap256_aes 479.67 µs 481.50 µs 1.83 µs (0.38%) 2.53%
transfer_no_resume_ring_1.3_rsa_aes 5.93 ms 5.95 ms 0.02 ms (0.37%) 3.58%
handshake_session_id_ring_1.3_ecdsap256_aes 5.55 ms 5.57 ms 0.02 ms (0.37%) 1.29%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.52 ms 8.55 ms 0.03 ms (0.36%) 1.84%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.10 ms 1.10 ms -0.00 ms (-0.34%) 4.41%
handshake_tickets_ring_1.3_ecdsap256_aes 5.62 ms 5.64 ms 0.02 ms (0.33%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.59 ms 5.61 ms 0.02 ms (0.33%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.12 ms 6.13 ms 0.02 ms (0.32%) 1.06%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.52 ms 5.53 ms 0.01 ms (0.26%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.99 ms 13.02 ms 0.03 ms (0.24%) 1.65%
transfer_no_resume_ring_1.3_rsa_chacha 13.48 ms 13.51 ms 0.03 ms (0.24%) 1.71%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.68 ms 8.70 ms 0.02 ms (0.23%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.64 ms 8.66 ms 0.02 ms (0.22%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.01 ms 6.02 ms 0.01 ms (0.21%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.05 ms 6.06 ms 0.01 ms (0.21%) 1.09%
handshake_tickets_ring_1.3_rsa_chacha 6.07 ms 6.09 ms 0.01 ms (0.21%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.21 ms 13.24 ms 0.03 ms (0.21%) 1.52%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.08 ms 16.12 ms 0.03 ms (0.21%) 1.17%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 668.32 µs 669.64 µs 1.32 µs (0.20%) 2.31%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.34 ms 1.34 ms 0.00 ms (0.19%) 2.91%
handshake_tickets_ring_1.3_ecdsap384_aes 8.72 ms 8.73 ms 0.02 ms (0.19%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 964.51 µs 966.26 µs 1.75 µs (0.18%) 1.14%
handshake_no_resume_ring_1.3_rsa_chacha 969.39 µs 971.05 µs 1.67 µs (0.17%) 1.25%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.89 ms 13.91 ms 0.02 ms (0.16%) 1.16%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.88 ms 13.90 ms 0.02 ms (0.16%) 1.64%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.61 ms 8.62 ms 0.01 ms (0.16%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms -0.00 ms (-0.15%) 1.62%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.34 ms 11.32 ms -0.02 ms (-0.14%) 1.17%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.35 ms 1.35 ms 0.00 ms (0.10%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.35 ms 1.35 ms 0.00 ms (0.09%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 968.44 µs 969.29 µs 0.85 µs (0.09%) 1.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.80 ms 10.81 ms 0.01 ms (0.08%) 1.73%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.33 ms 1.33 ms -0.00 ms (-0.07%) 2.82%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.61 ms 10.62 ms 0.01 ms (0.06%) 1.40%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.32 ms 11.32 ms -0.01 ms (-0.06%) 1.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.50 ms 11.49 ms -0.00 ms (-0.04%) 1.22%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.30 ms 11.30 ms -0.00 ms (-0.03%) 1.04%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.64 ms 10.64 ms -0.00 ms (-0.03%) 1.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.51 ms 11.51 ms -0.00 ms (-0.02%) 1.33%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 669.94 µs 669.85 µs -0.10 µs (-0.01%) 3.03%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.58 ms 3.58 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.29 ms 11.29 ms 0.00 ms (0.01%) 1.37%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.82 ms 10.82 ms 0.00 ms (0.01%) 1.38%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.58 ms 3.58 ms 0.00 ms (0.00%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.48 ms 11.48 ms 0.00 ms (0.00%) 1.43%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.49 ms 11.49 ms -0.00 ms (-0.00%) 1.24%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented May 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.26%. Comparing base (795ae1f) to head (a31c54a).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2461      +/-   ##
==========================================
- Coverage   95.26%   95.26%   -0.01%     
==========================================
  Files          95       95              
  Lines       21252    21251       -1     
==========================================
- Hits        20246    20245       -1     
  Misses       1006     1006

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz ctz marked this pull request as ready for review May 19, 2025 14:46
@djc djc added this pull request to the merge queue May 20, 2025
Merged via the queue into main with commit 8374213 May 20, 2025
34 checks passed
@djc djc deleted the jbp-nightly-clippy branch May 20, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu