Skip to content

Rework clippy setup #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2025
Merged

Rework clippy setup #2460

merged 2 commits into from
May 16, 2025
+2 −12

Conversation

ctz
Copy link
Member

@ctz ctz commented May 15, 2025

Prior to this PR, running admin/clippy (which is a common part of my workflow) produces a wall of 150 warnings. This PR fixes that by moving the clippy configuration into rustls/.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented May 15, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2913478 2919767 ⚠️ 6289 (0.22%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10433959 10476344 42385 (0.41%) 1.09%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11516979 11558543 41564 (0.36%) 1.39%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9968495 9946663 -21832 (-0.22%) 0.72%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9948232 9964159 15927 (0.16%) 0.69%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11599890 11586192 -13698 (-0.12%) 1.25%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78770150 78722290 -47860 (-0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78762630 78720313 -42317 (-0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3585234 3587025 1791 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78411837 78450046 38209 (0.05%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3302668 3304254 1586 (0.05%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4749900 4747832 -2068 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56621522 56597641 -23881 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78438363 78469245 30882 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78532814 78502433 -30381 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78676763 78707000 30237 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56627525 56606504 -21021 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55200110 55219093 18983 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78692330 78667048 -25282 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55201961 55218775 16814 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78738211 78716201 -22010 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55305965 55290857 -15108 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56555554 56570808 15254 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56556145 56542118 -14027 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56614022 56602874 -11148 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003316 2003659 343 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78508339 78498066 -10273 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3580413 3579981 -432 (-0.01%) 1.34%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55296898 55291707 -5191 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4747661 4747339 -322 (-0.01%) 0.27%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305531 3305690 159 (0.00%) 0.29%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78677590 78680644 3054 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001171 2001244 73 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78443180 78445470 2290 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78529537 78527295 -2242 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56557427 56558920 1493 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55212473 55213699 1226 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55296125 55294997 -1128 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2910481 2910428 -53 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296679 1296666 -13 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719756 1719771 15 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295482 1295484 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46291014 46291025 11 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58117362 58117371 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284289 46284282 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80645568 80645577 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637667 80637675 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80545417 80545424 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46450202 46450206 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58148975 58148970 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58227324 58227328 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92685298 92685292 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397780 46397777 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452717 46452714 -3 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34744010 34744008 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58035396 58035393 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58124579 58124576 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157303 58157300 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189319 46189317 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92662826 92662830 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92691425 92691428 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92717522 92717525 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533887 80533889 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80634525 80634523 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294537 46294536 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92653696 92653698 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58226793 58226792 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58251612 58251611 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80540622 80540623 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92691972 92691973 1 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4757720 4757720 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31160522 31160522 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4298144 4298144 0 (0.00%) 0.24%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553048 32553048 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30835051 30835051 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32448134 32448134 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133847 11133847 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4569978 4569978 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30837796 30837796 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339715 2339715 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128086 11128086 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451138 32451138 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012134 5012134 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4218640 4218640 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000039 11000039 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550089 32550089 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933264 30933264 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926341 30926341 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224515 31224515 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4306434 4306434 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31156472 31156472 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31153265 31153265 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32112593 32112593 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553135 32553135 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929086 30929086 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31987783 31987783 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451180 32451180 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46461253 46461253 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30841974 30841974 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31990744 31990744 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3876537 3876537 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31990943 31990943 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112394 32112394 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31227743 31227743 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31231793 31231793 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229076 7229076 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867855 3867855 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334066 2334066 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34742296 34742296 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109433 32109433 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227117 7227117 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246307 2246307 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.78 ms 4.70 ms -0.08 ms (-1.68%) 5.65%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.17 ms 5.09 ms -0.08 ms (-1.51%) 6.25%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.85 ms 1.82 ms -0.03 ms (-1.50%) 4.45%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.47 ms 5.39 ms -0.08 ms (-1.45%) 5.02%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.47 ms 5.40 ms -0.08 ms (-1.44%) 4.79%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.45 ms 5.37 ms -0.08 ms (-1.43%) 5.32%
transfer_no_resume_ring_1.3_rsa_aes 5.96 ms 5.89 ms -0.07 ms (-1.20%) 4.58%
handshake_no_resume_ring_1.3_ecdsap256_chacha 480.92 µs 475.19 µs -5.73 µs (-1.19%) 3.73%
transfer_no_resume_ring_1.2_rsa_aes 5.89 ms 5.82 ms -0.07 ms (-1.14%) 5.30%
handshake_no_resume_ring_1.3_ecdsap256_aes 483.43 µs 478.24 µs -5.19 µs (-1.07%) 3.42%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 671.92 µs 665.60 µs -6.33 µs (-0.94%) 4.18%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 672.90 µs 666.60 µs -6.30 µs (-0.94%) 4.64%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.57 ms 8.50 ms -0.08 ms (-0.88%) 2.85%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.94 ms 13.85 ms -0.08 ms (-0.60%) 1.67%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.03 ms 12.96 ms -0.08 ms (-0.58%) 1.96%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.10 ms 1.09 ms -0.01 ms (-0.58%) 4.60%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.25 ms 13.17 ms -0.08 ms (-0.57%) 1.75%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.93 ms 13.85 ms -0.08 ms (-0.56%) 2.12%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.34 ms 1.34 ms -0.01 ms (-0.53%) 4.62%
transfer_no_resume_ring_1.3_rsa_chacha 13.52 ms 13.45 ms -0.07 ms (-0.53%) 2.07%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.60 ms -0.01 ms (-0.52%) 1.40%
handshake_no_resume_ring_1.3_rsa_aes 971.24 µs 966.46 µs -4.78 µs (-0.49%) 1.48%
handshake_no_resume_ring_1.3_rsa_chacha 972.23 µs 967.58 µs -4.64 µs (-0.48%) 1.38%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.65 ms 10.60 ms -0.05 ms (-0.47%) 1.93%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.13 ms 16.06 ms -0.08 ms (-0.47%) 1.65%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.34 ms 1.33 ms -0.01 ms (-0.47%) 4.87%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.33 ms 11.28 ms -0.05 ms (-0.45%) 1.31%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.32 ms 11.27 ms -0.05 ms (-0.44%) 1.73%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.65 ms 1.64 ms -0.01 ms (-0.42%) 3.33%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.83 ms 10.78 ms -0.04 ms (-0.41%) 1.75%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.51 ms 11.47 ms -0.05 ms (-0.41%) 1.40%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.36 ms 11.31 ms -0.05 ms (-0.40%) 1.19%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.53 ms 11.48 ms -0.05 ms (-0.40%) 1.39%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.84 ms 10.80 ms -0.04 ms (-0.40%) 1.44%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.35 ms 1.34 ms -0.01 ms (-0.40%) 1.39%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.50 ms 11.46 ms -0.04 ms (-0.38%) 1.44%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.66 ms 10.62 ms -0.04 ms (-0.38%) 1.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.35 ms 11.30 ms -0.04 ms (-0.37%) 1.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.36 ms 1.35 ms -0.00 ms (-0.34%) 1.46%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.53 ms 11.49 ms -0.04 ms (-0.31%) 1.54%
handshake_no_resume_ring_1.2_rsa_aes 967.05 µs 964.43 µs -2.62 µs (-0.27%) 1.34%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.00 ms (-0.22%) 2.52%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.58 ms 3.58 ms -0.01 ms (-0.14%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.58 ms 3.58 ms -0.00 ms (-0.10%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.12 ms 6.13 ms 0.01 ms (0.09%) 1.22%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.62 ms 8.62 ms -0.00 ms (-0.06%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.56 ms 5.56 ms 0.00 ms (0.05%) 1.48%
handshake_tickets_ring_1.3_ecdsap384_aes 8.73 ms 8.73 ms 0.00 ms (0.05%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.64 ms 5.64 ms 0.00 ms (0.05%) 1.21%
handshake_session_id_ring_1.3_rsa_chacha 6.02 ms 6.02 ms -0.00 ms (-0.05%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.69 ms 8.69 ms 0.00 ms (0.03%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.60 ms 5.60 ms 0.00 ms (0.02%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.53 ms 5.53 ms -0.00 ms (-0.02%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.08 ms 6.08 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.06 ms 6.06 ms 0.00 ms (0.01%) 1.35%
handshake_session_id_ring_1.3_ecdsap384_aes 8.66 ms 8.66 ms -0.00 ms (-0.00%) 1.04%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.26%. Comparing base (e3d67a7) to head (5dba9dc).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2460   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files          95       95           
  Lines       21252    21252           
=======================================
  Hits        20246    20246           
  Misses       1006     1006

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cpu
cpu approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@ctz ctz force-pushed the jbp-clippy-setup branch from aa77978 to 5dba9dc Compare May 15, 2025 21:32
@ctz
Copy link
Member Author

ctz commented May 15, 2025

(overlooked nightly clippy in ci)

@djc djc added this pull request to the merge queue May 16, 2025
Merged via the queue into main with commit 795ae1f May 16, 2025
34 checks passed
@djc djc deleted the jbp-clippy-setup branch May 16, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu