Skip to content

Support rustls-graviola in rustls-bench #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2025
Merged

Support rustls-graviola in rustls-bench #2469

merged 3 commits into from
May 23, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented May 22, 2025

This is groundwork for #2468.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented May 22, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11611354 11554758 -56596 (-0.49%) 1.14%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11567467 11548228 -19239 (-0.17%) 1.53%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10445620 10436466 -9154 (-0.09%) 1.13%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304388 3302006 -2382 (-0.07%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9921172 9914266 -6906 (-0.07%) 0.87%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78717417 78681729 -35688 (-0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001618 2000787 -831 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9950782 9947021 -3761 (-0.04%) 0.67%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78515531 78544544 29013 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78477798 78503484 25686 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56567230 56549600 -17630 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4748727 4747263 -1464 (-0.03%) 0.21%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55288717 55304476 15759 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3581041 3580172 -869 (-0.02%) 1.22%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55278467 55291321 12854 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78657021 78672779 15758 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78458038 78444813 -13225 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78457297 78445429 -11868 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78411374 78422957 11583 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55212720 55204697 -8023 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56546909 56554921 8012 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78720386 78730679 10293 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78492421 78483626 -8795 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55219915 55213761 -6154 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55200059 55205530 5471 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2908187 2907908 -279 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56606405 56611483 5078 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55288865 55284587 -4278 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3586949 3586677 -272 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78699889 78694678 -5211 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78723879 78728524 4645 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4748455 4748713 258 (0.01%) 0.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003427 2003525 98 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56566988 56564304 -2684 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305439 3305573 134 (0.00%) 0.27%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56599393 56600622 1229 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296431 1296408 -23 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78724931 78723836 -1095 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56606844 56606481 -363 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2904628 2904618 -10 (-0.00%) 0.77%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295236 1295234 -2 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7222922 7222914 -8 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34738042 34738017 -25 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736308 34736291 -17 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7220955 7220952 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189296 46189285 -11 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58226791 58226778 -13 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58148963 58148972 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58251607 58251615 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157307 58157300 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58229016 58229023 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92693658 92693669 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80632575 80632584 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46459283 46459278 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637655 80637663 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46289081 46289085 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46448257 46448261 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284263 46284266 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452699 46452702 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92717526 92717530 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80643600 80643597 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58124573 58124575 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397766 46397765 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58035393 58035394 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533870 80533869 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80538690 80538689 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92653698 92653697 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92685297 92685296 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92691428 92691427 -1 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31231797 31231797 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451262 32451262 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31991175 31991175 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929144 30929144 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4298386 4298386 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31227809 31227809 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224449 31224449 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30841908 30841908 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294219 46294219 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30834925 30834925 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451220 32451220 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30837854 30837854 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80543190 80543190 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92662831 92662831 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11127897 11127897 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246487 2246487 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4306360 4306360 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553217 32553217 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112692 32112692 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133658 11133658 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31160526 31160526 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58117361 58117361 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31153199 31153199 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719936 1719936 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10999871 10999871 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334246 2334246 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933198 30933198 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31156538 31156538 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012380 5012380 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4757724 4757724 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553130 32553130 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867861 3867861 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3876541 3876541 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31991042 31991042 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550408 32550408 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4218636 4218636 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32112825 32112825 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31987990 31987990 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926215 30926215 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339895 2339895 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4569978 4569978 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109640 32109640 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32448453 32448453 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.09 ms 0.00 ms (0.35%) 1.89%
handshake_no_resume_ring_1.2_rsa_aes 954.73 µs 957.21 µs 2.47 µs (0.26%) 1.25%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.66 ms 1.66 ms -0.00 ms (-0.22%) 3.33%
handshake_session_id_ring_1.3_rsa_aes 6.04 ms 6.05 ms 0.01 ms (0.22%) 1.39%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.16 ms 5.17 ms 0.01 ms (0.20%) 4.82%
handshake_session_id_ring_1.3_rsa_chacha 6.00 ms 6.02 ms 0.01 ms (0.20%) 1.09%
handshake_session_id_ring_1.3_ecdsap256_aes 5.54 ms 5.55 ms 0.01 ms (0.19%) 1.44%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.83 ms 1.83 ms -0.00 ms (-0.17%) 3.40%
handshake_no_resume_ring_1.3_ecdsap256_aes 470.51 µs 469.70 µs -0.81 µs (-0.17%) 3.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.34 ms 1.34 ms 0.00 ms (0.16%) 1.47%
handshake_tickets_ring_1.3_rsa_chacha 6.06 ms 6.07 ms 0.01 ms (0.16%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.51 ms 5.52 ms 0.01 ms (0.15%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.33 ms 1.33 ms 0.00 ms (0.15%) 1.52%
handshake_tickets_ring_1.3_rsa_aes 6.09 ms 6.10 ms 0.01 ms (0.14%) 1.17%
handshake_session_id_ring_1.3_ecdsap384_aes 8.63 ms 8.64 ms 0.01 ms (0.14%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms 0.00 ms (0.14%) 1.51%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.32 ms 11.34 ms 0.01 ms (0.13%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.28 ms 11.30 ms 0.01 ms (0.13%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 656.93 µs 657.67 µs 0.75 µs (0.11%) 4.01%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.61 ms 8.62 ms 0.01 ms (0.11%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.47 ms 11.48 ms 0.01 ms (0.11%) 1.24%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.56 ms 3.57 ms 0.00 ms (0.11%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.31 ms 11.32 ms 0.01 ms (0.10%) 1.09%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.77 ms 4.77 ms -0.00 ms (-0.08%) 5.06%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.27 ms 11.28 ms 0.01 ms (0.08%) 1.34%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.58 ms 5.58 ms 0.00 ms (0.08%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 658.56 µs 659.05 µs 0.49 µs (0.07%) 4.17%
transfer_no_resume_ring_1.2_rsa_aes 5.91 ms 5.90 ms -0.00 ms (-0.07%) 4.38%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.60 ms 10.61 ms 0.01 ms (0.07%) 1.21%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.47 ms 11.48 ms 0.01 ms (0.07%) 1.12%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.63 ms 10.64 ms 0.01 ms (0.07%) 1.19%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.82 ms 10.83 ms 0.01 ms (0.07%) 1.34%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.67 ms 8.67 ms 0.01 ms (0.07%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.79 ms 10.80 ms 0.01 ms (0.06%) 1.46%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.91 ms 13.90 ms -0.01 ms (-0.06%) 1.64%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.44 ms 5.43 ms -0.00 ms (-0.05%) 4.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.50 ms 11.50 ms 0.01 ms (0.05%) 1.16%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.57 ms 3.57 ms 0.00 ms (0.04%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.46 ms 5.46 ms 0.00 ms (0.04%) 4.03%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.51 ms -0.00 ms (-0.04%) 2.17%
transfer_no_resume_ring_1.3_rsa_chacha 13.52 ms 13.52 ms -0.00 ms (-0.03%) 1.71%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.46 ms 5.46 ms -0.00 ms (-0.03%) 4.11%
handshake_tickets_ring_1.3_ecdsap384_aes 8.70 ms 8.70 ms 0.00 ms (0.03%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.33 ms 1.33 ms 0.00 ms (0.02%) 1.84%
handshake_no_resume_ring_1.3_rsa_aes 959.31 µs 959.13 µs -0.19 µs (-0.02%) 1.48%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.23 ms 13.24 ms 0.00 ms (0.02%) 1.73%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.92 ms 13.92 ms -0.00 ms (-0.01%) 1.76%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.32 ms 1.32 ms 0.00 ms (0.01%) 2.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.51 ms 11.52 ms 0.00 ms (0.01%) 1.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.12 ms 16.13 ms 0.00 ms (0.01%) 1.23%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.03 ms 13.03 ms 0.00 ms (0.01%) 1.72%
handshake_no_resume_ring_1.3_rsa_chacha 958.62 µs 958.66 µs 0.04 µs (0.00%) 1.38%
handshake_tickets_ring_1.3_ecdsap256_aes 5.61 ms 5.61 ms -0.00 ms (-0.00%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 5.95 ms 5.95 ms 0.00 ms (0.00%) 4.15%
handshake_no_resume_ring_1.3_ecdsap256_chacha 467.23 µs 467.22 µs -0.01 µs (-0.00%) 3.33%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.56 ms 8.56 ms 0.00 ms (0.00%) 2.38%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented May 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.27%. Comparing base (b10bb2d) to head (ac8d433).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2469   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          97       97           
  Lines       21357    21357           
=======================================
  Hits        20348    20348           
  Misses       1009     1009

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz ctz force-pushed the jbp-bench-3rd-party-providers branch from 621588e to 343a0a7 Compare May 22, 2025 12:21
cpu
cpu approved these changes May 22, 2025
View reviewed changes
ctz added 3 commits May 22, 2025 14:49
@ctz
rustls-bench: filter all benches by supported key types
6354656
@ctz
rustls-bench: support graviola
beb40d9 
This introduces a patch, so that rustls-bench -> rustls is the same crate
as rustls-bench -> rustls-graviola -> rustls.
@ctz
README.md: add graviola to providers, and sort
ac8d433
@ctz ctz force-pushed the jbp-bench-3rd-party-providers branch from 343a0a7 to ac8d433 Compare May 22, 2025 13:49
@ctz ctz added this pull request to the merge queue May 23, 2025
Merged via the queue into main with commit 79677ce May 23, 2025
34 checks passed
@ctz ctz deleted the jbp-bench-3rd-party-providers branch May 23, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu