Skip to content

Fix "Format (unstable)" job in CI #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2025
Merged

Fix "Format (unstable)" job in CI #2466

merged 3 commits into from
May 21, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented May 21, 2025

This has been quietly complaining to itself1 for a little bit since 177cb0c as it wanted to undo the style_edition = "2024" changes. Fix that, and then do a pass tidying imports.

Footnotes

  1. recall it is a continue-on-error job to avoid actually relying on the behaviour of nightly rustfmt ↩

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented May 21, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3599607 3586493 ✅ -13114 (-0.36%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10432316 10506198 73882 (0.71%) 1.13%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11572449 11510829 -61620 (-0.53%) 1.13%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9951497 9936403 -15094 (-0.15%) 0.69%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78730850 78652349 -78501 (-0.10%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78418195 78475390 57195 (0.07%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56583968 56544884 -39084 (-0.07%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78734682 78783112 48430 (0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78698693 78742132 43439 (0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55203215 55231803 28588 (0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4749484 4747258 -2226 (-0.05%) 0.21%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56603649 56627886 24237 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56593947 56615617 21670 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78443755 78414591 -29164 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78698076 78669343 -28733 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11561442 11565439 3997 (0.03%) 1.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78484836 78509966 25130 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55212832 55198482 -14350 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56565938 56551559 -14379 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55285118 55297640 12522 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9952465 9954714 2249 (0.02%) 0.75%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78487566 78503691 16125 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78454617 78470727 16110 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78709170 78724134 14964 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55209497 55219032 9535 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003529 2003851 322 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78691438 78679502 -11936 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55283646 55291376 7730 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56600833 56608252 7419 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2904491 2904801 310 (0.01%) 0.77%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3580089 3580465 376 (0.01%) 1.30%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001204 2001011 -193 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305332 3305638 306 (0.01%) 0.28%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56554309 56549962 -4347 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2907438 2907592 154 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4750269 4750481 212 (0.00%) 0.21%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78526085 78528570 2485 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55293847 55295167 1320 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304276 3304236 -40 (-0.00%) 0.24%
transfer_no_resume_ring_1.2_rsa_aes_server 46189296 46189286 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294220 46294230 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92693668 92693649 -19 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58148972 58148961 -11 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58251609 58251619 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58229015 58229024 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80632584 80632575 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397771 46397766 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92662829 92662820 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80643595 80643602 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46448257 46448261 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92653698 92653691 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92685291 92685298 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157305 58157301 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46289081 46289084 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452699 46452702 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637661 80637656 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533869 80533873 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284266 46284268 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46459283 46459281 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58035394 58035396 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58117367 58117369 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58124575 58124573 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58226793 58226791 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80538689 80538691 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92691435 92691433 -2 (-0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4569978 4569978 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32448453 32448453 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4218636 4218636 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550408 32550408 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295236 1295236 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34738017 34738017 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32112825 32112825 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11127897 11127897 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339895 2339895 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4757724 4757724 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224449 31224449 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451262 32451262 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30837854 30837854 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246487 2246487 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926215 30926215 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30841908 30841908 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31156538 31156538 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867861 3867861 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334246 2334246 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31987990 31987990 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31231797 31231797 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719932 1719932 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012380 5012380 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92717526 92717526 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4298386 4298386 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112692 32112692 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933198 30933198 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736321 34736321 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553130 32553130 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31160526 31160526 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31991175 31991175 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3876541 3876541 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31227809 31227809 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929144 30929144 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133658 11133658 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31153199 31153199 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553217 32553217 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296418 1296418 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4306360 4306360 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31991042 31991042 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451220 32451220 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7220953 7220953 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80543190 80543190 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10999871 10999871 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30834925 30834925 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109640 32109640 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7222914 7222914 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.73 ms 4.63 ms -0.10 ms (-2.11%) 5.65%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.13 ms 5.03 ms -0.10 ms (-1.86%) 6.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.43 ms 5.33 ms -0.10 ms (-1.84%) 4.68%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.41 ms 5.31 ms -0.10 ms (-1.81%) 5.12%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.43 ms 5.33 ms -0.10 ms (-1.78%) 4.79%
transfer_no_resume_ring_1.2_rsa_aes 5.87 ms 5.77 ms -0.10 ms (-1.75%) 5.08%
transfer_no_resume_ring_1.3_rsa_aes 5.92 ms 5.82 ms -0.10 ms (-1.69%) 4.58%
handshake_no_resume_ring_1.3_ecdsap256_aes 467.61 µs 461.89 µs -5.72 µs (-1.22%) 3.14%
handshake_no_resume_ring_1.3_ecdsap256_chacha 465.17 µs 459.74 µs -5.43 µs (-1.17%) 3.44%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.53 ms 8.44 ms -0.09 ms (-1.09%) 2.85%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 654.59 µs 647.74 µs -6.85 µs (-1.05%) 3.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 655.35 µs 648.67 µs -6.68 µs (-1.02%) 4.44%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.20 ms 13.10 ms -0.10 ms (-0.78%) 1.75%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.99 ms 12.89 ms -0.10 ms (-0.78%) 1.90%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.88 ms 13.77 ms -0.10 ms (-0.75%) 2.12%
transfer_no_resume_ring_1.3_rsa_chacha 13.49 ms 13.39 ms -0.10 ms (-0.74%) 2.05%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.88 ms 13.78 ms -0.10 ms (-0.74%) 1.74%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.83 ms 1.82 ms -0.01 ms (-0.71%) 4.06%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.32 ms 1.32 ms -0.01 ms (-0.62%) 2.94%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.09 ms 15.99 ms -0.10 ms (-0.60%) 1.46%
handshake_tickets_ring_1.3_ecdsap256_aes 5.61 ms 5.58 ms -0.03 ms (-0.60%) 1.44%
handshake_no_resume_ring_1.3_rsa_aes 957.30 µs 951.63 µs -5.67 µs (-0.59%) 1.48%
handshake_session_id_ring_1.3_ecdsap256_aes 5.55 ms 5.52 ms -0.03 ms (-0.53%) 1.57%
handshake_session_id_ring_1.3_rsa_aes 6.05 ms 6.02 ms -0.03 ms (-0.52%) 1.80%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.52 ms 5.49 ms -0.03 ms (-0.52%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.34 ms 1.33 ms -0.01 ms (-0.48%) 1.56%
handshake_tickets_ring_1.3_rsa_aes 6.10 ms 6.08 ms -0.03 ms (-0.47%) 1.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.33 ms 1.33 ms -0.01 ms (-0.47%) 1.70%
handshake_tickets_ring_1.3_rsa_chacha 6.07 ms 6.05 ms -0.03 ms (-0.45%) 1.30%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.58 ms 5.56 ms -0.02 ms (-0.45%) 1.64%
handshake_no_resume_ring_1.3_rsa_chacha 955.92 µs 951.73 µs -4.19 µs (-0.44%) 1.47%
handshake_session_id_ring_1.3_rsa_chacha 6.01 ms 5.98 ms -0.03 ms (-0.43%) 1.41%
handshake_no_resume_ring_1.2_rsa_aes 952.98 µs 949.03 µs -3.95 µs (-0.41%) 1.66%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.33 ms 1.32 ms -0.01 ms (-0.39%) 2.91%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.81 ms 10.77 ms -0.04 ms (-0.39%) 1.38%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.50 ms -0.01 ms (-0.39%) 2.40%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.47 ms 11.43 ms -0.04 ms (-0.38%) 1.39%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.79 ms 10.75 ms -0.04 ms (-0.36%) 1.60%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.49 ms 11.45 ms -0.04 ms (-0.36%) 1.37%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.62 ms 10.59 ms -0.04 ms (-0.34%) 1.55%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.50 ms 11.47 ms -0.04 ms (-0.34%) 1.53%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.67 ms 8.65 ms -0.03 ms (-0.33%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.59 ms 1.59 ms -0.01 ms (-0.33%) 1.49%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.32 ms 11.28 ms -0.04 ms (-0.33%) 1.12%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.61 ms 8.59 ms -0.03 ms (-0.32%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.31 ms 11.27 ms -0.04 ms (-0.32%) 1.27%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.46 ms 11.42 ms -0.04 ms (-0.31%) 1.40%
handshake_session_id_ring_1.3_ecdsap384_aes 8.64 ms 8.61 ms -0.03 ms (-0.31%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.70 ms 8.68 ms -0.03 ms (-0.31%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.59 ms 10.56 ms -0.03 ms (-0.30%) 1.50%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.28 ms 11.25 ms -0.03 ms (-0.29%) 1.45%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.65 ms 1.65 ms -0.00 ms (-0.29%) 3.36%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.08 ms 1.08 ms -0.00 ms (-0.27%) 4.42%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.26 ms 11.23 ms -0.03 ms (-0.24%) 1.69%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.57 ms 3.56 ms -0.01 ms (-0.15%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.57 ms 3.56 ms -0.01 ms (-0.14%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.27%. Comparing base (70fc076) to head (82e81bb).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2466   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          97       97           
  Lines       21357    21357           
=======================================
  Hits        20348    20348           
  Misses       1009     1009

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

djc
djc approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ctz
Copy link
Member Author

ctz commented May 21, 2025

(added a commit that unpins nightly and actually fixes the job: https://github.com/rustls/rustls/actions/runs/15162912076/job/42633139323?pr=2466 )

@ctz ctz added this pull request to the merge queue May 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 21, 2025
@ctz ctz force-pushed the jbp-unstable-rustfmt branch from bcff9df to a5a298e Compare May 21, 2025 13:32
@ctz ctz force-pushed the jbp-unstable-rustfmt branch from a5a298e to 82e81bb Compare May 21, 2025 13:44
@ctz ctz added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit 91e33db May 21, 2025
34 checks passed
@ctz ctz deleted the jbp-unstable-rustfmt branch May 21, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu