Skip to content

Enable more lints on internal crates #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 21, 2025
Merged

Enable more lints on internal crates #2465

merged 7 commits into from
May 21, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented May 21, 2025

Internal crates now enable the default-allow lints that the core crate does, with the exception of ones about documentation for public items.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented May 21, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001101 2007748 ⚠️ 6647 (0.33%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4746835 4761213 ⚠️ 14378 (0.30%) 0.27%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11616121 11534631 -81490 (-0.70%) 1.14%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11583195 11550224 -32971 (-0.28%) 1.62%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10461417 10435503 -25914 (-0.25%) 1.13%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2904134 2911124 6990 (0.24%) 0.77%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9954071 9969352 15281 (0.15%) 0.70%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78676595 78729781 53186 (0.07%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78690820 78737907 47087 (0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78539107 78494147 -44960 (-0.06%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9950149 9944559 -5590 (-0.06%) 0.75%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78467941 78426495 -41446 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56546880 56573506 26626 (0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56591779 56615143 23364 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55300493 55277956 -22537 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55224961 55204255 -20706 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78510277 78483002 -27275 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4750523 4748944 -1579 (-0.03%) 0.21%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78667740 78689957 22217 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55298282 55284176 -14106 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78444794 78464544 19750 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78698310 78717885 19575 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2907154 2907812 658 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3581155 3580428 -727 (-0.02%) 1.31%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55204797 55215935 11138 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56585448 56596783 11335 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56550764 56561891 11127 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78666841 78654080 -12761 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3587061 3586481 -580 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78711606 78698903 -12703 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003733 2003992 259 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56552263 56545508 -6755 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56600290 56594069 -6221 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304371 3304236 -135 (-0.00%) 0.24%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78461242 78464398 3156 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55224890 55226294 1404 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78515152 78516662 1510 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55297083 55297859 776 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58229014 58229657 643 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3303383 3303347 -36 (-0.00%) 0.27%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7222904 7222922 18 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719936 1719932 -4 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295239 1295236 -3 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34737992 34738042 50 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736291 34736308 17 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7220952 7220955 3 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189296 46189287 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284263 46284270 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58148972 58148980 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80632585 80632575 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533864 80533872 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80543187 80543179 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294219 46294223 4 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58035393 58035397 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58124577 58124573 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58251612 58251608 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46289084 46289087 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46448255 46448258 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452701 46452698 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92717527 92717532 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92693662 92693659 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397768 46397769 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46459278 46459279 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58117364 58117363 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157301 58157300 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58226782 58226781 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80538681 80538682 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637660 80637659 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80643598 80643599 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92662824 92662823 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92691429 92691428 -1 (-0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4298386 4298386 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109640 32109640 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339895 2339895 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3876541 3876541 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133658 11133658 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30837854 30837854 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112692 32112692 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296418 1296418 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92685299 92685299 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926215 30926215 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31160526 31160526 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31156538 31156538 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4306360 4306360 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31991175 31991175 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31231797 31231797 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553217 32553217 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012380 5012380 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92653679 92653679 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867861 3867861 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451262 32451262 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4569978 4569978 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31153199 31153199 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929144 30929144 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30834925 30834925 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31991042 31991042 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30841908 30841908 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933198 30933198 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451220 32451220 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31227809 31227809 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224449 31224449 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4757724 4757724 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553130 32553130 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246487 2246487 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10999871 10999871 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11127897 11127897 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334246 2334246 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4218636 4218636 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550408 32550408 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32448453 32448453 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32112825 32112825 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31987990 31987990 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.73 ms 4.67 ms -0.05 ms (-1.10%) 5.85%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.13 ms 5.07 ms -0.05 ms (-1.02%) 6.27%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.42 ms 5.37 ms -0.05 ms (-0.96%) 5.02%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.40 ms 5.35 ms -0.05 ms (-0.94%) 5.32%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.42 ms 5.38 ms -0.05 ms (-0.89%) 4.97%
transfer_no_resume_ring_1.2_rsa_aes 5.87 ms 5.82 ms -0.05 ms (-0.86%) 5.30%
transfer_no_resume_ring_1.3_rsa_aes 5.91 ms 5.86 ms -0.05 ms (-0.77%) 4.93%
handshake_no_resume_ring_1.3_ecdsap256_chacha 465.19 µs 462.27 µs -2.93 µs (-0.63%) 3.49%
handshake_no_resume_ring_1.3_ecdsap256_aes 467.53 µs 464.79 µs -2.74 µs (-0.59%) 3.43%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.53 ms 8.48 ms -0.04 ms (-0.52%) 3.09%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 654.48 µs 651.15 µs -3.33 µs (-0.51%) 4.18%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 655.51 µs 652.35 µs -3.16 µs (-0.48%) 4.64%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.52 ms 5.50 ms -0.03 ms (-0.46%) 1.31%
handshake_tickets_ring_1.3_rsa_aes 6.11 ms 6.08 ms -0.02 ms (-0.41%) 1.22%
handshake_session_id_ring_1.3_rsa_aes 6.05 ms 6.02 ms -0.02 ms (-0.40%) 1.80%
transfer_no_resume_ring_1.3_rsa_chacha 13.48 ms 13.43 ms -0.05 ms (-0.39%) 2.07%
handshake_session_id_ring_1.3_rsa_chacha 6.01 ms 5.99 ms -0.02 ms (-0.38%) 1.41%
handshake_session_id_ring_1.3_ecdsap256_aes 5.55 ms 5.53 ms -0.02 ms (-0.38%) 1.57%
handshake_tickets_ring_1.3_ecdsap256_aes 5.61 ms 5.59 ms -0.02 ms (-0.38%) 1.44%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.59 ms 5.56 ms -0.02 ms (-0.38%) 1.69%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.99 ms 12.94 ms -0.05 ms (-0.36%) 1.96%
handshake_tickets_ring_1.3_rsa_chacha 6.08 ms 6.06 ms -0.02 ms (-0.35%) 1.37%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.19 ms 13.15 ms -0.05 ms (-0.35%) 1.92%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.87 ms 13.82 ms -0.04 ms (-0.31%) 2.42%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.51 ms -0.00 ms (-0.29%) 2.46%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.09 ms 16.04 ms -0.05 ms (-0.29%) 1.48%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.33 ms 1.33 ms -0.00 ms (-0.28%) 1.70%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.87 ms 13.84 ms -0.04 ms (-0.28%) 1.96%
handshake_no_resume_ring_1.3_rsa_chacha 955.97 µs 953.54 µs -2.43 µs (-0.25%) 1.52%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.32 ms 11.30 ms -0.03 ms (-0.24%) 1.19%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.63 ms 10.61 ms -0.02 ms (-0.23%) 1.57%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.62 ms 8.60 ms -0.02 ms (-0.22%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.70 ms 8.68 ms -0.02 ms (-0.22%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.31 ms 11.29 ms -0.02 ms (-0.21%) 1.28%
handshake_session_id_ring_1.3_ecdsap384_aes 8.64 ms 8.62 ms -0.02 ms (-0.21%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.67 ms 8.66 ms -0.02 ms (-0.21%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.82 ms 10.80 ms -0.02 ms (-0.19%) 1.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.51 ms 11.49 ms -0.02 ms (-0.18%) 1.53%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.34 ms 1.34 ms -0.00 ms (-0.17%) 1.58%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.32 ms 1.32 ms -0.00 ms (-0.16%) 3.12%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.49 ms 11.47 ms -0.02 ms (-0.15%) 1.39%
handshake_no_resume_ring_1.3_rsa_aes 956.35 µs 954.97 µs -1.38 µs (-0.14%) 1.59%
handshake_no_resume_ring_1.2_rsa_aes 952.41 µs 951.08 µs -1.33 µs (-0.14%) 1.77%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.79 ms 10.77 ms -0.01 ms (-0.14%) 1.75%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.46 ms 11.45 ms -0.01 ms (-0.13%) 1.40%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.28 ms 11.27 ms -0.01 ms (-0.12%) 1.48%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.46 ms 11.45 ms -0.01 ms (-0.11%) 1.44%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.60 ms 10.59 ms -0.01 ms (-0.10%) 1.54%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.26 ms 11.25 ms -0.01 ms (-0.08%) 1.69%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.56 ms 3.56 ms -0.00 ms (-0.07%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.59 ms 1.59 ms -0.00 ms (-0.05%) 1.85%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.82 ms 1.82 ms -0.00 ms (-0.05%) 4.45%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.33 ms 1.33 ms -0.00 ms (-0.02%) 2.91%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.65 ms 1.65 ms 0.00 ms (0.01%) 3.82%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.08 ms 1.08 ms -0.00 ms (-0.00%) 4.44%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.56 ms 3.56 ms 0.00 ms (0.00%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.27%. Comparing base (34fb672) to head (a0b66b6).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2465   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          97       97           
  Lines       21357    21357           
=======================================
  Hits        20348    20348           
  Misses       1009     1009

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

djc
djc approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Personally I feel like the Arc::clone() idiom isn't worth it...

@ctz ctz added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit 70fc076 May 21, 2025
34 checks passed
@ctz ctz deleted the jbp-more-lints-on-internal-crates branch May 21, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu