Small clippy fixes #2458
Merged
Small clippy fixes #2458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Of the form:
```
error: empty line after doc comment
--> rustls/build.rs:4:1
|
4 | / /// See the comment in lib.rs to understand why we need this.
5 | |
| |_^
6 | #[cfg_attr(feature = "read_buf", rustversion::not(nightly))]
7 | fn main() {}
| ------- the comment documents this function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `-D clippy::empty-line-after-doc-comments` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::empty_line_after_doc_comments)]`
= help: if the empty line is unintentional, remove it
help: if the comment should document the crate use an inner doc comment
|
1 ~ //! This build script allows us to enable the `read_buf` language feature only
2 ~ //! for Rust Nightly.
3 ~ //!
4 ~ //! See the comment in lib.rs to understand why we need this.
```
of the form:
```
error: this can be `std::io::Error::other(_)`
--> ci-bench/src/util.rs:293:40
|
293 | return Poll::Ready(Err(io::Error::new(
| ________________________________________^
294 | | io::ErrorKind::Other,
295 | | "channel was closed",
296 | | )));
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
= note: `-D clippy::io-other-error` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::io_other_error)]`
help: use `std::io::Error::other`
|
293 ~ return Poll::Ready(Err(io::Error::other(
294 ~ "channel was closed",
|
```
djc
approved these changes
May 15, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2458 +/- ##
==========================================
- Coverage 95.26% 95.26% -0.01%
==========================================
Files 95 95
Lines 21256 21252 -4
==========================================
- Hits 20250 20246 -4
Misses 1006 1006 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
ctz
reviewed
May 15, 2025
of the form:
```
error: variables can be used directly in the `format!` string
--> rustls/src/server/tls13.rs:1347:9
|
1347 | trace!("sending new ticket {:?} (stateless: {})", t, stateless);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
1347 - trace!("sending new ticket {:?} (stateless: {})", t, stateless);
1347 + trace!("sending new ticket {t:?} (stateless: {stateless})");
|
```
Diff produced with `cargo clippy --fix --all-features --all-targets;
cargo fmt`.
ctz
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits fix the clippy task failing for
mainfrom new findings spit out by the brand new 1.87 release. The third commit fixes nightly clippy for me locally. If it's too noisy of a diff we can drop the 3rd commit and take only the 1st/2nd for now.