Skip to content

SECURITY.md: temporal updates #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

SECURITY.md: temporal updates #2456

merged 1 commit into from
May 9, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented May 9, 2025

  • update example about security support
  • update MSRV example
  • write example MSRVs without patch versions, for clarity

Copy link

rustls-benchmarking bot commented May 9, 2025

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9936752 9980689 43937 (0.44%) 0.98%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11560496 11594245 33749 (0.29%) 1.05%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10512458 10486020 -26438 (-0.25%) 1.09%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11588335 11564435 -23900 (-0.21%) 1.64%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9977877 9965193 -12684 (-0.13%) 0.91%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78453832 78547915 94083 (0.12%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55211033 55258158 47125 (0.09%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78706525 78664749 -41776 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78474056 78437171 -36885 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78677052 78709209 32157 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78496462 78467005 -29457 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78730268 78700945 -29323 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56561928 56541032 -20896 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4751771 4750057 -1714 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2913904 2912866 -1038 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78515356 78488221 -27135 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55231355 55212653 -18702 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3587425 3586251 -1174 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78737933 78760793 22860 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56584864 56601098 16234 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55291037 55276193 -14844 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56609946 56595402 -14544 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78681297 78699611 18314 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4749524 4748419 -1105 (-0.02%) 0.29%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56605399 56618389 12990 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55289231 55276807 -12424 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78499153 78485117 -14036 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56559459 56568535 9076 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78682638 78670944 -11694 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55289173 55282293 -6880 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56558547 56552619 -5928 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305696 3305430 -266 (-0.01%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001548 2001400 -148 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2003643 2003536 -107 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304370 3304256 -114 (-0.00%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2910287 2910372 85 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55211303 55211667 364 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78440764 78441255 491 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3579399 3579415 16 (0.00%) 1.34%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294534 46294544 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452707 46452715 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46461257 46461249 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92685300 92685289 -11 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92691972 92691961 -11 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80634529 80634520 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80645577 80645569 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58251611 58251616 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637672 80637666 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397779 46397776 -3 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34744016 34744014 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58227329 58227326 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533883 80533879 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189318 46189316 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58035395 58035397 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58124574 58124572 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92662829 92662826 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92717527 92717524 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80545421 80545423 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284279 46284280 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46291016 46291015 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58148972 58148973 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58157302 58157303 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58226782 58226781 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92653698 92653697 -1 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227117 7227117 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295484 1295484 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31231793 31231793 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296666 1296666 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3867855 3867855 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012134 5012134 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32109433 32109433 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926341 30926341 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719747 1719747 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30837796 30837796 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34742300 34742300 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4306164 4306164 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4218370 4218370 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32112394 32112394 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31990943 31990943 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80540623 80540623 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246298 2246298 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4569708 4569708 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11133847 11133847 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339715 2339715 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31990744 31990744 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31227743 31227743 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224515 31224515 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32448134 32448134 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4757720 4757720 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30841974 30841974 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933264 30933264 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2334066 2334066 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3876267 3876267 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46450202 46450202 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30835051 30835051 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58117363 58117363 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32112593 32112593 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32553135 32553135 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4298144 4298144 0 (0.00%) 0.24%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229076 7229076 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31156472 31156472 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128086 11128086 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92691425 92691425 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32550089 32550089 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31987783 31987783 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32451180 32451180 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000039 11000039 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32553048 32553048 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31160522 31160522 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32451138 32451138 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31153265 31153265 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929086 30929086 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.16 ms 11.13 ms -0.03 ms (-0.30%) 1.63%
handshake_no_resume_ring_1.3_ecdsap256_aes 481.77 µs 480.44 µs -1.33 µs (-0.28%) 4.43%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.33 ms 11.30 ms -0.03 ms (-0.26%) 1.40%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.79 ms 1.79 ms -0.00 ms (-0.25%) 4.45%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.14 ms 11.11 ms -0.03 ms (-0.25%) 1.31%
handshake_session_id_ring_1.3_ecdsap256_aes 5.55 ms 5.56 ms 0.01 ms (0.25%) 1.48%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.36 ms 11.33 ms -0.03 ms (-0.24%) 1.46%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.48 ms 10.46 ms -0.02 ms (-0.23%) 1.76%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.21 ms 11.18 ms -0.03 ms (-0.23%) 1.36%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.13 ms 5.12 ms -0.01 ms (-0.22%) 6.43%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.52 ms 10.50 ms -0.02 ms (-0.21%) 1.72%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.68 ms 10.66 ms -0.02 ms (-0.20%) 1.60%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms -0.00 ms (-0.19%) 1.68%
handshake_session_id_ring_1.3_rsa_aes 6.05 ms 6.06 ms 0.01 ms (0.19%) 1.31%
handshake_tickets_ring_1.3_rsa_aes 6.11 ms 6.12 ms 0.01 ms (0.18%) 1.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.71 ms 10.69 ms -0.02 ms (-0.17%) 1.36%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 666.99 µs 665.94 µs -1.06 µs (-0.16%) 4.65%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.17 ms 11.16 ms -0.02 ms (-0.16%) 1.19%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms -0.00 ms (-0.16%) 4.41%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.40 ms 11.38 ms -0.02 ms (-0.15%) 1.53%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.48 ms 5.47 ms -0.01 ms (-0.14%) 6.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 666.35 µs 665.44 µs -0.91 µs (-0.14%) 4.31%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.35 ms 11.34 ms -0.02 ms (-0.14%) 1.46%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.35 ms 1.35 ms -0.00 ms (-0.13%) 1.58%
handshake_tickets_ring_1.3_ecdsap384_aes 8.71 ms 8.72 ms 0.01 ms (0.12%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.77 ms 4.77 ms 0.01 ms (0.11%) 6.70%
handshake_session_id_ring_1.3_ecdsap384_aes 8.64 ms 8.65 ms 0.01 ms (0.11%) 1.01%
handshake_session_id_ring_1.3_rsa_chacha 6.01 ms 6.02 ms 0.01 ms (0.10%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.62 ms 5.63 ms 0.01 ms (0.10%) 1.21%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.30 ms 1.30 ms -0.00 ms (-0.10%) 4.47%
transfer_no_resume_ring_1.2_rsa_aes 5.89 ms 5.88 ms -0.01 ms (-0.09%) 6.13%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.61 ms 8.62 ms 0.01 ms (0.08%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 970.20 µs 969.47 µs -0.73 µs (-0.08%) 2.15%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.40 ms 5.40 ms 0.00 ms (0.07%) 5.63%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.52 ms 5.53 ms 0.00 ms (0.07%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.46 ms 5.47 ms 0.00 ms (0.07%) 6.19%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.58 ms 3.58 ms 0.00 ms (0.05%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 478.82 µs 478.57 µs -0.25 µs (-0.05%) 4.77%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms 0.00 ms (0.05%) 1.98%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.58 ms 3.58 ms -0.00 ms (-0.05%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.57 ms 8.57 ms -0.00 ms (-0.05%) 3.82%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.68 ms 8.69 ms 0.00 ms (0.04%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.59 ms 5.59 ms 0.00 ms (0.04%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 965.95 µs 966.34 µs 0.39 µs (0.04%) 1.63%
transfer_no_resume_ring_1.3_rsa_aes 5.96 ms 5.96 ms 0.00 ms (0.03%) 5.74%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.03 ms 13.03 ms -0.00 ms (-0.03%) 2.64%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.24 ms 13.24 ms -0.00 ms (-0.02%) 2.45%
handshake_no_resume_ring_1.3_rsa_aes 969.91 µs 970.09 µs 0.18 µs (0.02%) 1.97%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.88 ms 13.88 ms 0.00 ms (0.01%) 2.49%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.13 ms 16.13 ms -0.00 ms (-0.01%) 2.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.34 ms 1.34 ms 0.00 ms (0.01%) 1.86%
handshake_tickets_ring_1.3_rsa_chacha 6.08 ms 6.08 ms -0.00 ms (-0.01%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.30 ms 1.30 ms 0.00 ms (0.00%) 4.70%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.61 ms 1.61 ms -0.00 ms (-0.00%) 3.07%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.92 ms 13.92 ms 0.00 ms (0.00%) 2.10%
transfer_no_resume_ring_1.3_rsa_chacha 13.52 ms 13.52 ms -0.00 ms (-0.00%) 2.74%

Additional information

Historical results

Checkout details:

@ctz ctz enabled auto-merge May 9, 2025 16:10
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.26%. Comparing base (73339c2) to head (8c792e7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2456   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files          95       95           
  Lines       21256    21256           
=======================================
  Hits        20250    20250           
  Misses       1006     1006           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz ctz added this pull request to the merge queue May 9, 2025
Merged via the queue into main with commit b30fc9e May 9, 2025
34 checks passed
@ctz ctz deleted the jbp-sec-temporal branch May 9, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants