Skip to content

Extension testing tweaks #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2025
Merged

Extension testing tweaks #2447

merged 3 commits into from
May 2, 2025

Conversation

djc
Copy link
Member

@djc djc commented May 2, 2025 •
edited
Loading

Targeting #2443.

Should probably squash some of these changes?

@djc djc requested a review from ctz May 2, 2025 12:46
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented May 2, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9981762 9950805 -30957 (-0.31%) 0.87%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10484688 10508232 23544 (0.22%) 1.14%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11544659 11523703 -20956 (-0.18%) 1.71%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3304766 3300631 -4135 (-0.13%) 0.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78714684 78662539 -52145 (-0.07%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3301476 3303630 2154 (0.07%) 0.26%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78476672 78520418 43746 (0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78690874 78731621 40747 (0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56574322 56548532 -25790 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78704436 78739710 35274 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78518521 78483766 -34755 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9964961 9960723 -4238 (-0.04%) 1.04%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11540076 11535301 -4775 (-0.04%) 1.04%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4746601 4748507 1906 (0.04%) 0.55%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55285803 55307519 21716 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78677787 78647809 -29978 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56588861 56609177 20316 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56559344 56578527 19183 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3585270 3586448 1178 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78428017 78453395 25378 (0.03%) 0.21%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55303261 55285847 -17414 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78518772 78494397 -24375 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56554590 56539593 -14997 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2000947 2001433 486 (0.02%) 1.42%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55201274 55214317 13043 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55296818 55284638 -12180 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78434208 78417696 -16512 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4750618 4749626 -992 (-0.02%) 0.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2004234 2003905 -329 (-0.02%) 1.43%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78716605 78704723 -11882 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55212474 55204385 -8089 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78432704 78444168 11464 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2913358 2913672 314 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55215074 55220842 5768 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56593143 56587255 -5888 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78727066 78720575 -6491 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3578960 3578741 -219 (-0.01%) 1.27%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56608224 56605245 -2979 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2910569 2910447 -122 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296733 1296746 13 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295549 1295551 2 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741445 34741462 17 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227181 7227184 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46291025 46291014 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284290 46284280 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58231415 58231404 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58122626 58122635 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92696048 92696060 12 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80540614 80540624 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80545424 80545414 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80645567 80645577 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92668095 92668085 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46460613 46460608 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58163188 58163194 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92696600 92696591 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58256235 58256230 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58129841 58129837 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58231951 58231947 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294536 46294533 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46450204 46450201 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80634524 80634529 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637675 80637672 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92722148 92722151 3 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189315 46189314 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397777 46397778 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452706 46452705 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58154236 58154237 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92658963 92658962 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92690563 92690562 -1 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11124883 11124883 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31222863 31222863 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30921425 30921425 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3874767 3874767 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30832888 30832888 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31219607 31219607 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32554095 32554095 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32551049 32551049 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32452098 32452098 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31155650 31155650 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31226921 31226921 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31991783 31991783 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533889 80533889 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3868845 3868845 0 (0.00%) 0.27%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4216960 4216960 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229151 7229151 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30924178 30924178 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31151592 31151592 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32449094 32449094 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31991584 31991584 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4568298 4568298 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32113433 32113433 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31148357 31148357 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30830135 30830135 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10996746 10996746 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4304664 4304664 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32452140 32452140 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2338983 2338983 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743199 34743199 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2245503 2245503 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30928364 30928364 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1718952 1718952 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4299134 4299134 0 (0.00%) 0.24%
transfer_no_resume_ring_1.2_rsa_aes_client 58041282 58041282 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31988623 31988623 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30837074 30837074 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5010484 5010484 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4758860 4758860 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32110273 32110273 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11130644 11130644 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32113234 32113234 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333334 2333334 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32554008 32554008 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.65 ms 4.69 ms 0.04 ms (0.83%) 5.28%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.01 ms 5.05 ms 0.04 ms (0.72%) 6.40%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.36 ms 5.39 ms 0.04 ms (0.69%) 4.26%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.35 ms 5.38 ms 0.04 ms (0.67%) 4.88%
transfer_no_resume_ring_1.3_rsa_aes 5.85 ms 5.88 ms 0.04 ms (0.61%) 3.80%
transfer_no_resume_ring_1.2_rsa_aes 5.77 ms 5.81 ms 0.03 ms (0.60%) 4.83%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 658.84 µs 662.74 µs 3.91 µs (0.59%) 3.91%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.29 ms 5.32 ms 0.03 ms (0.56%) 5.55%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.61 ms 1.62 ms 0.01 ms (0.54%) 3.69%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.78 ms 1.79 ms 0.01 ms (0.50%) 3.33%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms 0.01 ms (0.41%) 1.61%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.29 ms 1.30 ms 0.01 ms (0.41%) 5.61%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.46 ms 8.49 ms 0.03 ms (0.39%) 2.52%
handshake_no_resume_ring_1.3_ecdsap256_chacha 472.55 µs 474.35 µs 1.79 µs (0.38%) 2.80%
handshake_no_resume_ring_1.3_ecdsap256_aes 475.11 µs 476.48 µs 1.37 µs (0.29%) 2.82%
transfer_no_resume_ring_1.3_rsa_chacha 13.41 ms 13.44 ms 0.04 ms (0.28%) 1.91%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.13 ms 13.16 ms 0.04 ms (0.27%) 1.84%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.29 ms 1.29 ms 0.00 ms (0.27%) 9.01%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.64 ms 10.67 ms 0.03 ms (0.27%) 1.98%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.92 ms 12.95 ms 0.03 ms (0.26%) 1.99%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.81 ms 13.85 ms 0.04 ms (0.26%) 1.85%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms 0.00 ms (0.25%) 2.17%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.28 ms 11.31 ms 0.02 ms (0.22%) 2.46%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.51 ms 5.50 ms -0.01 ms (-0.22%) 1.01%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms 0.00 ms (0.22%) 5.85%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 660.05 µs 661.48 µs 1.43 µs (0.22%) 4.12%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.77 ms 13.80 ms 0.03 ms (0.21%) 2.39%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.35 ms 1.35 ms 0.00 ms (0.21%) 1.51%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.03 ms 16.06 ms 0.03 ms (0.21%) 1.65%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.63 ms 10.65 ms 0.02 ms (0.19%) 2.24%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.33 ms 11.35 ms 0.02 ms (0.18%) 1.50%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.31 ms 11.32 ms 0.02 ms (0.17%) 2.18%
handshake_no_resume_ring_1.3_rsa_chacha 962.58 µs 964.16 µs 1.59 µs (0.16%) 1.42%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.11 ms 11.13 ms 0.02 ms (0.16%) 1.51%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.46 ms 10.48 ms 0.02 ms (0.15%) 1.87%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.43 ms 10.45 ms 0.01 ms (0.14%) 1.82%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.67 ms 8.65 ms -0.01 ms (-0.14%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.64 ms 8.62 ms -0.01 ms (-0.14%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.15 ms 11.16 ms 0.01 ms (0.13%) 1.36%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.27 ms 11.29 ms 0.01 ms (0.13%) 1.98%
handshake_session_id_ring_1.3_ecdsap256_aes 5.54 ms 5.53 ms -0.01 ms (-0.12%) 1.26%
handshake_session_id_ring_1.3_rsa_chacha 5.99 ms 5.98 ms -0.01 ms (-0.11%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.03 ms 6.03 ms -0.01 ms (-0.11%) 1.02%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.11 ms 11.12 ms 0.01 ms (0.11%) 1.33%
handshake_no_resume_ring_1.2_rsa_aes 958.39 µs 959.38 µs 0.99 µs (0.10%) 1.33%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.60 ms 8.59 ms -0.01 ms (-0.10%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.08 ms 11.09 ms 0.01 ms (0.09%) 1.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.34 ms 1.34 ms 0.00 ms (0.09%) 1.82%
handshake_tickets_ring_1.3_ecdsap384_aes 8.69 ms 8.68 ms -0.01 ms (-0.07%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 963.33 µs 963.82 µs 0.49 µs (0.05%) 1.73%
handshake_tickets_ring_1.3_rsa_chacha 6.05 ms 6.05 ms -0.00 ms (-0.05%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.56 ms 5.56 ms -0.00 ms (-0.04%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.58 ms 3.58 ms 0.00 ms (0.03%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.08 ms 6.08 ms -0.00 ms (-0.02%) 1.15%
handshake_tickets_ring_1.3_ecdsap256_aes 5.59 ms 5.59 ms 0.00 ms (0.01%) 1.21%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.58 ms 3.58 ms -0.00 ms (-0.01%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented May 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.98%. Comparing base (4286587) to head (9274238).
Report is 3 commits behind head on jbp-extensions-testing.

Files with missing lines Patch % Lines
rustls/src/msgs/handshake.rs 95.74% 2 Missing ⚠️
Additional details and impacted files 
@@                    Coverage Diff                     @@
##           jbp-extensions-testing    #2447      +/-   ##
==========================================================
+ Coverage                   95.75%   95.98%   +0.23%     
==========================================================
  Files                          95       94       -1     
  Lines                       24183    22775    -1408     
==========================================================
- Hits                        23156    21861    -1295     
+ Misses                       1027      914     -113

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz
Copy link
Member

ctz commented May 2, 2025

Thanks!

@djc djc merged commit df44c98 into jbp-extensions-testing May 2, 2025
64 checks passed
@djc djc deleted the ext-tweaks branch May 2, 2025 14:29
@ctz ctz mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djc @ctz