Skip to content

clarify comments, field and parameter identifiers #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2025
Merged

clarify comments, field and parameter identifiers #2432

merged 3 commits into from
Apr 22, 2025

Conversation

elagergren-spideroak
Copy link
Contributor

For #2424

@elagergren-spideroak elagergren-spideroak changed the title add clarifying comments clarify comments, field and parameter identifiers Apr 16, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (841a160) to head (a154abd).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2432   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files          94       94           
  Lines       22597    22599    +2     
=======================================
+ Hits        21680    21682    +2     
  Misses        917      917

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ctz
ctz approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Apr 16, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2920017 2913465 ✅ -6552 (-0.22%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9961866 9919233 -42633 (-0.43%) 0.99%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11556581 11518621 -37960 (-0.33%) 1.71%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10428613 10458715 30102 (0.29%) 1.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9993437 9964921 -28516 (-0.29%) 0.81%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3872295 3867345 -4950 (-0.13%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5013862 5008912 -4950 (-0.10%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4302818 4298588 -4230 (-0.10%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4762742 4758512 -4230 (-0.09%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303806 3301655 -2151 (-0.07%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4582093 4579243 -2850 (-0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4230552 4228422 -2130 (-0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4747321 4744993 -2328 (-0.05%) 0.56%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 78538790 78502215 -36575 (-0.05%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4318732 4316752 -1980 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 55297658 55274798 -22860 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 78477563 78446487 -31076 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 55217153 55196779 -20374 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 78422273 78450132 27859 (0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3586939 3585671 -1268 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3579617 3578412 -1205 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3887901 3886641 -1260 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 78484068 78508276 24208 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 78660258 78682501 22243 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4750270 4749178 -1092 (-0.02%) 0.36%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 78663697 78681617 17920 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31985423 31978763 -6660 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31988035 31981375 -6660 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31988040 31981380 -6660 (-0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32107073 32100413 -6660 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32109685 32103025 -6660 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32109690 32103030 -6660 (-0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32452065 32445405 -6660 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32454508 32447848 -6660 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32454546 32447886 -6660 (-0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32554020 32547360 -6660 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32556456 32549796 -6660 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32556463 32549803 -6660 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 78714076 78728460 14384 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 55200566 55209477 8911 (0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1296839 1296657 -182 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295655 1295475 -180 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2001778 2001509 -269 (-0.01%) 1.44%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 55279820 55287170 7350 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 55220343 55213150 -7193 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 56597005 56589849 -7156 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11555665 11554256 -1409 (-0.01%) 0.54%
handshake_session_id_ring_1.3_rsa_chacha_client 30850762 30847102 -3660 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30843715 30840061 -3654 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30942052 30938392 -3660 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30846654 30843006 -3648 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30935005 30931351 -3654 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30937944 30934296 -3648 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31169330 31165670 -3660 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31161981 31158327 -3654 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31240601 31236941 -3660 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31165370 31161722 -3648 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31233231 31229577 -3654 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31236641 31232993 -3648 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 78706913 78715923 9010 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 56543079 56548927 5848 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2004147 2003955 -192 (-0.01%) 1.44%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 78528610 78535559 6949 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 56545637 56549933 4296 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 56594116 56590016 -4100 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 56561884 56565410 3526 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 78468803 78464269 -4534 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 78729154 78724797 -4357 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305221 3305042 -179 (-0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2245904 2245824 -80 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719334 1719278 -56 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333597 2333522 -75 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339246 2339171 -75 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227290 7227105 -185 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229249 7229075 -174 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 55298760 55297500 -1260 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 78705380 78707001 1621 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11125004 11124822 -182 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11130765 11130583 -182 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2910290 2910327 37 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10996861 10996751 -110 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 56593810 56593463 -347 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741721 34741633 -88 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743435 34743387 -48 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92658978 92658943 -35 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58129857 58129838 -19 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58233342 58233324 -18 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92697986 92697958 -28 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58041288 58041271 -17 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58163205 58163188 -17 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92668100 92668074 -26 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58122641 58122626 -15 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58154251 58154236 -15 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58234714 58234700 -14 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92699359 92699341 -18 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58258166 58258156 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92690579 92690565 -14 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92724083 92724069 -14 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46294544 46294538 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46452710 46452716 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80540628 80540620 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80637670 80637676 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46450209 46450212 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80634530 80634526 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46397784 46397782 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46291020 46291019 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46460614 46460613 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80533894 80533895 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80645572 80645573 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80545429 80545429 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46189319 46189319 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46284284 46284284 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.10 ms 1.08 ms -0.02 ms (-1.93%) 4.87%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.34 ms 1.32 ms -0.02 ms (-1.52%) 4.12%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.85 ms 1.82 ms -0.03 ms (-1.52%) 3.30%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.33 ms 1.31 ms -0.02 ms (-1.40%) 8.94%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.53 ms 0.02 ms (1.13%) 1.94%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.66 ms 1.65 ms -0.01 ms (-0.80%) 2.85%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.62 ms 0.01 ms (0.72%) 1.24%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.72 ms 4.74 ms 0.02 ms (0.43%) 4.62%
transfer_no_resume_ring_1.2_rsa_aes 5.83 ms 5.86 ms 0.02 ms (0.42%) 4.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 665.82 µs 668.61 µs 2.79 µs (0.42%) 3.70%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 11.47 ms 11.52 ms 0.04 ms (0.39%) 1.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 10.80 ms 10.84 ms 0.04 ms (0.38%) 1.83%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 669.58 µs 667.28 µs -2.30 µs (-0.34%) 3.55%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 10.83 ms 10.86 ms 0.04 ms (0.34%) 1.51%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 10.60 ms 10.63 ms 0.03 ms (0.33%) 1.37%
transfer_no_resume_ring_1.3_rsa_aes 5.91 ms 5.93 ms 0.02 ms (0.32%) 3.56%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.51 ms 8.54 ms 0.03 ms (0.32%) 2.12%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 11.52 ms 11.56 ms 0.04 ms (0.31%) 1.30%
handshake_no_resume_ring_1.3_ecdsap256_chacha 475.68 µs 477.06 µs 1.38 µs (0.29%) 2.80%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.41 ms 5.43 ms 0.02 ms (0.28%) 3.93%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.41 ms 5.43 ms 0.01 ms (0.27%) 4.39%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 11.27 ms 11.30 ms 0.03 ms (0.26%) 1.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.35 ms 1.36 ms 0.00 ms (0.26%) 1.51%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 11.32 ms 11.35 ms 0.03 ms (0.26%) 1.22%
handshake_no_resume_ring_1.3_rsa_aes 963.80 µs 966.10 µs 2.30 µs (0.24%) 1.12%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 10.64 ms 10.67 ms 0.03 ms (0.24%) 1.87%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.57 ms 3.58 ms 0.01 ms (0.21%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.86 ms 13.89 ms 0.03 ms (0.18%) 1.81%
handshake_tickets_ring_1.3_rsa_aes 6.12 ms 6.11 ms -0.01 ms (-0.18%) 1.00%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.11 ms 5.11 ms 0.01 ms (0.18%) 5.05%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.07 ms 16.10 ms 0.03 ms (0.18%) 1.27%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.53 ms 5.52 ms -0.01 ms (-0.17%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.18 ms 13.21 ms 0.02 ms (0.17%) 1.72%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.57 ms 3.58 ms 0.01 ms (0.17%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 959.22 µs 960.78 µs 1.56 µs (0.16%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 11.51 ms 11.53 ms 0.02 ms (0.16%) 2.47%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 11.48 ms 11.50 ms 0.02 ms (0.15%) 1.98%
handshake_no_resume_ring_1.3_ecdsap256_aes 478.10 µs 478.80 µs 0.70 µs (0.15%) 2.32%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.39 ms 5.38 ms -0.01 ms (-0.15%) 4.32%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 11.33 ms 11.35 ms 0.02 ms (0.14%) 1.30%
handshake_tickets_ring_1.3_rsa_chacha 6.08 ms 6.07 ms -0.01 ms (-0.14%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.98 ms 12.99 ms 0.02 ms (0.14%) 1.89%
handshake_session_id_ring_1.3_ecdsap256_aes 5.56 ms 5.55 ms -0.01 ms (-0.13%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 11.29 ms 11.30 ms 0.01 ms (0.13%) 1.75%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.60 ms 5.59 ms -0.01 ms (-0.12%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.63 ms 5.63 ms -0.01 ms (-0.12%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.35 ms 1.35 ms 0.00 ms (0.11%) 1.56%
handshake_session_id_ring_1.3_rsa_chacha 6.01 ms 6.00 ms -0.01 ms (-0.10%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 964.52 µs 965.51 µs 0.99 µs (0.10%) 1.34%
handshake_tickets_ring_1.3_ecdsap384_aes 8.73 ms 8.72 ms -0.01 ms (-0.10%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.47 ms 13.48 ms 0.01 ms (0.06%) 1.77%
handshake_session_id_ring_1.3_ecdsap384_aes 8.65 ms 8.65 ms -0.00 ms (-0.05%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.87 ms 13.86 ms -0.00 ms (-0.02%) 1.73%
handshake_session_id_ring_1.3_rsa_aes 6.05 ms 6.05 ms -0.00 ms (-0.02%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.61 ms 8.61 ms 0.00 ms (0.01%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.69 ms 8.69 ms 0.00 ms (0.00%) 1.00%

Additional information

Historical results

Checkout details:

cpu
cpu approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpu
Copy link
Member

cpu commented Apr 20, 2025

@elagergren-spideroak Would you mind rebasing on main?

@djc Did you want to review this or is it good to merge?

@elagergren-spideroak
add clarifying comments
857f9e0 
For rustls#2424

Signed-off-by: Eric Lagergren <elagergren@spideroak.com>
@elagergren-spideroak
clarify some field and parameter identifiers
cc27056 
For rustls#2424

Signed-off-by: Eric Lagergren <elagergren@spideroak.com>
@elagergren-spideroak
remove unused field
a154abd 
Signed-off-by: Eric Lagergren <elagergren@spideroak.com>
@djc
Copy link
Member

djc commented Apr 21, 2025

I'd like to take a look but I suppose I could do followup post-merge if others think this is in a good shape already.

@djc djc enabled auto-merge April 22, 2025 14:16
@djc djc added this pull request to the merge queue Apr 22, 2025
Merged via the queue into rustls:main with commit df8c684 Apr 22, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elagergren-spideroak @cpu @djc @ctz