Skip to content

Add cargo deny check in CI #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

Add cargo deny check in CI #2412

merged 1 commit into from
Apr 3, 2025

Conversation

djc
Copy link
Member

@djc djc commented Apr 3, 2025

No description provided.

@djc djc requested review from cpu and ctz April 3, 2025 07:59
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Apr 3, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10687958 10734781 46823 (0.44%) 1.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1144997 1149222 4225 (0.37%) 1.45%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10471987 10437281 -34706 (-0.33%) 0.77%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10767714 10734679 -33035 (-0.31%) 0.72%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3094581 3101729 7148 (0.23%) 0.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8332788 8327086 -5702 (-0.07%) 0.86%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303918 3302104 -1814 (-0.05%) 0.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8312809 8315970 3161 (0.04%) 0.69%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2061462 2061746 284 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3099778 3099374 -404 (-0.01%) 0.48%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305235 3305092 -143 (-0.00%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2064731 2064799 68 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1147360 1147345 -15 (-0.00%) 1.46%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297179 1297166 -13 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1927546 1927531 -15 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28749562 28749762 200 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27807469 27807642 173 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28747089 28746912 -177 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30223674 30223854 180 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27871366 27871528 162 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30266434 30266268 -166 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28231249 28231392 143 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27864423 27864550 127 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30263825 30263728 -97 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27812004 27812086 82 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28749364 28749444 80 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28827584 28827661 77 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719366 1719370 4 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295984 1295987 3 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27866830 27866894 64 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28208622 28208561 -61 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30223754 30223815 61 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28201690 28201744 54 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30221149 30221201 52 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28825150 28825107 -43 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28827719 28827679 -40 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28204624 28204585 -39 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28234221 28234256 35 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28238315 28238349 34 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30266214 30266197 -17 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741790 34741775 -15 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227617 7227614 -3 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27805191 27805199 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58129862 58129852 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58233821 58233813 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46294745 46294739 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92724267 92724255 -12 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80537605 80537615 10 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58041298 58041305 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80549140 80549149 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46454109 46454104 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46461091 46461096 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58258345 58258339 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92668101 92668109 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58235186 58235181 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58122643 58122639 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58163209 58163205 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46193039 46193042 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46288004 46288007 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46298266 46298269 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46401505 46401502 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58154252 58154255 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46456434 46456436 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80544345 80544348 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80646049 80646052 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92658979 92658977 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80638433 80638434 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92690576 92690575 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92699194 92699195 1 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4768952 4768952 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31242041 31242041 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80641399 80641399 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31234677 31234677 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30848106 30848106 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4583713 4583713 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31170770 31170770 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1934275 1934275 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31998750 31998750 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32117830 32117830 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32120329 32120329 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31166822 31166822 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10996937 10996937 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229576 7229576 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30943492 30943492 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4232172 4232172 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30845161 30845161 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32120400 32120400 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11125331 11125331 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31238093 31238093 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5018812 5018812 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333652 2333652 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31998679 31998679 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2245960 2245960 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4320382 4320382 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339301 2339301 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31996180 31996180 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30852202 30852202 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32564500 32564500 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3872595 3872595 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30936451 30936451 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32567026 32567026 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32567037 32567037 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3889551 3889551 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11131092 11131092 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4304288 4304288 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32465116 32465116 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32462545 32462545 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743504 34743504 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31163427 31163427 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30939396 30939396 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32465082 32465082 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92697819 92697819 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.01 ms 5.08 ms 0.07 ms (1.47%) 4.66%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.44 ms 4.50 ms 0.07 ms (1.47%) 4.48%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.08 ms 5.15 ms 0.07 ms (1.36%) 4.23%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.13 ms 5.20 ms 0.06 ms (1.20%) 3.79%
transfer_no_resume_ring_1.2_rsa_aes 5.78 ms 5.85 ms 0.07 ms (1.18%) 4.29%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.35 ms 5.41 ms 0.06 ms (1.12%) 4.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 450.56 µs 455.44 µs 4.88 µs (1.08%) 2.89%
transfer_no_resume_ring_1.3_rsa_aes 5.84 ms 5.90 ms 0.06 ms (0.98%) 3.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 453.16 µs 457.54 µs 4.38 µs (0.97%) 3.30%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.47 ms 8.53 ms 0.06 ms (0.70%) 2.57%
handshake_no_resume_ring_1.3_ecdsap256_chacha 472.48 µs 475.65 µs 3.17 µs (0.67%) 3.13%
handshake_no_resume_ring_1.3_ecdsap256_aes 473.85 µs 476.92 µs 3.07 µs (0.65%) 3.21%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.91 ms 12.98 ms 0.07 ms (0.51%) 1.74%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.13 ms 1.14 ms 0.01 ms (0.50%) 1.13%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.08 ms 1.09 ms 0.01 ms (0.47%) 2.61%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.60 ms 13.66 ms 0.06 ms (0.46%) 1.70%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.91 ms 12.97 ms 0.06 ms (0.45%) 1.74%
transfer_no_resume_ring_1.3_rsa_chacha 13.41 ms 13.47 ms 0.06 ms (0.44%) 1.68%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.03 ms 16.10 ms 0.07 ms (0.41%) 1.35%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms 0.00 ms (0.41%) 1.93%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.57 ms 13.62 ms 0.05 ms (0.38%) 1.40%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.50 ms 4.51 ms 0.02 ms (0.36%) 1.10%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.61 ms 0.01 ms (0.35%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.14 ms 5.15 ms 0.02 ms (0.35%) 1.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.14 ms 1.15 ms 0.00 ms (0.33%) 1.13%
handshake_no_resume_ring_1.3_rsa_chacha 964.45 µs 967.52 µs 3.06 µs (0.32%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 960.24 µs 963.23 µs 2.99 µs (0.31%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 963.11 µs 966.09 µs 2.98 µs (0.31%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.08 ms 1.09 ms 0.00 ms (0.30%) 2.19%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.19 ms 5.20 ms 0.01 ms (0.28%) 1.29%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.94 ms 4.96 ms 0.01 ms (0.27%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.46 ms 4.48 ms 0.01 ms (0.26%) 1.08%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.27 ms 4.27 ms 0.01 ms (0.22%) 1.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.30 ms 4.31 ms 0.01 ms (0.21%) 1.17%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.79 ms 1.79 ms 0.00 ms (0.20%) 1.88%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.12 ms 5.13 ms 0.01 ms (0.17%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.59 ms 3.60 ms 0.01 ms (0.15%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.15 ms 5.15 ms 0.01 ms (0.15%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.60 ms 0.01 ms (0.14%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.94 ms 4.95 ms 0.01 ms (0.13%) 1.04%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.92 ms 4.92 ms 0.01 ms (0.11%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.02 ms 6.01 ms -0.01 ms (-0.11%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.61 ms 5.62 ms 0.00 ms (0.08%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.64 ms 8.64 ms -0.01 ms (-0.07%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.59 ms 5.58 ms -0.00 ms (-0.06%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.71 ms 8.70 ms -0.00 ms (-0.05%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms 0.00 ms (0.05%) 1.16%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 4.99 ms 4.99 ms 0.00 ms (0.05%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.05 ms 6.05 ms 0.00 ms (0.04%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.11 ms 6.11 ms -0.00 ms (-0.04%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.08 ms 6.08 ms -0.00 ms (-0.03%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.67 ms 8.67 ms -0.00 ms (-0.03%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.61 ms 1.61 ms 0.00 ms (0.01%) 1.26%
handshake_session_id_ring_1.3_ecdsap256_aes 5.55 ms 5.56 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.52 ms 5.52 ms -0.00 ms (-0.01%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.74 ms 8.74 ms 0.00 ms (0.00%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Apr 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (66e4c27) to head (35d09ca).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2412      +/-   ##
==========================================
- Coverage   96.16%   96.00%   -0.16%     
==========================================
  Files          94       94              
  Lines       22815    22525     -290     
==========================================
- Hits        21939    21626     -313     
- Misses        876      899      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cpu
cpu approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod the two CI fails. Thanks!

@djc djc enabled auto-merge April 3, 2025 15:00
@djc djc added this pull request to the merge queue Apr 3, 2025
Merged via the queue into main with commit 75ab55b Apr 3, 2025
63 of 64 checks passed
@djc djc deleted the deny branch April 3, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @ctz