Skip to content

Add warning about server-side cross-config resumption #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2025
Merged

Add warning about server-side cross-config resumption #2381

merged 1 commit into from
Mar 15, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented Mar 14, 2025

No description provided.

@ctz ctz closed this Mar 14, 2025
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Mar 14, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8342368 8307097 -35271 (-0.42%) 1.09%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1145003 1149177 4174 (0.36%) 1.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1151491 1147294 -4197 (-0.36%) 1.54%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10486984 10469638 -17346 (-0.17%) 0.93%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3097020 3102125 5105 (0.16%) 0.53%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10713474 10698410 -15064 (-0.14%) 1.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3104085 3099788 -4297 (-0.14%) 0.54%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10727534 10715969 -11565 (-0.11%) 1.82%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305494 3303308 -2186 (-0.07%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8302919 8304620 1701 (0.02%) 1.06%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2064493 2064762 269 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2061427 2061632 205 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1927700 1927555 -145 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304038 3304150 112 (0.00%) 0.25%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297306 1297319 13 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28747931 28747708 -223 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27805512 27805302 -210 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30269075 30269284 209 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27871681 27871519 -162 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28828497 28828649 152 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28231704 28231835 131 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28828800 28828676 -124 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30224014 30224136 122 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27812147 27812256 109 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1296121 1296126 5 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28750422 28750314 -108 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27807776 27807672 -104 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28238816 28238713 -103 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27867081 27867166 85 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28208922 28209008 86 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28234726 28234812 86 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30226663 30226572 -91 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30266668 30266578 -90 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28826155 28826093 -62 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28204927 28204980 53 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28750395 28750341 -54 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28201930 28201979 49 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30269115 30269065 -50 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27864670 27864701 31 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229724 7229716 -8 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743681 34743656 -25 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46292212 46292202 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46461268 46461275 7 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30226438 30226442 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46298938 46298943 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46302455 46302459 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92701315 92701323 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80553341 80553346 5 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58022345 58022342 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58127835 58127838 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80541807 80541811 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92657585 92657581 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92666720 92666724 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92694988 92694992 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80650250 80650253 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58164113 58164111 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58231622 58231624 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80548540 80548538 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80642632 80642630 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46198576 46198577 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92697227 92697225 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407679 46407678 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46458942 46458941 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58120626 58120627 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58236036 58236037 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92668573 92668572 -1 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32124769 32124769 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30940531 30940531 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 32003220 32003220 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30947572 30947572 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246009 2246009 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31170962 31170962 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134460 11134460 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4233042 4233042 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4770422 4770422 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5020822 5020822 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465935 46465935 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333733 2333733 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 32000650 32000650 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30856342 30856342 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000256 11000256 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 32003149 32003149 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741943 34741943 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32568970 32568970 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31167567 31167567 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30943476 30943476 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80645595 80645595 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30849301 30849301 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3873525 3873525 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58233860 58233860 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32571507 32571507 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31246121 31246121 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4585153 4585153 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31242173 31242173 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339383 2339383 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227756 7227756 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3890211 3890211 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32467045 32467045 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1934301 1934301 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4305728 4305728 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719438 1719438 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58131604 58131604 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32469582 32469582 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32571496 32571496 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32124840 32124840 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31238757 31238757 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30852246 30852246 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32469616 32469616 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4321822 4321822 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31174910 31174910 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32122270 32122270 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128698 11128698 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.11 ms 1.12 ms 0.01 ms (0.76%) 2.22%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.49 ms 4.51 ms 0.02 ms (0.53%) 6.34%
transfer_no_resume_ring_1.2_rsa_aes 5.86 ms 5.89 ms 0.03 ms (0.47%) 3.94%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.45 ms 5.48 ms 0.03 ms (0.46%) 4.95%
transfer_no_resume_ring_1.3_rsa_aes 5.95 ms 5.97 ms 0.03 ms (0.46%) 4.31%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.64 ms 1.64 ms -0.01 ms (-0.44%) 2.39%
handshake_session_id_ring_1.2_rsa_aes 1.58 ms 1.57 ms -0.01 ms (-0.43%) 1.25%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.09 ms 5.11 ms 0.02 ms (0.41%) 5.14%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.16 ms 5.18 ms 0.02 ms (0.40%) 4.82%
handshake_tickets_ring_1.2_rsa_aes 1.66 ms 1.66 ms -0.01 ms (-0.33%) 1.45%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.57 ms 8.60 ms 0.03 ms (0.31%) 2.92%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.09 ms -0.00 ms (-0.30%) 4.22%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.19 ms 5.20 ms 0.01 ms (0.28%) 5.57%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.82 ms 1.81 ms -0.00 ms (-0.27%) 2.11%
transfer_no_resume_ring_1.3_rsa_chacha 13.45 ms 13.48 ms 0.03 ms (0.23%) 2.05%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.63 ms 13.66 ms 0.03 ms (0.23%) 1.77%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.07 ms 16.11 ms 0.03 ms (0.22%) 1.51%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.64 ms 13.67 ms 0.03 ms (0.21%) 1.82%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.12 ms 0.00 ms (0.20%) 1.29%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.16 ms 5.17 ms 0.01 ms (0.20%) 1.29%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.96 ms 12.98 ms 0.03 ms (0.20%) 2.01%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.95 ms 12.98 ms 0.02 ms (0.19%) 2.18%
handshake_session_id_ring_1.3_ecdsap256_aes 5.88 ms 5.87 ms -0.01 ms (-0.15%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.79 ms 5.78 ms -0.01 ms (-0.12%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 453.56 µs 454.12 µs 0.56 µs (0.12%) 3.64%
handshake_session_id_ring_1.3_rsa_aes 6.38 ms 6.37 ms -0.01 ms (-0.12%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 473.96 µs 474.52 µs 0.56 µs (0.12%) 3.72%
handshake_no_resume_ring_1.3_rsa_aes 975.34 µs 976.47 µs 1.12 µs (0.12%) 1.15%
handshake_tickets_ring_1.3_rsa_aes 6.29 ms 6.28 ms -0.01 ms (-0.11%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.99 ms 8.98 ms -0.01 ms (-0.10%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 964.89 µs 965.85 µs 0.97 µs (0.10%) 1.32%
handshake_no_resume_ring_1.3_rsa_chacha 975.02 µs 975.93 µs 0.91 µs (0.09%) 1.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 4.99 ms 4.99 ms -0.00 ms (-0.09%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.19 ms 5.18 ms -0.00 ms (-0.09%) 1.29%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.30 ms 4.30 ms -0.00 ms (-0.09%) 1.50%
handshake_no_resume_ring_1.3_ecdsap256_aes 480.62 µs 481.03 µs 0.41 µs (0.09%) 3.25%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.62 ms 8.62 ms -0.01 ms (-0.06%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.59 ms -0.00 ms (-0.06%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.51 ms 5.51 ms -0.00 ms (-0.06%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.97 ms 4.98 ms 0.00 ms (0.05%) 1.27%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.95 ms 4.96 ms 0.00 ms (0.05%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.00 ms 6.00 ms -0.00 ms (-0.05%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.68 ms 8.68 ms -0.00 ms (-0.04%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.15 ms 1.15 ms 0.00 ms (0.04%) 1.43%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.94 ms 4.94 ms -0.00 ms (-0.03%) 1.08%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.47 ms 4.47 ms -0.00 ms (-0.03%) 1.38%
handshake_tickets_ring_1.3_ecdsap384_aes 8.91 ms 8.90 ms -0.00 ms (-0.03%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.57 ms 5.57 ms 0.00 ms (0.03%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 456.70 µs 456.57 µs -0.14 µs (-0.03%) 3.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.14 ms 1.14 ms 0.00 ms (0.03%) 1.05%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.15 ms 5.15 ms -0.00 ms (-0.03%) 1.29%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.02%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.27 ms 4.27 ms 0.00 ms (0.02%) 1.98%
handshake_tickets_ring_1.3_rsa_chacha 6.06 ms 6.06 ms -0.00 ms (-0.01%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.50 ms 4.50 ms 0.00 ms (0.00%) 1.60%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.17 ms 5.17 ms -0.00 ms (-0.00%) 1.41%

Additional information

Historical results

Checkout details:

@ctz ctz reopened this Mar 14, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (1c318bc) to head (70002b0).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2381   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          94       94           
  Lines       22814    22814           
=======================================
  Hits        21939    21939           
  Misses        875      875

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cpu
cpu approved these changes Mar 14, 2025
View reviewed changes
@ctz ctz force-pushed the jbp-server-resume-warning branch from 26d015a to ae6e2b5 Compare March 14, 2025 15:03
djc
djc approved these changes Mar 15, 2025
View reviewed changes
@ctz ctz force-pushed the jbp-server-resume-warning branch from ae6e2b5 to 70002b0 Compare March 15, 2025 12:31
@ctz ctz enabled auto-merge March 15, 2025 12:32
@ctz ctz added this pull request to the merge queue Mar 15, 2025
Merged via the queue into main with commit 70e2b1c Mar 15, 2025
62 checks passed
@ctz ctz deleted the jbp-server-resume-warning branch March 15, 2025 12:57
@cpu cpu mentioned this pull request Mar 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu