Skip to content

Upgrade to hickory-resolver 0.25 #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

Upgrade to hickory-resolver 0.25 #2387

merged 1 commit into from
Mar 20, 2025

Conversation

djc
Copy link
Member

@djc djc commented Mar 20, 2025

No description provided.

@djc djc requested review from cpu and ctz March 20, 2025 10:49
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Mar 20, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10427554 10494164 66610 (0.64%) 0.86%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10748781 10680305 -68476 (-0.64%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1145007 1149177 4170 (0.36%) 1.58%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1151472 1147298 -4174 (-0.36%) 1.48%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3104711 3095843 -8868 (-0.29%) 0.54%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3094866 3102287 7421 (0.24%) 0.49%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10752187 10726856 -25331 (-0.24%) 1.88%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8317821 8336154 18333 (0.22%) 0.73%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3304114 3301840 -2274 (-0.07%) 0.24%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305264 3303203 -2061 (-0.06%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8324100 8328649 4549 (0.05%) 0.88%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719528 1719434 -94 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2061708 2061625 -83 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27808175 27807745 -430 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28750461 28750676 215 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30223916 30224098 182 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30266559 30266725 166 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28209108 28208964 -144 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30269316 30269163 -153 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28828827 28828684 -143 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30269273 30269126 -147 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27864751 27864649 -102 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28234755 28234657 -98 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28828587 28828684 97 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30226477 30226573 96 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28747807 28747887 80 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28238712 28238637 -75 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28750280 28750209 -71 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27867163 27867098 -65 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28826209 28826143 -66 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27812174 27812114 -60 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1927559 1927555 -4 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1934305 1934301 -4 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2064755 2064751 -4 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28204970 28204916 -54 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1296121 1296123 2 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28231693 28231730 37 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30226477 30226440 -37 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27871669 27871645 -24 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27805257 27805278 21 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28201980 28201963 -17 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741960 34741945 -15 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227754 7227756 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46294748 46294739 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46461737 46461729 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58258991 58258982 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92659617 92659607 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92691218 92691209 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80549147 80549140 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46193039 46193043 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46298262 46298258 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46402143 46402147 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46454748 46454744 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58122640 58122645 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92724263 92724256 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58129857 58129854 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58235824 58235821 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80641397 80641400 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80638431 80638429 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80646055 80646057 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46288005 46288004 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92697826 92697828 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46457073 46457072 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58041298 58041299 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58163845 58163844 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58234452 58234453 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80537612 80537613 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80544347 80544348 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92668743 92668742 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92699189 92699190 1 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32469582 32469582 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4585153 4585153 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32469616 32469616 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32568970 32568970 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32571496 32571496 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4321822 4321822 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5020822 5020822 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297306 1297306 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 32003220 32003220 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30849301 30849301 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4305728 4305728 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30943476 30943476 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31174910 31174910 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3890211 3890211 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333733 2333733 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32124840 32124840 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30852246 30852246 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4233042 4233042 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4770422 4770422 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32467045 32467045 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 32000650 32000650 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3873525 3873525 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31170962 31170962 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000242 11000242 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32122270 32122270 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31246121 31246121 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32124769 32124769 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 32003149 32003149 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31238757 31238757 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30947572 30947572 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134446 11134446 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2246009 2246009 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30940531 30940531 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58154252 58154252 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339383 2339383 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128684 11128684 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30856342 30856342 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31167567 31167567 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32571507 32571507 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229724 7229724 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743685 34743685 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31242173 31242173 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_ring_1.2_rsa_aes 1.68 ms 1.66 ms -0.02 ms (-1.29%) 1.49%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.84 ms 1.82 ms -0.02 ms (-1.09%) 1.99%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.65 ms 1.63 ms -0.02 ms (-0.98%) 2.37%
handshake_session_id_ring_1.2_rsa_aes 1.59 ms 1.57 ms -0.01 ms (-0.93%) 1.31%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.35 ms 4.31 ms -0.04 ms (-0.92%) 1.46%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.32 ms 4.28 ms -0.04 ms (-0.86%) 1.77%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.99 ms 4.95 ms -0.04 ms (-0.84%) 1.17%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.04 ms 5.00 ms -0.04 ms (-0.82%) 1.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.51 ms 4.48 ms -0.04 ms (-0.79%) 1.60%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.99 ms 4.95 ms -0.04 ms (-0.77%) 1.10%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.02 ms 4.98 ms -0.04 ms (-0.77%) 1.21%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.19 ms 5.16 ms -0.04 ms (-0.76%) 1.31%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.54 ms 4.51 ms -0.03 ms (-0.75%) 1.53%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.24 ms 5.20 ms -0.04 ms (-0.68%) 1.48%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.20 ms 5.16 ms -0.04 ms (-0.68%) 1.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.21 ms 5.17 ms -0.03 ms (-0.62%) 1.43%
handshake_session_id_ring_1.3_ecdsap256_aes 5.92 ms 5.90 ms -0.02 ms (-0.35%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.83 ms 5.81 ms -0.02 ms (-0.33%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.33 ms 6.31 ms -0.02 ms (-0.32%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.42 ms 6.40 ms -0.02 ms (-0.32%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.62 ms 5.60 ms -0.02 ms (-0.31%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.56 ms 5.54 ms -0.02 ms (-0.29%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.03 ms 9.01 ms -0.02 ms (-0.26%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.11 ms 6.10 ms -0.02 ms (-0.25%) 1.00%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.16 ms 5.15 ms -0.01 ms (-0.25%) 5.01%
handshake_session_id_ring_1.3_rsa_chacha 6.05 ms 6.03 ms -0.02 ms (-0.25%) 1.00%
transfer_no_resume_ring_1.2_rsa_aes 5.95 ms 5.94 ms -0.01 ms (-0.24%) 3.99%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.67 ms 8.65 ms -0.02 ms (-0.23%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.95 ms 8.93 ms -0.02 ms (-0.18%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.74 ms 8.72 ms -0.02 ms (-0.18%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.12 ms 1.12 ms 0.00 ms (0.14%) 2.39%
handshake_no_resume_ring_1.3_rsa_chacha 979.95 µs 978.55 µs -1.41 µs (-0.14%) 1.24%
handshake_no_resume_ring_1.2_rsa_aes 969.24 µs 967.94 µs -1.30 µs (-0.13%) 1.33%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.12 ms 0.00 ms (0.11%) 1.83%
transfer_no_resume_ring_1.3_rsa_aes 6.02 ms 6.03 ms 0.01 ms (0.11%) 4.50%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.26 ms 5.26 ms -0.01 ms (-0.11%) 5.75%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 458.21 µs 458.70 µs 0.49 µs (0.11%) 3.54%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.56 ms 4.56 ms -0.00 ms (-0.07%) 6.04%
handshake_no_resume_ring_1.3_ecdsap256_chacha 478.04 µs 477.71 µs -0.32 µs (-0.07%) 3.39%
handshake_no_resume_ring_1.3_ecdsap256_aes 484.80 µs 485.12 µs 0.32 µs (0.07%) 3.31%
handshake_no_resume_ring_1.3_rsa_aes 979.75 µs 979.12 µs -0.63 µs (-0.06%) 1.19%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.23 ms 5.23 ms -0.00 ms (-0.06%) 4.88%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 460.28 µs 460.56 µs 0.28 µs (0.06%) 3.84%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.53 ms 5.53 ms -0.00 ms (-0.05%) 5.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.15 ms 1.15 ms -0.00 ms (-0.04%) 1.43%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.65 ms 8.65 ms 0.00 ms (0.04%) 3.18%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.71 ms 13.70 ms -0.01 ms (-0.04%) 1.77%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.14 ms 1.15 ms 0.00 ms (0.04%) 1.11%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.03 ms 13.04 ms 0.00 ms (0.03%) 2.06%
transfer_no_resume_ring_1.3_rsa_chacha 13.53 ms 13.53 ms 0.00 ms (0.03%) 1.79%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.08 ms 1.08 ms -0.00 ms (-0.02%) 3.72%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms -0.00 ms (-0.02%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms -0.00 ms (-0.02%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.73 ms 13.73 ms 0.00 ms (0.01%) 1.84%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.04 ms 13.04 ms 0.00 ms (0.01%) 1.99%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.16 ms 16.16 ms 0.00 ms (0.00%) 1.58%

Additional information

Historical results

Checkout details:

@djc djc force-pushed the hickory-0.25 branch 2 times, most recently from 323a915 to c1f5cc3 Compare March 20, 2025 11:38
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (1e2b4f3) to head (f5c01ad).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2387   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          94       94           
  Lines       22815    22815           
=======================================
  Hits        21939    21939           
  Misses        876      876

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cpu
cpu approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I will kick the daily tasks job when I'm at a real keyboard to double check the ech example still does it's thing

@djc djc enabled auto-merge March 20, 2025 12:00
@djc djc added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit e889744 Mar 20, 2025
62 checks passed
@djc djc deleted the hickory-0.25 branch March 20, 2025 12:19
@cpu
Copy link
Member

cpu commented Mar 20, 2025

I will kick the daily tasks job when I'm at a real keyboard

All good (minus an unrelated powerset bug, will open an issue for that): https://github.com/rustls/rustls/actions/runs/13969447498/job/39107384691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @ctz