Skip to content

fuzz/Cargo.lock: take semver-compatible updates #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

fuzz/Cargo.lock: take semver-compatible updates #2372

merged 1 commit into from
Mar 10, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented Mar 10, 2025

Notably this removes a further ring 0.17.8 usage.

@ctz
fuzz/Cargo.lock: take semver-compatible updates
7d25de6 
Notably this removes a further ring 0.17.8 usage.
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Mar 10, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10745662 10787350 41688 (0.39%) 2.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1144883 1149089 4206 (0.37%) 1.56%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1151399 1147206 -4193 (-0.36%) 1.58%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8326579 8297659 -28920 (-0.35%) 1.56%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3094665 3102036 7371 (0.24%) 0.59%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10467448 10486893 19445 (0.19%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10758440 10738864 -19576 (-0.18%) 1.18%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3301881 3304079 2198 (0.07%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3101953 3099903 -2050 (-0.07%) 0.58%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2064401 2064666 265 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2061350 2061559 209 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8296806 8296420 -386 (-0.00%) 1.37%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305229 3305305 76 (0.00%) 0.30%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719394 1719379 -15 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28749405 28749197 -208 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28214514 28214712 198 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28825065 28824897 -168 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30265101 30264950 -151 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30219933 30220059 126 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28827345 28827234 -111 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30264948 30264841 -107 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30262440 30262537 97 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27788066 27788152 86 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28746441 28746528 87 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28187809 28187732 -77 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27854420 27854352 -68 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1934382 1934378 -4 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28221359 28221413 54 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30222383 30222328 -55 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1296022 1296020 -2 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27847539 27847577 38 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229613 7229621 8 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28827456 28827484 28 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28217575 28217549 -26 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28749006 28748985 -21 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743596 34743621 25 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28184756 28184736 -20 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27794994 27794976 -18 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27790647 27790664 17 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30222291 30222273 -18 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741866 34741883 17 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227650 7227653 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46302456 46302466 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58147890 58147879 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58038545 58038535 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46292208 46292201 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46298936 46298942 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58237274 58237267 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46198581 46198576 -5 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27849995 27849992 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80541809 80541802 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673944 92673936 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407687 46407683 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465924 46465928 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58136976 58136981 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92683013 92683006 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92706869 92706875 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80548543 80548547 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80642622 80642626 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46458946 46458944 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80553335 80553338 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58180299 58180297 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80650254 80650252 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92700635 92700633 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58144124 58144123 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58241587 58241588 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92702868 92702867 -1 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 32001529 32001529 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3870895 3870895 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31225139 31225139 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30923563 30923563 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58239507 58239507 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32567146 32567146 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333813 2333813 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3872175 3872175 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4302072 4302072 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5019472 5019472 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31229141 31229141 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31999030 31999030 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31221863 31221863 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46461269 46461269 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30930553 30930553 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128600 11128600 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32120650 32120650 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32123149 32123149 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31153928 31153928 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4304018 4304018 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339463 2339463 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32564590 32564590 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80645597 80645597 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2245908 2245908 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32567127 32567127 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30835270 30835270 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30839323 30839323 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1927636 1927636 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4564994 4564994 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684846 92684846 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28191574 28191574 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 32001630 32001630 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30832333 30832333 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32465266 32465266 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32465202 32465202 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297205 1297205 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000205 11000205 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31157930 31157930 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4212889 4212889 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31150673 31150673 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4768742 4768742 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32462665 32462665 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32123250 32123250 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134362 11134362 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30926500 30926500 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.11 ms 1.12 ms 0.01 ms (0.65%) 2.37%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.21 ms 5.23 ms 0.02 ms (0.48%) 1.31%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.52 ms 4.53 ms 0.02 ms (0.39%) 1.59%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.32 ms 4.34 ms 0.02 ms (0.39%) 1.84%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.23 ms 5.25 ms 0.02 ms (0.36%) 1.25%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.06 ms 5.04 ms -0.02 ms (-0.35%) 5.88%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.22 ms 5.24 ms 0.02 ms (0.34%) 1.37%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.35 ms 4.36 ms 0.01 ms (0.32%) 2.26%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.03 ms 5.05 ms 0.02 ms (0.32%) 1.72%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.00 ms 5.01 ms 0.02 ms (0.32%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.82 ms 1.82 ms 0.01 ms (0.31%) 2.80%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.55 ms 4.56 ms 0.01 ms (0.31%) 1.45%
transfer_no_resume_ring_1.2_rsa_aes 5.84 ms 5.82 ms -0.02 ms (-0.30%) 4.43%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.20 ms 5.21 ms 0.02 ms (0.29%) 1.57%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.12 ms 0.00 ms (0.29%) 1.52%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.99 ms 5.00 ms 0.01 ms (0.26%) 1.58%
handshake_tickets_ring_1.3_rsa_chacha 6.10 ms 6.08 ms -0.02 ms (-0.25%) 1.04%
handshake_session_id_ring_1.3_rsa_chacha 6.04 ms 6.03 ms -0.01 ms (-0.24%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.60 ms 5.59 ms -0.01 ms (-0.23%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.03 ms 5.04 ms 0.01 ms (0.22%) 1.48%
handshake_tickets_ring_1.3_rsa_aes 6.32 ms 6.31 ms -0.01 ms (-0.21%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.55 ms 5.54 ms -0.01 ms (-0.21%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 451.19 µs 452.14 µs 0.94 µs (0.21%) 5.20%
handshake_tickets_ring_1.3_ecdsap256_aes 5.82 ms 5.81 ms -0.01 ms (-0.19%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.72 ms 8.71 ms -0.02 ms (-0.19%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 471.66 µs 472.52 µs 0.86 µs (0.18%) 4.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 453.59 µs 454.38 µs 0.79 µs (0.18%) 4.12%
handshake_session_id_ring_1.3_rsa_aes 6.41 ms 6.40 ms -0.01 ms (-0.17%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.57 ms 1.57 ms -0.00 ms (-0.17%) 1.28%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.66 ms 8.65 ms -0.01 ms (-0.15%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.91 ms 5.90 ms -0.01 ms (-0.14%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.13 ms 1.13 ms 0.00 ms (0.14%) 1.22%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.65 ms 1.65 ms 0.00 ms (0.14%) 2.22%
handshake_tickets_ring_1.2_rsa_aes 1.65 ms 1.65 ms -0.00 ms (-0.13%) 1.88%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.14 ms 5.14 ms -0.01 ms (-0.11%) 6.33%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.12 ms 5.11 ms -0.01 ms (-0.10%) 5.61%
handshake_tickets_ring_1.3_ecdsap384_aes 8.93 ms 8.93 ms -0.01 ms (-0.10%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 973.38 µs 974.31 µs 0.93 µs (0.10%) 2.08%
handshake_no_resume_ring_1.2_rsa_aes 963.17 µs 962.37 µs -0.79 µs (-0.08%) 1.96%
handshake_session_id_ring_1.3_ecdsap384_aes 9.02 ms 9.01 ms -0.01 ms (-0.08%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.05 ms 16.04 ms -0.01 ms (-0.06%) 1.73%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.45 ms 4.44 ms -0.00 ms (-0.05%) 7.05%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.05%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.42 ms 13.41 ms -0.01 ms (-0.05%) 1.92%
transfer_no_resume_ring_1.3_rsa_aes 5.91 ms 5.91 ms -0.00 ms (-0.04%) 5.32%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.59 ms -0.00 ms (-0.04%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.60 ms 13.60 ms -0.00 ms (-0.03%) 1.97%
handshake_no_resume_ring_1.3_rsa_aes 974.15 µs 973.87 µs -0.28 µs (-0.03%) 2.01%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.54 ms 8.53 ms -0.00 ms (-0.03%) 3.38%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.14 ms 1.14 ms -0.00 ms (-0.01%) 1.78%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.09 ms -0.00 ms (-0.01%) 4.12%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.92 ms 12.92 ms 0.00 ms (0.01%) 2.40%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.60 ms 13.61 ms 0.00 ms (0.00%) 2.01%
handshake_no_resume_ring_1.3_ecdsap256_aes 478.89 µs 478.87 µs -0.01 µs (-0.00%) 4.01%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.92 ms 12.92 ms -0.00 ms (-0.00%) 2.19%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.42 ms 5.41 ms -0.00 ms (-0.00%) 5.40%

Additional information

Historical results

Checkout details:

@ctz ctz enabled auto-merge March 10, 2025 09:38
@codecov Codecov
Copy link

codecov bot commented Mar 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (5860d10) to head (7d25de6).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2372   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files         103      103           
  Lines       24551    24551           
=======================================
  Hits        23299    23299           
  Misses       1252     1252

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz ctz added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit 41f186d Mar 10, 2025
62 checks passed
@ctz ctz deleted the jbp-fuzz-semver-updates branch March 10, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctz @djc