Skip to content

Refactor: prefer to take reference on match scrutinee #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

Refactor: prefer to take reference on match scrutinee #2379

merged 1 commit into from
Mar 13, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented Mar 13, 2025

This makes everything take advantage of match ergonomics.

(After this, there are no remaining ref uses in this repo.)

@ctz
Refactor: prefer to take reference on match scrutinee
ed475d9 
This makes everything take advantage of match ergonomics.
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Mar 13, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10422377 10467849 45472 (0.44%) 0.95%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10724467 10765547 41080 (0.38%) 2.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1149024 1145007 -4017 (-0.35%) 1.58%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8308096 8288645 -19451 (-0.23%) 1.50%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8299451 8315980 16529 (0.20%) 1.36%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10726856 10708436 -18420 (-0.17%) 1.22%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3896601 3890211 -6390 (-0.16%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4239222 4233042 -6180 (-0.15%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4327852 4321822 -6030 (-0.14%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4590973 4585153 -5820 (-0.13%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3868725 3873525 4800 (0.12%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4301258 4305728 4470 (0.10%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5016022 5020822 4800 (0.10%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4765952 4770422 4470 (0.09%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3100075 3097252 -2823 (-0.09%) 0.75%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3099297 3097332 -1965 (-0.06%) 0.57%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27822067 27812170 -9897 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27817776 27807910 -9866 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27815127 27805274 -9853 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27877019 27867215 -9804 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28244566 28234644 -9922 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28218762 28208852 -9910 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28248572 28238663 -9909 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27874529 27864776 -9753 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27881408 27871691 -9717 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28211861 28202063 -9798 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28214753 28204991 -9762 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28241587 28231850 -9737 (-0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30862056 30852246 -9810 (-0.03%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30866152 30856342 -9810 (-0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30859107 30849301 -9806 (-0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30953286 30943476 -9810 (-0.03%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30957382 30947572 -9810 (-0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30950337 30940531 -9806 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31180772 31170962 -9810 (-0.03%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31184720 31174910 -9810 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31177373 31167567 -9806 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31251983 31242173 -9810 (-0.03%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31255931 31246121 -9810 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31248563 31238757 -9806 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30216416 30223966 7550 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28740937 28748063 7126 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30259177 30266613 7436 (0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32459155 32467045 7890 (0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32561230 32568970 7740 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28819334 28826167 6833 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30219267 30226418 7151 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30262133 30269209 7076 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30262169 30269202 7033 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28743996 28750598 6602 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30219528 30226468 6940 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28743764 28750322 6558 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32462236 32469616 7380 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32462232 32469582 7350 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32564266 32571496 7230 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28822228 28828608 6380 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28822470 28828850 6380 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32564307 32571507 7200 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31993720 32000650 6930 (0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32115490 32122270 6780 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31996759 32003149 6390 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31996830 32003220 6390 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32118529 32124769 6240 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32118600 32124840 6240 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1147090 1147298 208 (0.02%) 1.54%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295930 1296126 196 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2064471 2064762 291 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297118 1297296 178 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2061516 2061715 199 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1927419 1927574 155 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1934150 1934305 155 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333578 2333733 155 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339228 2339383 155 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719418 1719481 63 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229513 7229724 211 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227556 7227756 200 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2245956 2246009 53 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303949 3303884 -65 (-0.00%) 0.26%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134244 11134460 216 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128487 11128698 211 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000087 11000256 169 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58021702 58022341 639 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58163474 58164114 640 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743507 34743681 174 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741805 34741941 136 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3305322 3305315 -7 (-0.00%) 0.40%
transfer_no_resume_ring_1.2_rsa_aes_server 46198576 46198587 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80650255 80650244 -11 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46458950 46458944 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80553345 80553335 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58231633 58231627 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80645590 80645597 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80642626 80642632 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465926 46465929 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92701318 92701313 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58120626 58120623 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58233865 58233862 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46302457 46302455 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58127837 58127835 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92697223 92697226 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46292202 46292201 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92694985 92694983 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407681 46407682 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80541811 80541812 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92666724 92666723 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58236036 58236036 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46461268 46461268 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80548545 80548545 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92668573 92668573 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92657591 92657591 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46298938 46298938 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58131603 58131603 0 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.69 ms 1.64 ms ✅ -0.05 ms (-2.80%) 2.61%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.15 ms 1.12 ms ✅ -0.03 ms (-2.75%) 2.58%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.86 ms 1.82 ms ✅ -0.04 ms (-2.30%) 2.27%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.14 ms 1.12 ms ✅ -0.02 ms (-2.10%) 1.29%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.24 ms 5.17 ms ✅ -0.07 ms (-1.40%) 1.13%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.04 ms 4.98 ms ✅ -0.06 ms (-1.27%) 1.16%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.01 ms 4.94 ms ✅ -0.06 ms (-1.26%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.21 ms 5.15 ms ✅ -0.06 ms (-1.22%) 1.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.12 ms 1.09 ms -0.03 ms (-2.93%) 3.71%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.53 ms 4.49 ms -0.04 ms (-0.91%) 1.61%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.49 ms 4.46 ms -0.04 ms (-0.82%) 1.80%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.22 ms 5.18 ms -0.04 ms (-0.75%) 1.32%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.17 ms 5.14 ms -0.04 ms (-0.68%) 1.42%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.29 ms 4.27 ms -0.03 ms (-0.65%) 2.19%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.54 ms 0.03 ms (0.64%) 6.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.33 ms 4.30 ms -0.03 ms (-0.58%) 1.91%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.96 ms 4.94 ms -0.03 ms (-0.54%) 1.49%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.20 ms 5.23 ms 0.03 ms (0.54%) 6.30%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.01 ms 4.98 ms -0.02 ms (-0.45%) 1.33%
handshake_no_resume_ring_1.3_ecdsap256_chacha 474.99 µs 476.94 µs 1.95 µs (0.41%) 4.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.13 ms 1.14 ms 0.00 ms (0.40%) 1.50%
transfer_no_resume_ring_1.2_rsa_aes 5.89 ms 5.91 ms 0.02 ms (0.39%) 4.59%
handshake_no_resume_ring_1.3_ecdsap256_aes 481.09 µs 482.96 µs 1.86 µs (0.39%) 3.51%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.14 ms 1.15 ms 0.00 ms (0.32%) 1.43%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.22 ms 5.21 ms -0.02 ms (-0.30%) 5.46%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.59 ms 5.58 ms -0.02 ms (-0.28%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.48 ms 5.49 ms 0.02 ms (0.28%) 5.09%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.15 ms 5.14 ms -0.01 ms (-0.27%) 5.37%
transfer_no_resume_ring_1.3_rsa_aes 5.97 ms 5.99 ms 0.02 ms (0.25%) 4.71%
handshake_tickets_ring_1.3_rsa_chacha 6.08 ms 6.07 ms -0.01 ms (-0.24%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.59 ms 8.61 ms 0.02 ms (0.23%) 3.22%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.66 ms 13.68 ms 0.03 ms (0.20%) 2.09%
handshake_tickets_ring_1.3_ecdsap256_aes 5.80 ms 5.79 ms -0.01 ms (-0.19%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.98 ms 13.00 ms 0.02 ms (0.19%) 2.38%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.71 ms 8.69 ms -0.01 ms (-0.17%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.10 ms 16.12 ms 0.02 ms (0.15%) 1.86%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.98 ms 13.00 ms 0.02 ms (0.14%) 2.21%
transfer_no_resume_ring_1.3_rsa_chacha 13.48 ms 13.50 ms 0.02 ms (0.13%) 2.06%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 454.92 µs 455.46 µs 0.54 µs (0.12%) 4.46%
handshake_no_resume_ring_1.3_rsa_aes 978.07 µs 977.00 µs -1.06 µs (-0.11%) 1.31%
handshake_tickets_ring_1.3_ecdsap384_aes 8.92 ms 8.91 ms -0.01 ms (-0.11%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.30 ms 6.29 ms -0.01 ms (-0.11%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.69 ms 13.67 ms -0.01 ms (-0.09%) 1.98%
handshake_no_resume_ring_1.3_rsa_chacha 977.92 µs 977.07 µs -0.85 µs (-0.09%) 1.42%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.52 ms 5.52 ms 0.00 ms (0.07%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.99 ms 8.99 ms -0.00 ms (-0.05%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.58 ms 1.58 ms -0.00 ms (-0.05%) 1.23%
handshake_tickets_ring_1.2_rsa_aes 1.66 ms 1.66 ms 0.00 ms (0.04%) 1.54%
handshake_session_id_ring_1.3_ecdsap256_aes 5.88 ms 5.88 ms -0.00 ms (-0.03%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.63 ms 8.63 ms -0.00 ms (-0.02%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 967.08 µs 967.30 µs 0.23 µs (0.02%) 1.83%
handshake_session_id_ring_1.3_rsa_aes 6.38 ms 6.37 ms -0.00 ms (-0.02%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.02%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 457.85 µs 457.77 µs -0.08 µs (-0.02%) 4.02%
handshake_session_id_ring_1.3_rsa_chacha 6.01 ms 6.01 ms 0.00 ms (0.02%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.59 ms -0.00 ms (-0.01%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.72131% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.16%. Comparing base (7a64c74) to head (ed475d9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/msgs/handshake.rs 97.95% 3 Missing ⚠️
rustls/src/conn.rs 0.00% 1 Missing ⚠️
rustls/src/error.rs 93.33% 1 Missing ⚠️
rustls/src/server/server_conn.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2379   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          94       94           
  Lines       22815    22814    -1     
=======================================
  Hits        21939    21939           
+ Misses        876      875    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

djc
djc approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay match ergonomics!

@djc djc added this pull request to the merge queue Mar 13, 2025
cpu
cpu approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Merged via the queue into main with commit 1c318bc Mar 13, 2025
62 checks passed
@djc djc deleted the jbp-match-refactors branch March 13, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu