Skip to content

Update semver-compatible dependencies #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

Update semver-compatible dependencies #2366

merged 1 commit into from
Mar 7, 2025

Conversation

djc
Copy link
Member

@djc djc commented Mar 7, 2025

Avoid warnings about RUSTSEC-2025-0009.

@djc djc requested review from cpu and ctz March 7, 2025 08:24
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Mar 7, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8291927 8330153 38226 (0.46%) 1.54%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3084057 3096952 12895 (0.42%) 0.70%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10695611 10732486 36875 (0.34%) 2.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1148311 1144915 -3396 (-0.30%) 1.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1150606 1147221 -3385 (-0.29%) 1.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3090717 3098563 7846 (0.25%) 0.58%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10700713 10727062 26349 (0.25%) 0.94%
handshake_session_id_ring_1.2_rsa_aes_server 4296098 4304018 7920 (0.18%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3877675 3870895 -6780 (-0.17%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4760732 4768742 8010 (0.17%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4219669 4212889 -6780 (-0.16%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8311514 8301137 -10377 (-0.12%) 1.37%
transfer_no_resume_ring_1.3_rsa_aes_server 46241643 46292202 50559 (0.11%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46248376 46298938 50562 (0.11%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46148656 46198576 49920 (0.11%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46253826 46302456 48630 (0.11%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2062449 2064587 2138 (0.10%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2059490 2061544 2054 (0.10%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58080017 58136979 56962 (0.10%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58090920 58147879 56959 (0.10%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58087802 58144125 56323 (0.10%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57983495 58038539 55044 (0.09%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3302980 3305412 2432 (0.07%) 0.30%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10439182 10431797 -7385 (-0.07%) 1.03%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27803301 27787923 -15378 (-0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27862877 27847621 -15256 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27805738 27790558 -15180 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27810152 27795041 -15111 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27869586 27854449 -15137 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27865182 27850083 -15099 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28236579 28221316 -15263 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28202896 28187750 -15146 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28199841 28184736 -15105 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28206667 28191608 -15059 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28232710 28217672 -15038 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28229558 28214561 -14997 (-0.05%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32551990 32564590 12600 (0.04%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32554527 32567127 12600 (0.04%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32554546 32567146 12600 (0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30844033 30832333 -11700 (-0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30846970 30835270 -11700 (-0.04%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30851023 30839323 -11700 (-0.04%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32108560 32120650 12090 (0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32111059 32123149 12090 (0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32111160 32123250 12090 (0.04%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31162373 31150673 -11700 (-0.04%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31165628 31153928 -11700 (-0.04%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31169630 31157930 -11700 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3871125 3872175 1050 (0.03%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295708 1296020 312 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5018332 5019472 1140 (0.02%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4301262 4302072 810 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1719083 1719394 311 (0.02%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4564184 4564994 810 (0.02%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2245510 2245908 398 (0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2333422 2333813 391 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1934091 1934397 306 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1927341 1927632 291 (0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303472 3303965 493 (0.01%) 0.26%
handshake_tickets_ring_1.3_rsa_chacha_server 32458915 32462665 3750 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32461452 32465202 3750 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32461516 32465266 3750 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31995790 31999030 3240 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31998289 32001529 3240 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31998390 32001630 3240 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30926482 30923563 -2919 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30929410 30926500 -2910 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30933463 30930553 -2910 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31224782 31221863 -2919 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297097 1297218 121 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31228049 31225139 -2910 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31232051 31229141 -2910 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2339278 2339463 185 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227336 7227651 315 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128285 11128600 315 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10999910 11000205 295 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28749812 28749132 -680 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28828107 28827515 -592 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28747001 28746517 -484 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229495 7229613 118 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30219465 30219937 472 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28827637 28827209 -428 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28825253 28824828 -425 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30262227 30262668 441 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34741476 34741896 420 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28749289 28748950 -339 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134253 11134362 109 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682365 92683009 644 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673304 92673941 637 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684206 92684841 635 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34743387 34743598 211 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30222522 30222424 -98 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30265035 30264960 -75 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30222430 30222377 -53 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30265170 30265188 18 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46458952 46458942 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58237267 58237271 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92702871 92702865 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465925 46465928 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58239507 58239504 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92700632 92700628 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46461268 46461266 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80642630 80642632 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80645597 80645595 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407680 46407679 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58180294 58180293 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58241587 58241586 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80541808 80541809 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80548542 80548543 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92706865 92706866 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80553338 80553338 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80650251 80650251 0 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_ring_1.3_ecdsap256_aes 6.30 ms 5.47 ms ✅ -0.83 ms (-13.13%) 5.40%
transfer_no_resume_ring_1.2_rsa_aes 6.71 ms 5.89 ms ✅ -0.83 ms (-12.30%) 4.43%
transfer_no_resume_ring_1.3_rsa_aes 6.79 ms 5.97 ms ✅ -0.82 ms (-12.12%) 5.20%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.44 ms 8.60 ms ✅ -0.84 ms (-8.92%) 3.38%
handshake_session_id_ring_1.3_ecdsap256_aes 5.57 ms 5.91 ms ⚠️ 0.34 ms (6.03%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.07 ms 6.41 ms ⚠️ 0.34 ms (5.63%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.68 ms 9.02 ms ⚠️ 0.34 ms (3.96%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.63 ms 5.82 ms ⚠️ 0.19 ms (3.32%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.13 ms 6.32 ms ⚠️ 0.19 ms (3.05%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.54 ms 1.57 ms ⚠️ 0.04 ms (2.37%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.74 ms 8.94 ms ⚠️ 0.20 ms (2.25%) 1.00%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.86 ms 1.83 ms -0.04 ms (-1.95%) 3.14%
handshake_tickets_ring_1.2_rsa_aes 1.63 ms 1.65 ms 0.03 ms (1.68%) 1.75%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.95 ms 5.02 ms 0.06 ms (1.31%) 2.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.32 ms 4.38 ms 0.06 ms (1.31%) 3.07%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.29 ms 4.35 ms 0.06 ms (1.31%) 2.02%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.00 ms 5.06 ms 0.06 ms (1.26%) 2.03%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.67 ms 1.65 ms -0.02 ms (-1.16%) 2.67%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.16 ms 5.22 ms 0.06 ms (1.16%) 2.15%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.49 ms 4.54 ms 0.05 ms (1.15%) 1.93%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.52 ms 4.57 ms 0.05 ms (1.07%) 2.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.21 ms 5.26 ms 0.06 ms (1.06%) 1.82%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.98 ms 5.03 ms 0.05 ms (0.99%) 1.29%
handshake_no_resume_ring_1.3_rsa_chacha 967.68 µs 977.03 µs 9.35 µs (0.97%) 2.08%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.01 ms 5.06 ms 0.05 ms (0.91%) 1.94%
handshake_no_resume_ring_1.3_rsa_aes 967.72 µs 976.37 µs 8.65 µs (0.89%) 1.61%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.19 ms 5.23 ms 0.04 ms (0.83%) 2.02%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.14 ms 5.09 ms -0.04 ms (-0.82%) 6.52%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.14 ms 1.15 ms 0.01 ms (0.72%) 1.78%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.13 ms 1.12 ms -0.01 ms (-0.72%) 2.51%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.21 ms 5.24 ms 0.04 ms (0.72%) 1.62%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.09 ms -0.01 ms (-0.62%) 3.96%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.13 ms 1.14 ms 0.01 ms (0.61%) 1.30%
handshake_no_resume_ring_1.3_ecdsap256_aes 479.08 µs 482.01 µs 2.92 µs (0.61%) 4.06%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.20 ms 5.18 ms -0.03 ms (-0.50%) 6.29%
handshake_session_id_ring_1.3_rsa_chacha 6.01 ms 6.04 ms 0.03 ms (0.45%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.53 ms 5.55 ms 0.02 ms (0.42%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.07 ms 6.09 ms 0.02 ms (0.31%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.63 ms 8.66 ms 0.02 ms (0.28%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.70 ms 8.72 ms 0.02 ms (0.23%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.00 ms 12.98 ms -0.03 ms (-0.22%) 2.73%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.59 ms 5.60 ms 0.01 ms (0.20%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.49 ms 13.47 ms -0.03 ms (-0.19%) 2.44%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.69 ms 13.66 ms -0.03 ms (-0.19%) 2.34%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.51 ms -0.01 ms (-0.14%) 8.33%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.13%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.99 ms 12.98 ms -0.02 ms (-0.13%) 2.78%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.12 ms -0.00 ms (-0.12%) 1.87%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.11 ms 16.10 ms -0.02 ms (-0.12%) 2.17%
handshake_no_resume_ring_1.3_ecdsap256_chacha 475.86 µs 475.31 µs -0.55 µs (-0.12%) 4.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 458.37 µs 457.93 µs -0.44 µs (-0.10%) 4.93%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 455.92 µs 455.48 µs -0.44 µs (-0.10%) 5.44%
handshake_no_resume_ring_1.2_rsa_aes 964.32 µs 965.20 µs 0.88 µs (0.09%) 2.04%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.20 ms 5.20 ms -0.00 ms (-0.05%) 6.85%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.67 ms 13.66 ms -0.01 ms (-0.04%) 2.65%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.59 ms 0.00 ms (0.03%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Mar 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (1854946) to head (7568a14).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2366   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files         103      103           
  Lines       24551    24551           
=======================================
  Hits        23299    23299           
  Misses       1252     1252

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc
Copy link
Member Author

djc commented Mar 7, 2025

@ctz are we ignoring this semver compatibility stuff? Have you already looked into ways of allowing certain lints locally?

@ctz
Copy link
Member

ctz commented Mar 7, 2025

I have being, yes. Though it's quite annoying. I now realise that having alphabetically sorted enums is a losing game.

@djc djc added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit d6726c8 Mar 7, 2025
60 of 62 checks passed
@djc djc deleted the update-deps branch March 7, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

@cpu cpu Awaiting requested review from cpu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djc @ctz