Skip to content

docs: update reference to danger NoCertificateVerification struct in examples #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

docs: update reference to danger NoCertificateVerification struct in examples #2351

merged 1 commit into from
Feb 24, 2025

Conversation

brody4hire
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.89%. Comparing base (3ccfcec) to head (e2f047b).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2351   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files         103      103           
  Lines       24274    24274           
=======================================
  Hits        23034    23034           
  Misses       1240     1240

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Feb 24, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8296591 8260037 -36554 (-0.44%) 1.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1146118 1150676 4558 (0.40%) 1.54%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8297438 8264498 -32940 (-0.40%) 0.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1148375 1143829 -4546 (-0.40%) 1.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3085411 3078743 -6668 (-0.22%) 0.51%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10721494 10699386 -22108 (-0.21%) 1.15%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3080287 3085832 5545 (0.18%) 0.51%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10721955 10715762 -6193 (-0.06%) 1.17%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10425020 10428314 3294 (0.03%) 0.84%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3300508 3300696 188 (0.01%) 0.23%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3300163 3300009 -154 (-0.00%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2059554 2059466 -88 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28183971 28183665 -306 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30396342 30396060 -282 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28213399 28213571 172 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28901174 28901013 -161 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28216532 28216687 155 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28220507 28220387 -120 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28981462 28981585 123 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27848996 27848881 -115 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30396517 30396637 120 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28186849 28186741 -108 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30436118 30436217 99 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28979400 28979307 -93 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27846520 27846608 88 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28903471 28903541 70 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27793962 27794023 61 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28981946 28982008 62 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2062519 2062515 -4 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30393558 30393616 58 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28903184 28903131 -53 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27853324 27853369 45 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229602 7229592 -10 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27787259 27787225 -34 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30438769 30438804 35 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34740255 34740230 -25 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30439107 30439121 14 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27789573 27789580 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46241642 46241652 10 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28190571 28190567 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58237332 58237324 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58239401 58239409 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407688 46407682 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465930 46465924 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58234449 58234442 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80553344 80553335 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92704681 92704691 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80541803 80541811 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92678267 92678258 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46458310 46458306 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46253815 46253818 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92700682 92700688 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92680099 92680104 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58083699 58083702 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46248385 46248383 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46461270 46461268 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80650245 80650248 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58075914 58075916 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58086815 58086817 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80645589 80645587 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92698442 92698441 -1 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2242647 2242647 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2336195 2336195 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31153220 31153220 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30913028 30913028 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31208385 31208385 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31149226 31149226 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4299668 4299668 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2330342 2330342 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4557194 4557194 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134345 11134345 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30827617 30827617 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297192 1297192 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32632988 32632988 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295801 1295801 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4764122 4764122 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 32150919 32150919 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30830558 30830558 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3869905 3869905 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31211664 31211664 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32263689 32263689 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 32150871 32150871 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1716246 1716246 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32723682 32723682 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30910075 30910075 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80642631 80642631 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57980055 57980055 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 32148706 32148706 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227431 7227431 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32725858 32725858 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32261476 32261476 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32726018 32726018 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1924377 1924377 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31145967 31145967 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32263641 32263641 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32630622 32630622 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80548545 80548545 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46148656 46148656 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31215658 31215658 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5021752 5021752 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4294272 4294272 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1931123 1931123 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58174938 58174938 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32632798 32632798 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34738322 34738322 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92669202 92669202 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3874635 3874635 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30917073 30917073 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30834603 30834603 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4211899 4211899 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128375 11128375 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000054 11000054 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.42 ms 4.51 ms 0.09 ms (1.97%) 5.15%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.09 ms 5.18 ms 0.09 ms (1.70%) 6.19%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.02 ms 5.11 ms 0.09 ms (1.69%) 6.02%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.11 ms 5.20 ms 0.08 ms (1.64%) 3.99%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.20 ms 6.28 ms 0.08 ms (1.32%) 4.35%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 449.36 µs 455.26 µs 5.91 µs (1.31%) 3.99%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.29 ms 4.35 ms 0.06 ms (1.31%) 2.09%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.49 ms 4.55 ms 0.06 ms (1.30%) 1.59%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.31 ms 4.36 ms 0.05 ms (1.26%) 2.09%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.16 ms 5.22 ms 0.06 ms (1.22%) 2.03%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.95 ms 5.01 ms 0.06 ms (1.21%) 1.78%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.56 ms 0.05 ms (1.20%) 2.16%
transfer_no_resume_ring_1.2_rsa_aes 6.61 ms 6.69 ms 0.08 ms (1.19%) 3.54%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.96 ms 5.02 ms 0.06 ms (1.16%) 1.50%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 451.14 µs 456.25 µs 5.11 µs (1.13%) 3.92%
transfer_no_resume_ring_1.3_rsa_aes 6.69 ms 6.76 ms 0.07 ms (1.12%) 3.87%
handshake_no_resume_ring_1.3_ecdsap256_chacha 471.21 µs 476.25 µs 5.04 µs (1.07%) 2.90%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.19 ms 5.24 ms 0.06 ms (1.06%) 1.67%
handshake_no_resume_ring_1.3_ecdsap256_aes 474.02 µs 478.98 µs 4.96 µs (1.05%) 2.63%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.19 ms 5.24 ms 0.05 ms (1.03%) 1.05%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 4.99 ms 5.04 ms 0.05 ms (0.98%) 1.68%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.17 ms 5.22 ms 0.05 ms (0.93%) 1.89%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.99 ms 5.03 ms 0.05 ms (0.91%) 1.23%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.31 ms 9.39 ms 0.08 ms (0.90%) 2.74%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.90 ms 12.99 ms 0.09 ms (0.67%) 1.78%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.89 ms 12.98 ms 0.08 ms (0.66%) 1.76%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.58 ms 13.67 ms 0.09 ms (0.64%) 1.96%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.58 ms 13.66 ms 0.08 ms (0.56%) 1.91%
transfer_no_resume_ring_1.3_rsa_chacha 13.40 ms 13.47 ms 0.08 ms (0.56%) 1.65%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.13 ms 1.13 ms 0.01 ms (0.55%) 1.15%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.02 ms 16.10 ms 0.09 ms (0.54%) 1.51%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.81 ms 1.80 ms -0.01 ms (-0.48%) 3.29%
handshake_session_id_ring_1.3_ecdsap256_aes 5.56 ms 5.59 ms 0.03 ms (0.48%) 1.03%
handshake_no_resume_ring_1.2_rsa_aes 960.12 µs 964.14 µs 4.02 µs (0.42%) 1.62%
handshake_no_resume_ring_1.3_rsa_aes 963.69 µs 967.66 µs 3.97 µs (0.41%) 1.08%
handshake_session_id_ring_1.3_rsa_aes 6.06 ms 6.08 ms 0.02 ms (0.39%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.14 ms 1.14 ms 0.00 ms (0.39%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.63 ms 5.66 ms 0.02 ms (0.38%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 965.58 µs 969.14 µs 3.56 µs (0.37%) 1.25%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.12 ms 0.00 ms (0.36%) 1.14%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.53 ms 5.54 ms 0.02 ms (0.36%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.61 ms 0.01 ms (0.32%) 1.42%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.59 ms 5.61 ms 0.02 ms (0.32%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.11 ms 1.11 ms 0.00 ms (0.31%) 2.94%
handshake_session_id_ring_1.3_rsa_chacha 6.03 ms 6.04 ms 0.02 ms (0.30%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.13 ms 6.15 ms 0.02 ms (0.27%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.08 ms 1.08 ms 0.00 ms (0.24%) 3.23%
handshake_tickets_ring_1.3_ecdsap384_aes 8.74 ms 8.76 ms 0.02 ms (0.23%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.69 ms 8.71 ms 0.02 ms (0.22%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.64 ms 1.64 ms -0.00 ms (-0.19%) 2.47%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.59 ms 0.01 ms (0.18%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.08 ms 6.09 ms 0.01 ms (0.18%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.59 ms 3.60 ms 0.01 ms (0.17%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.70 ms 8.71 ms 0.01 ms (0.16%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.65 ms 8.66 ms 0.01 ms (0.13%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms 0.00 ms (0.06%) 1.00%

Additional information

Historical results

Checkout details:

@djc djc added this pull request to the merge queue Feb 24, 2025
Merged via the queue into rustls:main with commit a5ec652 Feb 24, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brody4hire @djc @ctz