ci: improve performance via more cache usage #2343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each overall build.yml run builds bindgen-cli 7 times, cross 8 times, etc. Instead of that, use `taiki-e/cache-cargo-install-action` for all places we would use cargo install/binstall.
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2343 +/- ##
=======================================
Coverage 94.88% 94.88%
=======================================
Files 103 103
Lines 24191 24191
=======================================
Hits 22953 22953
Misses 1238 1238 ☔ View full report in Codecov by Sentry. |
djc
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each overall build.yml run builds bindgen-cli 7 times, cross 8 times, etc. Instead of that, use
taiki-e/cache-cargo-install-actionfor all places we would use cargo install/binstall.Micro comparison (observe runtime of
install taplo-clijob)before: https://github.com/rustls/rustls/actions/runs/13308691489/job/37165532448
after: https://github.com/rustls/rustls/actions/runs/13311776317/job/37175916755
Macro comparison (see bottom row)
before: https://github.com/rustls/rustls/actions/runs/13308691489/usage
after: https://github.com/rustls/rustls/actions/runs/13312167378/usage
The remaining annoyances with CI performance: