Skip to content

Fix daily tests #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2025
Merged

Fix daily tests #2340

merged 2 commits into from
Feb 13, 2025

Conversation

ctz
Copy link
Member

@ctz ctz commented Feb 13, 2025 •
edited
Loading

There were two issues here:

  1. Busted hickory
    Taking hickory-proto 0.25.0-alpha.5 without hickory-resolver produced something that built but couldn't do any lookups: https://github.com/rustls/rustls/actions/runs/13292247381/job/37115669161

We previously pinned this because prereleases have no particular stability guarantees, but since we should be only using --locked dependencies, this is actively unhelpful and this dependency is only in example and test code.

  1. Embarrassing overlooking of unbuffered examples
    Fallout from unbuffered: introduce PeerClosed state #2332

Working run with these changes: https://github.com/rustls/rustls/actions/runs/13307896223/workflow

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Feb 13, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10489332 10411015 -78317 (-0.75%) 0.96%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8279301 8304304 25003 (0.30%) 0.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8276723 8291498 14775 (0.18%) 0.89%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10729422 10737412 7990 (0.07%) 0.95%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3078178 3080181 2003 (0.07%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10742024 10738364 -3660 (-0.03%) 1.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3087716 3088100 384 (0.01%) 0.35%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3624958 3624531 -427 (-0.01%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1173037 1172967 -70 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2160692 2160786 94 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2163908 2163816 -92 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623302 3623169 -133 (-0.00%) 0.23%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28975474 28975023 -451 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27783668 27783951 283 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28183290 28183576 286 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30387524 30387244 -280 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28210334 28210102 -232 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1611950 1611963 13 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27850140 27849942 -198 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27790591 27790779 188 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28213218 28213092 -126 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28972740 28972856 116 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27845616 27845507 -109 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27786371 27786268 -103 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30430036 30430141 105 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1179880 1179884 4 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30432699 30432798 99 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28187318 28187227 -91 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28894390 28894463 73 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28896665 28896600 -65 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1610550 1610553 3 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28975007 28975046 39 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7565048 7565058 10 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30432472 30432435 -37 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30389867 30389843 -24 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35182682 35182707 25 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28217092 28217111 19 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28896723 28896738 15 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46468794 46468783 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46469187 46469176 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58220390 58220379 -11 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28180508 28180513 5 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30390214 30390209 -5 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27843211 27843207 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46377977 46377971 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92698451 92698441 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58174934 58174938 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407681 46407684 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465929 46465932 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80537020 80537025 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80541819 80541824 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92657677 92657682 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58239408 58239405 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58332660 58332663 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46461269 46461270 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46472056 46472055 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58234449 58234448 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58237322 58237321 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58325512 58325513 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80536631 80536632 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80650253 80650252 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92666743 92666742 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92668582 92668583 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92700683 92700682 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92704690 92704689 -1 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2562021 2562021 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 40508960 40508960 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 40504966 40504966 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 40501707 40501707 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 40583150 40583150 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2660283 2660283 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11429384 11429384 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 40285503 40285503 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 41974948 41974948 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 40187138 40187138 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 40579156 40579156 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11423405 11423405 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 40278517 40278517 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 42073478 42073478 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11290907 11290907 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 40281458 40281458 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 40575897 40575897 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 41493621 41493621 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5021362 5021362 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1924364 1924364 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 41493669 41493669 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 41611929 41611929 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7562881 7562881 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4212349 4212349 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3874275 3874275 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46458304 46458304 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 40191183 40191183 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 41975138 41975138 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1716304 1716304 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 41611881 41611881 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80645595 80645595 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2654416 2654416 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 41972650 41972650 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 42070990 42070990 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4699320 4699320 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 41491510 41491510 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58336414 58336414 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 41609770 41609770 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3870565 3870565 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4493883 4493883 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4234990 4234990 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 42073288 42073288 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35180775 35180775 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80642626 80642626 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 40184197 40184197 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4233669 4233669 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1931114 1931114 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.55 ms 4.43 ms -0.12 ms (-2.56%) 5.74%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.21 ms 5.10 ms -0.12 ms (-2.23%) 7.22%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.25 ms 5.14 ms -0.11 ms (-2.18%) 4.90%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.14 ms 5.03 ms -0.10 ms (-2.00%) 6.38%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.40 ms 6.28 ms -0.12 ms (-1.91%) 4.49%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 462.55 µs 454.06 µs -8.49 µs (-1.84%) 4.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 464.60 µs 456.18 µs -8.41 µs (-1.81%) 5.03%
transfer_no_resume_ring_1.3_rsa_aes 6.89 ms 6.77 ms -0.12 ms (-1.71%) 3.87%
transfer_no_resume_ring_1.2_rsa_aes 6.81 ms 6.71 ms -0.11 ms (-1.57%) 3.83%
handshake_no_resume_ring_1.3_ecdsap256_aes 508.31 µs 501.14 µs -7.17 µs (-1.41%) 2.71%
handshake_no_resume_ring_1.3_ecdsap256_chacha 505.52 µs 499.29 µs -6.23 µs (-1.23%) 3.18%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.50 ms 9.39 ms -0.11 ms (-1.20%) 2.90%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.02 ms 4.97 ms -0.05 ms (-1.01%) 1.70%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.02 ms 12.90 ms -0.12 ms (-0.94%) 2.45%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.70 ms 13.58 ms -0.12 ms (-0.90%) 2.78%
transfer_no_resume_ring_1.3_rsa_chacha 13.54 ms 13.42 ms -0.12 ms (-0.89%) 1.89%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.05 ms 12.93 ms -0.12 ms (-0.89%) 2.24%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.37 ms 4.33 ms -0.04 ms (-0.87%) 2.88%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.54 ms 4.50 ms -0.04 ms (-0.87%) 2.28%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.57 ms 4.53 ms -0.04 ms (-0.83%) 2.65%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.71 ms 13.60 ms -0.11 ms (-0.83%) 2.19%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.83 ms 1.82 ms -0.02 ms (-0.82%) 3.70%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.27 ms 5.23 ms -0.04 ms (-0.81%) 2.06%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.23 ms 5.19 ms -0.04 ms (-0.80%) 2.36%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.23 ms 5.19 ms -0.04 ms (-0.79%) 1.77%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.07 ms 5.03 ms -0.04 ms (-0.79%) 2.06%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.02 ms 4.98 ms -0.04 ms (-0.79%) 2.43%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.33 ms 4.29 ms -0.03 ms (-0.78%) 2.34%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.24 ms 5.20 ms -0.04 ms (-0.77%) 1.58%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.04 ms 5.00 ms -0.04 ms (-0.73%) 1.60%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.15 ms 16.04 ms -0.12 ms (-0.72%) 1.69%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.16 ms 1.15 ms -0.01 ms (-0.69%) 1.71%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.08 ms -0.01 ms (-0.66%) 3.57%
handshake_tickets_ring_1.2_rsa_aes 1.62 ms 1.61 ms -0.01 ms (-0.62%) 1.64%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.12 ms -0.01 ms (-0.61%) 2.11%
handshake_no_resume_ring_1.3_rsa_aes 999.09 µs 993.27 µs -5.82 µs (-0.58%) 1.09%
handshake_no_resume_ring_1.2_rsa_aes 996.11 µs 990.58 µs -5.53 µs (-0.56%) 1.80%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.65 ms 1.64 ms -0.01 ms (-0.54%) 2.73%
handshake_session_id_ring_1.2_rsa_aes 1.53 ms 1.53 ms -0.01 ms (-0.53%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.17 ms 1.16 ms -0.01 ms (-0.52%) 1.02%
handshake_no_resume_ring_1.3_rsa_chacha 999.00 µs 993.84 µs -5.16 µs (-0.52%) 1.34%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.12 ms 1.12 ms -0.00 ms (-0.42%) 5.78%
handshake_tickets_ring_1.3_ecdsap256_aes 6.48 ms 6.46 ms -0.02 ms (-0.38%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.91 ms 6.89 ms -0.02 ms (-0.33%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.41 ms 6.39 ms -0.02 ms (-0.32%) 1.09%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.43 ms 6.41 ms -0.02 ms (-0.30%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.37 ms 6.35 ms -0.02 ms (-0.26%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.97 ms 6.95 ms -0.02 ms (-0.26%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.90 ms 6.88 ms -0.02 ms (-0.26%) 1.08%
handshake_session_id_ring_1.3_rsa_chacha 6.85 ms 6.83 ms -0.02 ms (-0.25%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.60 ms -0.01 ms (-0.20%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.52 ms 9.50 ms -0.02 ms (-0.19%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.50 ms 9.49 ms -0.02 ms (-0.17%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.61 ms -0.01 ms (-0.16%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.45 ms 9.44 ms -0.01 ms (-0.15%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.57 ms 9.56 ms -0.01 ms (-0.14%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (7742147) to head (4fc7a4e).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2340   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files         103      103           
  Lines       24191    24191           
=======================================
  Hits        22953    22953           
  Misses       1238     1238

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz marked this pull request as draft February 13, 2025 12:32
@ctz ctz changed the title Take & unpin hickory-resolver 0.25.0-alpha.5 Fix daily tests Feb 13, 2025
@ctz ctz marked this pull request as ready for review February 13, 2025 12:58
@ctz ctz added this pull request to the merge queue Feb 13, 2025
@ctz
Copy link
Member Author

ctz commented Feb 13, 2025

(merging with one review because I think it's mostly uncontroversial)

Merged via the queue into main with commit 1018185 Feb 13, 2025
73 checks passed
@ctz ctz deleted the jbp-hickory-resolver-alpha-5 branch February 13, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu