Skip to content

Clippy 1.85, 2024 style #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2025
Merged

Clippy 1.85, 2024 style #2348

merged 3 commits into from
Feb 21, 2025

Conversation

djc
Copy link
Member

@djc djc commented Feb 21, 2025

No description provided.

@djc djc requested review from cpu and ctz February 21, 2025 09:04
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Feb 21, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1148379 1143755 -4624 (-0.40%) 1.53%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10458552 10485445 26893 (0.26%) 0.84%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10733911 10760447 26536 (0.25%) 1.19%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8282776 8299404 16628 (0.20%) 1.30%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10721048 10740475 19427 (0.18%) 0.85%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8277150 8290453 13303 (0.16%) 0.89%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3085273 3080433 -4840 (-0.16%) 0.56%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3297948 3302186 4238 (0.13%) 0.23%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3298768 3300717 1949 (0.06%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2062432 2062607 175 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3082891 3082638 -253 (-0.01%) 0.36%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2059512 2059485 -27 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1931123 1931142 19 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27853338 27853612 274 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27787230 27786986 -244 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1924381 1924396 15 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28220367 28220555 188 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28903455 28903323 -132 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28981472 28981604 132 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28190603 28190475 -128 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30436347 30436212 -135 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28186740 28186863 123 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28981628 28981502 -126 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28903285 28903165 -120 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27789520 27789631 111 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1146118 1146122 4 (0.00%) 0.55%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28216527 28216621 94 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30439215 30439114 -101 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30396446 30396542 96 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28979131 28979222 91 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27793988 27793905 -83 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30438768 30438692 -76 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229592 7229610 18 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30393558 30393486 -72 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1716246 1716242 -4 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28900933 28900988 55 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 32148646 32148706 60 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 32150811 32150871 60 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 32150859 32150919 60 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32261416 32261476 60 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32263581 32263641 60 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32263629 32263689 60 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27846420 27846466 46 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34740230 34740280 50 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27848915 27848955 40 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34738352 34738322 -30 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28213440 28213458 18 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28183774 28183789 15 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30396098 30396108 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46248387 46248376 -11 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227432 7227431 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407678 46407684 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80650244 80650254 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58239403 58239409 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92698442 92698451 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80541810 80541803 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80548538 80548545 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46461269 46461273 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92680103 92680096 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80553340 80553346 6 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46148656 46148659 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92678264 92678258 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58174932 58174935 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58237317 58237320 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80645596 80645592 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92704690 92704686 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46458301 46458303 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80642629 80642626 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92700685 92700682 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46253815 46253816 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92669203 92669201 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465925 46465926 1 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57980056 57980055 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58083699 58083700 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58234443 58234444 1 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5021752 5021752 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2242647 2242647 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295804 1295804 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32723682 32723682 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4764122 4764122 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32632798 32632798 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31145967 31145967 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30917073 30917073 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30830558 30830558 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31149226 31149226 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2330342 2330342 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32725858 32725858 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32632988 32632988 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3874635 3874635 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134345 11134345 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30910075 30910075 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000054 11000054 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58086814 58086814 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31211664 31211664 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128375 11128375 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30913028 30913028 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31153220 31153220 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2336195 2336195 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30827617 30827617 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4557194 4557194 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58075913 58075913 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4299668 4299668 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31208385 31208385 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3869905 3869905 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4211899 4211899 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4294272 4294272 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297192 1297192 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30834603 30834603 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32630622 32630622 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32726018 32726018 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46241646 46241646 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31215658 31215658 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.01 ms 4.96 ms -0.04 ms (-0.88%) 1.21%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.33 ms 4.29 ms -0.04 ms (-0.88%) 1.67%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.46 ms 4.43 ms -0.04 ms (-0.84%) 5.15%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 454.99 µs 451.24 µs -3.75 µs (-0.82%) 3.92%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.19 ms 5.15 ms -0.04 ms (-0.80%) 1.41%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.01 ms 4.98 ms -0.04 ms (-0.77%) 1.37%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.07 ms 5.03 ms -0.04 ms (-0.76%) 5.85%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 452.73 µs 449.37 µs -3.36 µs (-0.74%) 3.75%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.14 ms 5.10 ms -0.03 ms (-0.66%) 6.19%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.15 ms 5.12 ms -0.03 ms (-0.64%) 3.78%
handshake_no_resume_ring_1.3_ecdsap256_aes 476.34 µs 473.36 µs -2.98 µs (-0.63%) 2.63%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.52 ms 4.49 ms -0.03 ms (-0.62%) 2.06%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.21 ms 5.17 ms -0.03 ms (-0.61%) 1.00%
transfer_no_resume_ring_1.2_rsa_aes 6.64 ms 6.60 ms -0.04 ms (-0.61%) 3.54%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.30 ms 4.28 ms -0.02 ms (-0.52%) 1.82%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.23 ms 6.20 ms -0.03 ms (-0.48%) 4.37%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.97 ms 4.95 ms -0.02 ms (-0.47%) 1.20%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.01 ms (-0.43%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 473.18 µs 471.19 µs -1.99 µs (-0.42%) 3.04%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms -0.01 ms (-0.42%) 1.43%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.96 ms 4.94 ms -0.02 ms (-0.39%) 1.19%
transfer_no_resume_ring_1.3_rsa_aes 6.71 ms 6.69 ms -0.02 ms (-0.35%) 3.71%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.19 ms 5.18 ms -0.02 ms (-0.35%) 1.67%
handshake_no_resume_ring_1.2_rsa_aes 962.51 µs 959.20 µs -3.31 µs (-0.34%) 1.78%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.61 ms 13.57 ms -0.04 ms (-0.32%) 1.90%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.11 ms 1.11 ms -0.00 ms (-0.31%) 2.73%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 12.90 ms -0.04 ms (-0.30%) 1.80%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.34 ms 9.31 ms -0.03 ms (-0.30%) 2.74%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.62 ms 8.64 ms 0.02 ms (0.27%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 965.54 µs 963.02 µs -2.52 µs (-0.26%) 1.07%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.93 ms 12.90 ms -0.03 ms (-0.25%) 1.76%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.50 ms 4.49 ms -0.01 ms (-0.22%) 1.42%
transfer_no_resume_ring_1.3_rsa_chacha 13.43 ms 13.40 ms -0.03 ms (-0.21%) 1.64%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.16 ms 5.15 ms -0.01 ms (-0.21%) 1.55%
handshake_session_id_ring_1.3_ecdsap384_aes 8.66 ms 8.68 ms 0.02 ms (0.21%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.61 ms 13.58 ms -0.03 ms (-0.20%) 1.96%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.80 ms 1.80 ms -0.00 ms (-0.20%) 3.29%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.05 ms 16.02 ms -0.03 ms (-0.19%) 1.48%
handshake_session_id_ring_1.3_rsa_chacha 6.00 ms 6.01 ms 0.01 ms (0.18%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.14 ms 1.14 ms -0.00 ms (-0.17%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.13 ms 1.13 ms -0.00 ms (-0.16%) 1.22%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.63 ms 1.63 ms -0.00 ms (-0.15%) 2.48%
handshake_tickets_ring_1.3_ecdsap384_aes 8.74 ms 8.73 ms -0.01 ms (-0.14%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 965.97 µs 964.88 µs -1.09 µs (-0.11%) 1.25%
handshake_tickets_ring_1.3_ecdsap256_aes 5.63 ms 5.62 ms -0.01 ms (-0.11%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.08 ms 1.08 ms -0.00 ms (-0.11%) 3.46%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.59 ms 3.59 ms -0.00 ms (-0.09%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.12 ms -0.00 ms (-0.09%) 1.18%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.59 ms 5.58 ms -0.00 ms (-0.08%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.59 ms -0.00 ms (-0.08%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.12 ms 6.12 ms -0.00 ms (-0.07%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.69 ms 8.69 ms -0.00 ms (-0.05%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.05 ms 6.04 ms -0.00 ms (-0.05%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.07 ms 6.06 ms -0.00 ms (-0.04%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.55 ms 5.55 ms 0.00 ms (0.03%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.51 ms 5.51 ms -0.00 ms (-0.01%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.97698% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.89%. Comparing base (f0e71ab) to head (33a39d0).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/client/ech.rs 0.00% 1 Missing ⚠️
rustls/src/client/tls13.rs 98.93% 1 Missing ⚠️
rustls/src/common_state.rs 75.00% 1 Missing ⚠️
rustls/src/server/server_conn.rs 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2348   +/-   ##
=======================================
  Coverage   94.88%   94.89%           
=======================================
  Files         103      103           
  Lines       24205    24274   +69     
=======================================
+ Hits        22967    23034   +67     
- Misses       1238     1240    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djc djc force-pushed the 1.85 branch 2 times, most recently from 85d98e3 to c6ad552 Compare February 21, 2025 09:38
cpu
cpu approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new formatting updates look nice ✨

@djc djc added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 3ccfcec Feb 21, 2025
62 checks passed
@djc djc deleted the 1.85 branch February 21, 2025 15:01
@cpu cpu mentioned this pull request Feb 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @ctz