bogo: implement -wait-for-debugger in shim #2347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2347 +/- ##
==========================================
- Coverage 94.89% 94.86% -0.03%
==========================================
Files 103 103
Lines 24274 24287 +13
==========================================
+ Hits 23034 23040 +6
- Misses 1240 1247 +7 ☔ View full report in Codecov by Sentry. |
djc
approved these changes
Feb 19, 2025
djc
reviewed
Feb 19, 2025
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
edd6a68 to
caaa692
Compare
Also updates the `runme` script to conditionally exclude the `-test.timeout` flag given to the BoGo runner when `-wait-for-debugger` is in use. The implementation in the shim depends on UNIX SIGSTOP signalling, and so is conditional to UNIX-like systems. Providing the flag on another platform will panic with an error message.
We can use the standard `Arc` here without worry.
caaa692 to
ff191bb
Compare
djc
approved these changes
Feb 22, 2025
ctz
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates the
runmescript to conditionally exclude the-test.timeoutflag given to the BoGo runner when-wait-for-debuggeris in use.The implementation in the shim depends on UNIX SIGSTOP signalling, and so is conditional to UNIX-like systems. Providing the flag on another platform will panic with an error message.
Having this support makes it possible to debug the Rustls-side of the BoGo testing process by having the BoringSSL-side Go test runner start the shim process in a suspended state. In this mode the test runner turns off some timeouts, reduces parallelism to 1 task at a time, and prints the PID of the shim process to attach to with a Rust-friendly debugger. By using
delveor another Go debugger it's also possible to debug the runner-side in conjugation with the shim. This should be a nice alternative to the tedious print-style-debugging I've used in the past :-)