unbuffered: introduce dangerous_extract_secrets, analogous to buffered API #2345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method body only accesses members of ConnectionCore, so it makes more sense to have it as a method of ConnectionCore directly. ConnectionCore is used by both the unbuffered and buffered APIs, so this simplifies exposing it from both without code duplication.
…d API The test is largely copied from the buffered API tests, and doesn't provide full coverage. They are testing the same underlying code, so this seems minor compared to creating further unnecessary duplication.
c4f83d3 to
eacb58c
Compare
|
(If you'd like a release containing these changes, suggest adding a commit with a version bump -- update both of the |
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2345 +/- ##
=======================================
Coverage 94.88% 94.88%
=======================================
Files 103 103
Lines 24191 24205 +14
=======================================
+ Hits 22953 22967 +14
Misses 1238 1238 ☔ View full report in Codecov by Sentry. |
I've added release notes, but I probably won't have time to migrate my own codebase to the unbuffered API for a while yet. So assuming this is the conditional ask I parsed it as, I'm personally fine if this gets merged without a bump and rolled into a release later. |
ctz
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the actual implementation of dangerous_extract_secrets into ConnectionCore, since that's a) where the goods actually are, and b) shared between the unbuffered and buffered APIs. This is only made
pub(crate)and outfitted with the appropriate facades for public API, for both the new and olddangerous_extract_secrets.The test is largely copied from the buffered API tests, and doesn't provide full coverage. They are testing the same underlying code, so this seems minor compared to creating further unnecessary duplication.
Proposed release notes
dangerous_extract_secretson UnbufferedClientConnection, UnbufferedServerConnection, and UnbufferedConnectionCommon