Skip to content

CI: deny all Clippy warnings including clippy::incompatible_msrv #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

CI: deny all Clippy warnings including clippy::incompatible_msrv #2310

merged 1 commit into from
Jan 23, 2025

Conversation

brody4hire
Copy link
Contributor

It looks to me like there is no need to ignore clippy::incompatible_msrv in Clippy CI task to succeed with --deny warnings.

Context comes from this comment: #2285 (comment)

For PR #2285 I would like to update CI to allow a single warning in most crates & deny all other warnings. I have already tried this with XXX TODO comments; PR #2285 still has green status with these updates.

Considering that ignoring clippy::incompatible_msrv is not what we want for PR #2285, and that CI can succeed without ignoring this warning, I think we should remove this allow option as proposed here. I would also like to keep this update separate from PR #2285.

cpu
cpu approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If clippy/CI are happy with this change, so am I. Thanks!

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.82%. Comparing base (069e033) to head (3d80e54).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2310   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files         104      104           
  Lines       24100    24100           
=======================================
  Hits        22853    22853           
  Misses       1247     1247

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brody4hire brody4hire mentioned this pull request Jan 22, 2025
Closed
1 task
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jan 22, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10660364 10746428 ⚠️ 86064 (0.81%) 0.42%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10726661 10667189 -59472 (-0.55%) 0.72%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8297716 8271790 -25926 (-0.31%) 1.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3080392 3076497 -3895 (-0.13%) 0.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3080798 3083179 2381 (0.08%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8272690 8276806 4116 (0.05%) 0.62%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1174455 1174633 178 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1176834 1176928 94 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3624761 3624533 -228 (-0.01%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2160162 2160042 -120 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10437824 10437586 -238 (-0.00%) 1.33%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27787215 27786941 -274 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27782585 27782817 232 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28892508 28892295 -213 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30422958 30422745 -213 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27846427 27846611 184 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30380523 30380330 -193 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28210943 28210780 -163 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28970728 28970856 128 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27842010 27842121 111 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28203972 28203865 -107 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1612228 1612233 5 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28174085 28174169 84 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28177140 28177214 74 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28970497 28970569 72 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717778 1717782 4 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28181048 28180991 -57 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2163085 2163089 4 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28890109 28890160 51 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27839507 27839551 44 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30423051 30423098 47 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30380115 30380153 38 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30420270 30420304 34 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3618897 3618893 -4 (-0.00%) 0.22%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7566722 7566714 -8 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28206940 28206967 27 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35182618 35182595 -23 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28892187 28892174 -13 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28968532 28968520 -12 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46456934 46456944 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470691 46470682 -9 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27780133 27780137 4 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389596 46389590 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46477529 46477535 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554936 80554926 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58243607 58243600 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661852 80661843 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46423832 46423827 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58181212 58181206 -6 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30377571 30377574 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540444 80540451 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58331789 58331794 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92673018 92673025 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58245686 58245682 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58240734 58240731 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58338934 58338936 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92706964 92706966 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46464566 46464567 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467804 46467805 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92663957 92663956 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92674860 92674861 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92704731 92704732 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92710958 92710959 1 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2655922 2655922 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487102 46487102 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 40571689 40571689 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35180648 35180648 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 41492451 41492451 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 41492499 41492499 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641257 80641257 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 41969798 41969798 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 42070688 42070688 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 41972158 41972158 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1613619 1613619 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 40500760 40500760 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 40574950 40574950 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4489533 4489533 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932577 1932577 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4233520 4233520 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 41608658 41608658 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58342690 58342690 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7564559 7564559 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 41610711 41610711 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292436 11292436 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11425039 11425039 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4229019 4229019 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 40281303 40281303 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 41490398 41490398 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 40504760 40504760 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 40186983 40186983 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3872463 3872463 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 40277252 40277252 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3864355 3864355 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648883 80648883 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4206439 4206439 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 41610759 41610759 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 40274309 40274309 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11430994 11430994 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535647 80535647 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 42068138 42068138 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58225377 58225377 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 40497499 40497499 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925831 1925831 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 41972348 41972348 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 40578950 40578950 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 40182932 40182932 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4698000 4698000 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 40179989 40179989 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5019734 5019734 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563547 2563547 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2661789 2661789 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 42070498 42070498 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.01 ms 5.06 ms 0.05 ms (0.91%) 7.03%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.43 ms 4.47 ms 0.04 ms (0.90%) 7.41%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.07 ms 5.12 ms 0.04 ms (0.86%) 7.31%
transfer_no_resume_ring_1.3_rsa_aes 6.78 ms 6.83 ms 0.05 ms (0.68%) 5.10%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.13 ms 5.17 ms 0.03 ms (0.67%) 6.37%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.29 ms 6.33 ms 0.04 ms (0.62%) 4.66%
transfer_no_resume_ring_1.2_rsa_aes 6.72 ms 6.76 ms 0.04 ms (0.60%) 4.67%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 455.20 µs 457.66 µs 2.45 µs (0.54%) 4.78%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 453.54 µs 455.93 µs 2.39 µs (0.53%) 4.81%
handshake_no_resume_ring_1.3_ecdsap256_chacha 498.94 µs 501.39 µs 2.45 µs (0.49%) 4.26%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.40 ms 9.44 ms 0.04 ms (0.41%) 2.81%
handshake_no_resume_ring_1.3_ecdsap256_aes 501.91 µs 503.74 µs 1.83 µs (0.36%) 3.72%
transfer_no_resume_ring_1.3_rsa_chacha 13.43 ms 13.48 ms 0.05 ms (0.36%) 2.75%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.60 ms -0.01 ms (-0.35%) 1.60%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.78 ms 1.78 ms -0.01 ms (-0.35%) 1.64%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.90 ms 12.94 ms 0.04 ms (0.32%) 2.57%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.60 ms 13.64 ms 0.04 ms (0.31%) 2.19%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.56 ms 13.60 ms 0.04 ms (0.29%) 2.67%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 12.98 ms 0.04 ms (0.29%) 2.52%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.10 ms 1.10 ms 0.00 ms (0.28%) 2.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.15 ms 1.15 ms 0.00 ms (0.26%) 1.97%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.61 ms 1.61 ms -0.00 ms (-0.22%) 1.32%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.04 ms 16.08 ms 0.04 ms (0.22%) 1.78%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.11 ms 1.11 ms 0.00 ms (0.21%) 2.19%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.16 ms 1.16 ms 0.00 ms (0.17%) 1.52%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.22 ms 5.22 ms 0.01 ms (0.17%) 1.15%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.02 ms 5.03 ms 0.01 ms (0.16%) 1.41%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.19 ms 5.19 ms 0.01 ms (0.14%) 1.28%
handshake_no_resume_ring_1.3_rsa_chacha 992.90 µs 994.31 µs 1.41 µs (0.14%) 1.90%
handshake_no_resume_ring_1.2_rsa_aes 989.38 µs 990.72 µs 1.34 µs (0.14%) 1.75%
handshake_no_resume_ring_1.3_rsa_aes 993.64 µs 994.88 µs 1.24 µs (0.13%) 1.64%
handshake_session_id_ring_1.3_rsa_aes 6.89 ms 6.88 ms -0.01 ms (-0.09%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.47 ms 6.47 ms -0.01 ms (-0.08%) 1.40%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.41 ms 6.41 ms -0.01 ms (-0.08%) 1.17%
handshake_session_id_ring_1.3_ecdsap384_aes 9.48 ms 9.47 ms -0.01 ms (-0.07%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.52 ms 4.52 ms 0.00 ms (0.07%) 1.12%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.61 ms 0.00 ms (0.06%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.89 ms 6.89 ms -0.00 ms (-0.06%) 1.08%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.31 ms 4.31 ms 0.00 ms (0.05%) 2.30%
handshake_session_id_ring_1.3_rsa_chacha 6.82 ms 6.82 ms -0.00 ms (-0.05%) 1.14%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.33 ms 6.33 ms -0.00 ms (-0.05%) 1.29%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.99 ms 4.99 ms 0.00 ms (0.05%) 1.65%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.42 ms 9.42 ms -0.00 ms (-0.05%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.98 ms 4.99 ms 0.00 ms (0.04%) 1.18%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms 0.00 ms (0.03%) 1.33%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.50 ms 9.50 ms -0.00 ms (-0.03%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.33 ms 4.33 ms 0.00 ms (0.03%) 1.48%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.18 ms 5.18 ms 0.00 ms (0.02%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.50 ms 4.50 ms 0.00 ms (0.02%) 1.69%
handshake_tickets_ring_1.3_ecdsap384_aes 9.55 ms 9.55 ms -0.00 ms (-0.02%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.96 ms 6.96 ms -0.00 ms (-0.02%) 1.26%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.96 ms 4.96 ms 0.00 ms (0.02%) 1.26%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.16 ms 5.16 ms 0.00 ms (0.01%) 1.09%
handshake_session_id_ring_1.3_ecdsap256_aes 6.39 ms 6.39 ms -0.00 ms (-0.01%) 1.48%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.07 ms 0.00 ms (0.01%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.00%) 1.00%

Additional information

Historical results

Checkout details:

@brody4hire brody4hire mentioned this pull request Jan 22, 2025
Merged
ctz
ctz approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, I guess the reason for this has gone away -- though I don't think clippy has addressed the underlying false positive. But we can put this back if it is ever needed.

@ctz ctz added this pull request to the merge queue Jan 23, 2025
Merged via the queue into rustls:main with commit eb28df3 Jan 23, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brody4hire @djc @cpu @ctz