Skip to content

Conversation

ctz
Copy link
Member

@ctz ctz commented Oct 30, 2024

This prevents the slightly odd case where the docs for pki_types crate appears under rustls::pki_types, which becomes confusing:

  • items mention an alloc feature which the rustls crate doesn't have.
  • documentation says things like "refer to the crate documentation" but it this refers to the pki-types crate, not the crate the containing the documentation.
  • the front page of the pki-types crate documentation is absent, meaning people will miss the introductory text and advice we put there.
  • links from rustls to a pki-types type goes to this bizarro version, rather than the original crate docs.

doc(no_inline) disables this, and leaves just a hyperlink to the docs of the other crate.

fixes #1662

This prevents the slightly odd case where the docs for
pki_types crate appears under `rustls::pki_types`, which
becomes confusing:

- items mention an `alloc` feature which the rustls crate
  doesn't have.
- documentation says things like "refer to the crate documentation"
  but it this refers to the `pki-types` crate, not the crate the
  containing the documentation.
- the front page of the pki-types crate documentation is absent,
  meaning people will miss the introductory text and advice we put
  there.
- links from rustls to a pki-types type goes to this bizarro version,
  rather than the original crate docs.

doc(no_inline) disables this, and leaves just a hyperlink
to the docs of the other crate.
Copy link

rustls-benchmarking bot commented Oct 30, 2024

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1641198 1645544 4346 (0.26%) 1.05%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10782751 10757979 -24772 (-0.23%) 0.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8603101 8618059 14958 (0.17%) 0.54%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10441839 10456179 14340 (0.14%) 1.38%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3625148 3629448 4300 (0.12%) 0.47%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3084871 3088051 3180 (0.10%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3084574 3082372 -2202 (-0.07%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8605095 8606558 1463 (0.02%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1210823 1210997 174 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10765574 10766796 1222 (0.01%) 1.10%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1208578 1208635 57 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2105699 2105785 86 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623405 3623481 76 (0.00%) 0.46%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717476 1717454 -22 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30585468 30585720 252 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932708 1932693 -15 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2108828 2108813 -15 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 30075696 30075500 -196 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30598921 30599097 176 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30167799 30167965 166 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32431584 32431748 164 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 30025333 30025209 -124 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 30072847 30072736 -111 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30182387 30182495 108 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32431496 32431593 97 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30218660 30218576 -84 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 30025507 30025426 -81 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 30075797 30075718 -79 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32425211 32425134 -77 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32428640 32428716 76 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30585450 30585391 -59 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30168453 30168494 41 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30608017 30607980 -37 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30204172 30204207 35 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30204531 30204557 26 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30621425 30621447 22 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30599052 30599072 20 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32428491 32428509 18 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7594238 7594234 -4 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183220 35183203 -17 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32428234 32428243 9 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 30022354 30022347 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348757 58348746 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389595 46389587 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58341610 58341601 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46460138 46460144 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92718849 92718860 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46467124 46467119 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58254057 58254051 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58256135 58256130 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661847 80661852 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68684446 68684442 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554932 80554936 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92712625 92712621 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46434712 46434710 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467804 46467802 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487099 46487101 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540446 80540443 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58352511 58352513 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648883 80648881 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684669 92684671 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470691 46470692 1 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58237090 58237091 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58251815 58251816 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641256 80641257 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673768 92673769 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92714855 92714856 1 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42080821 42080821 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41640516 41640516 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11458509 11458509 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292338 11292338 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42095288 42095288 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 42646223 42646223 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236879 4236879 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1639769 1639769 0 (0.00%) 1.05%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41571316 41571316 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3892011 3892011 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5014085 5014085 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873535 3873535 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563544 2563544 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43321985 43321985 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41570826 41570826 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43378656 43378656 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 42648797 42648797 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41654742 41654742 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2662161 2662161 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682837 92682837 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41641024 41641024 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656296 2656296 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41585052 41585052 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43321981 43321981 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4251919 4251919 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535649 80535649 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35185160 35185160 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43381775 43381775 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46480090 46480090 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43318866 43318866 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 42648831 42648831 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42081361 42081361 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925965 1925965 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7596426 7596426 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42039061 42039061 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11452529 11452529 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4694983 4694983 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 42560106 42560106 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497663 4497663 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42053528 42053528 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43381801 43381801 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 42557498 42557498 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4215889 4215889 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 42560117 42560117 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42039583 42039583 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.43 ms 4.51 ms 0.08 ms (1.75%) 4.31%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.10 ms 5.18 ms 0.08 ms (1.51%) 3.90%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.17 ms 5.24 ms 0.07 ms (1.45%) 3.77%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.34 ms 6.42 ms 0.08 ms (1.31%) 3.27%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.13 ms 5.20 ms 0.07 ms (1.30%) 3.24%
transfer_no_resume_ring_1.3_rsa_aes 6.83 ms 6.91 ms 0.08 ms (1.16%) 3.16%
transfer_no_resume_ring_1.2_rsa_aes 6.76 ms 6.83 ms 0.08 ms (1.14%) 2.53%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 457.17 µs 462.37 µs 5.20 µs (1.14%) 2.53%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 455.35 µs 460.17 µs 4.81 µs (1.06%) 3.16%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.81 ms 1.83 ms 0.02 ms (1.05%) 5.35%
handshake_no_resume_ring_1.3_ecdsap256_aes 502.08 µs 506.74 µs 4.67 µs (0.93%) 2.73%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.43 ms 9.52 ms 0.09 ms (0.90%) 1.96%
handshake_no_resume_ring_1.3_ecdsap256_chacha 499.47 µs 503.62 µs 4.15 µs (0.83%) 2.38%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 13.02 ms 0.08 ms (0.65%) 1.46%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.63 ms 13.72 ms 0.09 ms (0.63%) 1.42%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.60 ms 13.69 ms 0.08 ms (0.60%) 1.48%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.90 ms 12.98 ms 0.08 ms (0.59%) 1.76%
transfer_no_resume_ring_1.3_rsa_chacha 13.43 ms 13.51 ms 0.08 ms (0.59%) 1.38%
handshake_no_resume_ring_1.2_rsa_aes 989.08 µs 994.29 µs 5.21 µs (0.53%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.03 ms 16.12 ms 0.08 ms (0.51%) 1.23%
handshake_no_resume_ring_1.3_rsa_aes 993.99 µs 998.70 µs 4.72 µs (0.47%) 1.07%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.61 ms 0.01 ms (0.47%) 1.16%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.17 ms 5.19 ms 0.02 ms (0.46%) 1.37%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.09 ms 0.00 ms (0.45%) 6.99%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.00 ms (0.37%) 1.11%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms 0.01 ms (0.34%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.18 ms 5.19 ms 0.02 ms (0.34%) 1.81%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.12 ms 1.12 ms 0.00 ms (0.33%) 6.96%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.50 ms 5.52 ms 0.02 ms (0.33%) 1.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.17 ms 1.18 ms 0.00 ms (0.32%) 1.18%
handshake_no_resume_ring_1.3_rsa_chacha 995.39 µs 998.61 µs 3.21 µs (0.32%) 1.08%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.21 ms 5.23 ms 0.02 ms (0.30%) 1.56%
handshake_tickets_ring_1.3_rsa_aes 7.11 ms 7.13 ms 0.02 ms (0.30%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.00 ms 7.02 ms 0.02 ms (0.29%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.97 ms 6.98 ms 0.02 ms (0.26%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.55 ms 5.56 ms 0.01 ms (0.26%) 1.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.50 ms 4.51 ms 0.01 ms (0.25%) 1.84%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.51 ms 5.52 ms 0.01 ms (0.24%) 1.44%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.48 ms 6.49 ms 0.02 ms (0.24%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 7.07 ms 7.09 ms 0.02 ms (0.21%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.58 ms 6.60 ms 0.01 ms (0.21%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.82 ms 4.83 ms 0.01 ms (0.21%) 1.54%
handshake_session_id_ring_1.3_ecdsap256_aes 6.51 ms 6.52 ms 0.01 ms (0.20%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.47 ms 4.48 ms 0.01 ms (0.17%) 1.29%
handshake_tickets_ring_1.3_ecdsap256_aes 6.62 ms 6.63 ms 0.01 ms (0.17%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.55 ms 9.57 ms 0.02 ms (0.16%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.18 ms 5.19 ms 0.01 ms (0.16%) 1.19%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.66 ms 9.68 ms 0.01 ms (0.15%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.70 ms 9.71 ms 0.01 ms (0.14%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.53 ms 5.53 ms 0.01 ms (0.14%) 1.45%
handshake_session_id_ring_1.3_ecdsap384_aes 9.59 ms 9.60 ms 0.01 ms (0.13%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.12 ms 0.00 ms (0.13%) 8.34%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.82 ms 4.82 ms 0.01 ms (0.13%) 1.31%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.11%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.09%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.64 ms 1.64 ms 0.00 ms (0.01%) 4.13%

Additional information

Historical results

Checkout details:

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer 👍

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.65%. Comparing base (8256c61) to head (4d34a1a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2188   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files         102      102           
  Lines       23749    23749           
=======================================
  Hits        22480    22480           
  Misses       1269     1269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 44297fb Oct 30, 2024
60 checks passed
@ctz ctz deleted the jbp-noinline-pki-types-doc branch October 30, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

discussion: re-exporting rustls-pki-types
3 participants