-
Notifications
You must be signed in to change notification settings - Fork 746
doc(no_inline) rustls::pki_types re-export #2188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This prevents the slightly odd case where the docs for pki_types crate appears under `rustls::pki_types`, which becomes confusing: - items mention an `alloc` feature which the rustls crate doesn't have. - documentation says things like "refer to the crate documentation" but it this refers to the `pki-types` crate, not the crate the containing the documentation. - the front page of the pki-types crate documentation is absent, meaning people will miss the introductory text and advice we put there. - links from rustls to a pki-types type goes to this bizarro version, rather than the original crate docs. doc(no_inline) disables this, and leaves just a hyperlink to the docs of the other crate.
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2188 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 102 102
Lines 23749 23749
=======================================
Hits 22480 22480
Misses 1269 1269 ☔ View full report in Codecov by Sentry. |
This prevents the slightly odd case where the docs for pki_types crate appears under
rustls::pki_types
, which becomes confusing:alloc
feature which the rustls crate doesn't have.pki-types
crate, not the crate the containing the documentation.doc(no_inline) disables this, and leaves just a hyperlink to the docs of the other crate.
fixes #1662