Skip to content

Mention rustls-wolfcrypt-provider in providers docs #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2024
Merged

Mention rustls-wolfcrypt-provider in providers docs #2110

merged 1 commit into from
Sep 5, 2024

Conversation

gasbytes
Copy link
Contributor

@gasbytes gasbytes commented Sep 5, 2024

This is still a work-in-progress project, but I believe it has reached a stable enough alpha stage to be added to the third-party crypto providers section.

Link to the repo: https://github.com/wolfssl/rustls-wolfcrypt-provider
Link to the wolfCrypt cryptographic engine: https://github.com/wolfSSL/wolfssl/tree/master/wolfcrypt

@cpu
Copy link
Member

cpu commented Sep 5, 2024

👋 Thanks for the PR and your work on the WoflSSL provider, very cool.

It looks like you have a CI failure from the lib.rs and README updates being out-of-sync w.r.t whitespace.

Try using admin/pull-readme and committing the diff. If you wouldn't mind, please also squash your changes down to 1 commit.

Thanks!

@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.68%. Comparing base (ea2b886) to head (c6ea120).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2110      +/-   ##
==========================================
- Coverage   94.76%   94.68%   -0.08%     
==========================================
  Files         102      102              
  Lines       23514    23543      +29     
==========================================
+ Hits        22283    22292       +9     
- Misses       1231     1251      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gasbytes
added links to rustls-wolfcrypt-provider in the third-party crypto pr…
c6ea120 
…oviders section

added link in lib.rs too

Fix CI by removing whitespace
@gasbytes gasbytes force-pushed the add-rustls-wolfcrypt-crypto-provider-to-docs branch from 5a76b51 to c6ea120 Compare September 5, 2024 13:41
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Sep 5, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2133695 2138647 ⚠️ 4952 (0.23%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8838059 8902384 64325 (0.73%) 1.11%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5084139 5056304 -27835 (-0.55%) 3.64%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30799512 30687843 -111669 (-0.36%) 0.36%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31237428 31128017 -109411 (-0.35%) 0.57%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3933602 3946957 13355 (0.34%) 3.41%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2140276 2135890 -4386 (-0.20%) 0.79%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13801480 13826866 25386 (0.18%) 0.62%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34777464 34720591 -56873 (-0.16%) 0.32%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3920365 3914249 -6116 (-0.16%) 0.31%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4448838 4442140 -6698 (-0.15%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4563392 4557149 -6243 (-0.14%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34813048 34769349 -43699 (-0.13%) 0.55%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4031365 4026405 -4960 (-0.12%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4289389 4284192 -5197 (-0.12%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30764036 30729920 -34116 (-0.11%) 0.26%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13466093 13451729 -14364 (-0.11%) 0.93%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92783418 92689116 -94302 (-0.10%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4270316 4266645 -3671 (-0.09%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46461558 46422348 -39210 (-0.08%) 0.38%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3381334 3378666 -2668 (-0.08%) 0.22%
handshake_tickets_ring_1.2_rsa_aes_server 4707090 4703835 -3255 (-0.07%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3914235 3916871 2636 (0.07%) 0.41%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58366621 58328302 -38319 (-0.07%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8888502 8882989 -5513 (-0.06%) 1.15%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58280338 58244975 -35363 (-0.06%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58367333 58332055 -35278 (-0.06%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58363584 58328446 -35138 (-0.06%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58282732 58247866 -34866 (-0.06%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58243795 58209395 -34400 (-0.06%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13821752 13829647 7895 (0.06%) 0.83%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58292192 58259446 -32746 (-0.06%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68700513 68666415 -34098 (-0.05%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42426578 42407777 -18801 (-0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46385211 46364976 -20235 (-0.04%) 0.28%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41977544 41959254 -18290 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30772050 30759204 -12846 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31205761 31192922 -12839 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30745953 30733367 -12586 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31158480 31145839 -12641 (-0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43476793 43459428 -17365 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30728106 30716157 -11949 (-0.04%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92695918 92660388 -35530 (-0.04%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92700042 92664935 -35107 (-0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92740939 92705908 -35031 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31182126 31170517 -11609 (-0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31135100 31123997 -11103 (-0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92735975 92703118 -32857 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32973995 32962423 -11572 (-0.04%) 0.71%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41970324 41956934 -13390 (-0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41889655 41876483 -13172 (-0.03%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92694605 92665678 -28927 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3384215 3383162 -1053 (-0.03%) 0.23%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42352290 42339219 -13071 (-0.03%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41987075 41974175 -12900 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30753751 30744415 -9336 (-0.03%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41906801 41894161 -12640 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 44049440 44036523 -12917 (-0.03%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42370374 42358992 -11382 (-0.03%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42435548 42424275 -11273 (-0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42417821 42406836 -10985 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2016994 2016584 -410 (-0.02%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43468841 43461971 -6870 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80667452 80654854 -12598 (-0.02%) 0.23%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43471556 43464895 -6661 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 33007359 33002354 -5005 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1916418 1916704 286 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 33012796 33008187 -4609 (-0.01%) 0.47%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31104889 31100713 -4176 (-0.01%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2228162 2227868 -294 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 33007171 33002839 -4332 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32966204 32962056 -4148 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43371055 43365872 -5183 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42351088 42346387 -4701 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 44041213 44036504 -4709 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46436025 46431073 -4952 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32966477 32963065 -3412 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43957408 43961910 4502 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1919665 1919474 -191 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41886150 41882333 -3817 (-0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2853497 2853253 -244 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 44044466 44040900 -3566 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43367429 43364214 -3215 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43961832 43959492 -2340 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80500400 80504327 3927 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2957206 2957068 -138 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34768216 34766601 -1615 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4389869 4390039 170 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4393192 4393319 127 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34787792 34788791 999 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43957533 43956816 -717 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34769129 34768579 -550 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43366297 43366979 682 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2234885 2234854 -31 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12185856 12185693 -163 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34787987 34787544 -443 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13741667 13741834 167 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11991801 11991675 -126 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2951267 2951291 24 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12179772 12179870 98 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46447561 46447280 -281 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46427411 46427137 -274 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13743856 13743937 81 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35475577 35475701 124 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80515985 80516255 270 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80606764 80606542 -222 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46352778 46352889 111 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80507736 80507580 -156 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46428523 46428609 86 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35473412 35473368 -44 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46438983 46438930 -53 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80607986 80607906 -80 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.59 ms 0.08 ms (1.77%) 7.04%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.45 ms 5.53 ms 0.08 ms (1.50%) 6.55%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.23 ms 5.31 ms 0.08 ms (1.49%) 6.30%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.45 ms 5.53 ms 0.08 ms (1.48%) 5.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 482.35 µs 487.92 µs 5.56 µs (1.15%) 3.16%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 483.13 µs 488.50 µs 5.37 µs (1.11%) 3.91%
transfer_no_resume_ring_1.2_rsa_aes 6.75 ms 6.82 ms 0.07 ms (0.99%) 4.34%
transfer_no_resume_ring_1.3_rsa_aes 6.83 ms 6.89 ms 0.07 ms (0.98%) 4.26%
handshake_no_resume_ring_1.3_ecdsap256_chacha 507.85 µs 512.76 µs 4.92 µs (0.97%) 2.45%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.34 ms 6.40 ms 0.06 ms (0.96%) 4.66%
handshake_no_resume_ring_1.3_ecdsap256_aes 510.76 µs 515.35 µs 4.59 µs (0.90%) 2.61%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.44 ms 9.51 ms 0.06 ms (0.67%) 2.94%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.97 ms 13.05 ms 0.08 ms (0.60%) 2.22%
transfer_no_resume_ring_1.3_rsa_chacha 13.47 ms 13.55 ms 0.08 ms (0.59%) 2.35%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.69 ms 13.77 ms 0.08 ms (0.59%) 2.15%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.99 ms 13.06 ms 0.08 ms (0.59%) 2.21%
handshake_session_id_ring_1.3_rsa_aes 7.31 ms 7.27 ms -0.04 ms (-0.56%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.79 ms 6.75 ms -0.04 ms (-0.55%) 1.04%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.91 ms 13.99 ms 0.07 ms (0.52%) 2.46%
handshake_session_id_ring_1.3_ecdsap256_aes 6.82 ms 6.79 ms -0.03 ms (-0.51%) 1.15%
handshake_session_id_ring_1.3_rsa_chacha 7.26 ms 7.23 ms -0.04 ms (-0.50%) 1.43%
handshake_session_id_ring_1.3_ecdsap384_aes 9.91 ms 9.86 ms -0.05 ms (-0.46%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.08 ms 16.15 ms 0.07 ms (0.43%) 1.74%
handshake_tickets_ring_1.3_rsa_aes 7.35 ms 7.32 ms -0.03 ms (-0.42%) 1.15%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.41 ms 0.01 ms (0.42%) 1.33%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.87 ms 9.83 ms -0.04 ms (-0.42%) 1.06%
handshake_no_resume_ring_1.2_rsa_aes 981.34 µs 985.38 µs 4.04 µs (0.41%) 1.48%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.82 ms 6.80 ms -0.03 ms (-0.40%) 1.25%
handshake_tickets_ring_1.3_ecdsap256_aes 6.87 ms 6.84 ms -0.03 ms (-0.39%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 992.96 µs 996.74 µs 3.78 µs (0.38%) 1.32%
handshake_tickets_ring_1.3_rsa_chacha 7.30 ms 7.28 ms -0.03 ms (-0.37%) 1.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.20 ms 1.20 ms 0.00 ms (0.35%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 992.25 µs 995.52 µs 3.27 µs (0.33%) 1.31%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.91 ms 9.88 ms -0.03 ms (-0.33%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.48 ms 6.46 ms -0.02 ms (-0.32%) 1.07%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.53 ms 5.51 ms -0.02 ms (-0.31%) 1.50%
handshake_tickets_ring_1.3_ecdsap384_aes 9.95 ms 9.92 ms -0.03 ms (-0.29%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.20 ms 1.20 ms 0.00 ms (0.29%) 1.10%
handshake_session_id_ring_1.2_rsa_aes 1.58 ms 1.57 ms -0.00 ms (-0.28%) 1.03%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.35 ms 6.33 ms -0.02 ms (-0.27%) 1.26%
handshake_tickets_ring_1.2_rsa_aes 1.67 ms 1.66 ms -0.00 ms (-0.26%) 1.09%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.24 ms 6.23 ms -0.02 ms (-0.25%) 1.32%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.40 ms 5.38 ms -0.01 ms (-0.22%) 1.56%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.42 ms 1.42 ms 0.00 ms (0.21%) 1.44%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.11 ms 6.09 ms -0.01 ms (-0.20%) 1.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.51 ms 5.52 ms 0.01 ms (0.14%) 1.81%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.08 ms 2.08 ms 0.00 ms (0.11%) 1.46%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.47 ms 6.47 ms -0.01 ms (-0.08%) 1.34%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.12 ms 6.11 ms -0.00 ms (-0.08%) 1.51%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms -0.00 ms (-0.07%) 1.09%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.23 ms 6.23 ms 0.00 ms (0.04%) 1.31%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.35 ms 6.36 ms 0.00 ms (0.03%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.28 ms 2.28 ms 0.00 ms (0.02%) 1.67%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.61 ms -0.00 ms (-0.02%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.40 ms 5.40 ms -0.00 ms (-0.01%) 1.72%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.61 ms 0.00 ms (0.01%) 1.00%

Additional information

Historical results

Checkout details:

ctz
ctz approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@cpu cpu added this pull request to the merge queue Sep 5, 2024
Merged via the queue into rustls:main with commit 696a1ef Sep 5, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gasbytes @cpu @ctz