Skip to content

Conversation

ctz
Copy link
Member

@ctz ctz commented Sep 5, 2024

This fixes clippy::too_long_first_doc_paragraph instances, a new lint just introduced on nightly:

warning: first doc comment paragraph is too long
   --> rustls/src/verify.rs:254:1
    |
254 | / /// Turns off client authentication. In contrast to using
255 | | /// `WebPkiClientVerifier::builder(roots).allow_unauthenticated().build()`, the `NoClientAuth`
256 | | /// `ClientCertVerifier` will not offer client authentication at all, vs offering but not
257 | | /// requiring it.
    | |_
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
    = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default

warning: first doc comment paragraph is too long
   --> rustls/src/webpki/client_verifier.rs:190:1
    |
190 | / /// A client certificate verifier that uses the `webpki` crate[^1] to perform client certificate
191 | | /// validation. It must be created via the [`WebPkiClientVerifier::builder()`] or
192 | | /// [`WebPkiClientVerifier::builder_with_provider()`] functions.
193 | | ///
194 | | /// Once built, the provided `Arc<dyn ClientCertVerifier>` can be used with a Rustls [`ServerConfig`]
    | |_
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph

warning: first doc comment paragraph is too long
  --> rustls/src/webpki/verify.rs:43:1
   |
43 | / /// Verify that the `end_entity` has an alternative name matching the `server_name`
44 | | /// note: this only verifies the name and should be used in conjunction with more verification
45 | | /// like [verify_server_cert_signed_by_trust_anchor]
   | |_
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph

This fixes `clippy::too_long_first_doc_paragraph` instances,
a new lint just introduced on nightly.
Copy link

rustls-benchmarking bot commented Sep 5, 2024

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3980732 3937056 -43676 (-1.10%) 3.65%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5154737 5117236 -37501 (-0.73%) 3.42%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8848260 8903889 55629 (0.63%) 1.32%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13416593 13458032 41439 (0.31%) 1.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31164598 31089381 -75217 (-0.24%) 0.34%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 33020227 32962560 -57667 (-0.17%) 0.71%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3916157 3912342 -3815 (-0.10%) 0.31%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13820271 13831254 10983 (0.08%) 0.83%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31156714 31181101 24387 (0.08%) 0.65%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46433723 46466817 33094 (0.07%) 0.45%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30733518 30714691 -18827 (-0.06%) 0.43%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34781308 34802506 21198 (0.06%) 0.28%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3914623 3912520 -2103 (-0.05%) 0.24%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34769260 34786172 16912 (0.05%) 0.64%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13823087 13817641 -5446 (-0.04%) 0.62%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46423289 46405130 -18159 (-0.04%) 0.38%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58263707 58241579 -22128 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2235826 2235181 -645 (-0.03%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4267574 4266350 -1224 (-0.03%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4283649 4284783 1134 (0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92694393 92718288 23895 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30742060 30734500 -7560 (-0.02%) 0.27%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80612356 80630334 17978 (0.02%) 0.24%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4443675 4442745 -930 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30715951 30709759 -6192 (-0.02%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4557667 4556775 -892 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2228202 2227787 -415 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2134224 2134618 394 (0.02%) 0.82%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3380937 3381547 610 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42345506 42353004 7498 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8877521 8878877 1356 (0.02%) 1.07%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1920029 1919770 -259 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46440342 46435157 -5185 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43960788 43965489 4701 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1916737 1916927 190 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2951565 2951283 -282 (-0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4704272 4703874 -398 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4390027 4390327 300 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31121970 31120000 -1970 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92661939 92667476 5537 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4393724 4393467 -257 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3384590 3384732 142 (0.00%) 0.24%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41880965 41882712 1747 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32961473 32962783 1310 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42407394 42405716 -1678 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58333646 58331350 -2296 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42410709 42412358 1649 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2853788 2853681 -107 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2957383 2957490 107 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30741538 30740518 -1020 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41894816 41893456 -1360 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41962712 41964065 1353 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32962017 32963032 1015 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34769273 34768205 -1068 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30734102 30733239 -863 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58243786 58245359 1573 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30759274 30760084 810 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2136205 2136149 -56 (-0.00%) 0.79%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 33002829 33003607 778 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43463361 43464355 994 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43960249 43959379 -870 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34769087 34768448 -639 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43956877 43957648 771 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46439484 46438773 -711 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42357993 42358627 634 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34787880 34788372 492 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 33003514 33003980 466 (0.00%) 0.52%
handshake_no_resume_ring_1.3_rsa_chacha_server 12186212 12186049 -163 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 44036497 44037058 561 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 44040163 44040673 510 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58331656 58332267 611 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80606174 80607002 828 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12180108 12179988 -120 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35473996 35473698 -298 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42339149 42339475 326 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 44040363 44040031 -332 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41956833 41956525 -308 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43461073 43461367 294 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46427833 46427525 -308 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13744374 13744287 -87 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41975043 41975286 243 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92705044 92705542 498 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 33003056 33003231 175 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68666410 68666062 -348 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2016984 2016974 -10 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11992140 11992082 -58 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13742017 13742083 66 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58247647 58247920 273 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43366819 43367004 185 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41875707 41875879 172 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4026139 4026154 15 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58209153 58208947 -206 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31146005 31145897 -108 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46352928 46352768 -160 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46447230 46447389 159 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92702416 92702117 -299 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58328045 58328230 185 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35476001 35475898 -103 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42423540 42423656 116 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80507804 80507584 -220 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80515741 80515922 181 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80504489 80504339 -150 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92664743 92664577 -166 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46428559 46428633 74 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34788087 34788135 48 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31192478 31192440 -38 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80607940 80607989 49 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43363737 43363759 22 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31169360 31169371 11 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92660571 92660551 -20 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43464404 43464412 8 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43367367 43367374 7 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.60 ms 4.47 ms -0.12 ms (-2.65%) 5.40%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.32 ms 5.20 ms -0.13 ms (-2.36%) 5.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.53 ms 5.41 ms -0.12 ms (-2.23%) 4.09%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.53 ms 5.41 ms -0.11 ms (-2.05%) 5.02%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.41 ms 6.30 ms -0.12 ms (-1.79%) 3.43%
transfer_no_resume_ring_1.3_rsa_aes 6.90 ms 6.78 ms -0.12 ms (-1.73%) 3.44%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 488.30 µs 479.93 µs -8.37 µs (-1.71%) 3.39%
transfer_no_resume_ring_1.2_rsa_aes 6.82 ms 6.70 ms -0.11 ms (-1.63%) 3.90%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 488.29 µs 481.38 µs -6.91 µs (-1.41%) 3.58%
handshake_no_resume_ring_1.3_ecdsap256_chacha 512.67 µs 505.94 µs -6.73 µs (-1.31%) 2.49%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.51 ms 9.39 ms -0.12 ms (-1.25%) 2.19%
handshake_no_resume_ring_1.3_ecdsap256_aes 515.11 µs 508.92 µs -6.19 µs (-1.20%) 3.05%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.05 ms 12.94 ms -0.12 ms (-0.91%) 2.01%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.07 ms 12.95 ms -0.12 ms (-0.90%) 1.70%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.00 ms 13.87 ms -0.12 ms (-0.88%) 2.06%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.78 ms 13.66 ms -0.12 ms (-0.88%) 1.65%
transfer_no_resume_ring_1.3_rsa_chacha 13.55 ms 13.44 ms -0.11 ms (-0.84%) 1.82%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.16 ms 16.03 ms -0.13 ms (-0.78%) 1.31%
handshake_no_resume_ring_1.2_rsa_aes 986.29 µs 979.56 µs -6.73 µs (-0.68%) 1.38%
handshake_no_resume_ring_1.3_rsa_chacha 997.75 µs 991.47 µs -6.28 µs (-0.63%) 1.30%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.20 ms 1.20 ms -0.01 ms (-0.60%) 1.21%
handshake_no_resume_ring_1.3_rsa_aes 996.47 µs 990.61 µs -5.86 µs (-0.59%) 1.73%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.20 ms 1.20 ms -0.01 ms (-0.56%) 1.26%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.77 ms 6.73 ms -0.03 ms (-0.51%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.81 ms 6.77 ms -0.03 ms (-0.51%) 1.10%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.82 ms 6.78 ms -0.03 ms (-0.48%) 1.25%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.41 ms -0.01 ms (-0.48%) 1.33%
handshake_session_id_ring_1.3_rsa_chacha 7.25 ms 7.21 ms -0.03 ms (-0.46%) 1.38%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.37 ms 1.36 ms -0.01 ms (-0.45%) 1.05%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.53 ms 5.51 ms -0.02 ms (-0.43%) 1.48%
handshake_tickets_ring_1.3_rsa_chacha 7.29 ms 7.26 ms -0.03 ms (-0.42%) 1.19%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.40 ms 5.37 ms -0.02 ms (-0.42%) 1.48%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.85 ms 9.81 ms -0.04 ms (-0.41%) 1.06%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.53 ms 5.51 ms -0.02 ms (-0.41%) 1.83%
handshake_tickets_ring_1.3_ecdsap256_aes 6.86 ms 6.84 ms -0.03 ms (-0.40%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.08 ms 2.08 ms -0.01 ms (-0.39%) 1.78%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.42 ms 1.41 ms -0.01 ms (-0.38%) 1.33%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.11 ms 6.08 ms -0.02 ms (-0.37%) 1.22%
handshake_tickets_ring_1.3_rsa_aes 7.34 ms 7.31 ms -0.03 ms (-0.37%) 1.12%
handshake_session_id_ring_1.3_rsa_aes 7.29 ms 7.26 ms -0.03 ms (-0.37%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.90 ms 9.86 ms -0.04 ms (-0.37%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.25 ms 6.23 ms -0.02 ms (-0.36%) 1.28%
handshake_tickets_ring_1.3_ecdsap384_aes 9.95 ms 9.91 ms -0.04 ms (-0.36%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.89 ms 9.85 ms -0.03 ms (-0.35%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.29 ms 2.28 ms -0.01 ms (-0.34%) 1.76%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.24 ms 6.22 ms -0.02 ms (-0.33%) 1.21%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.48 ms 6.46 ms -0.02 ms (-0.30%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.41 ms 5.39 ms -0.02 ms (-0.30%) 1.81%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.60 ms -0.01 ms (-0.30%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.12 ms 6.11 ms -0.02 ms (-0.29%) 1.54%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.48 ms 6.46 ms -0.02 ms (-0.27%) 1.69%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.36 ms 6.35 ms -0.02 ms (-0.27%) 1.55%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.34 ms 6.32 ms -0.02 ms (-0.27%) 1.19%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.60 ms -0.01 ms (-0.25%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.67 ms 1.67 ms -0.00 ms (-0.15%) 1.09%
handshake_session_id_ring_1.2_rsa_aes 1.58 ms 1.57 ms -0.00 ms (-0.06%) 1.00%

Additional information

Historical results

Checkout details:

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (8c04dba) to head (8a5bfb0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2109   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files         102      102           
  Lines       23514    23514           
=======================================
  Hits        22283    22283           
  Misses       1231     1231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh, that lint is going to be great.

@ctz ctz added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit ea2b886 Sep 5, 2024
60 checks passed
@ctz ctz deleted the jbp-long-rustdoc-preamble branch September 5, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants