Skip to content

Tidy logging macros #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2024
Merged

Tidy logging macros #2106

merged 1 commit into from
Sep 2, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Sep 2, 2024

Normalise the fact that logging macros live in crate::log, rather than a difference place depending on the logging feature.

ref rustls/hyper-rustls#285 (comment)

@ctz
Tidy logging macros
d521f85 
Normalise the fact that logging macros live in `crate::log`,
rather than a difference place depending on the `logging` feature.
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Sep 2, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2139035 2134223 ✅ -4812 (-0.22%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5170370 5122136 -48234 (-0.93%) 3.10%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3986338 3972840 -13498 (-0.34%) 3.65%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13421316 13455879 34563 (0.26%) 0.93%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13862702 13829028 -33674 (-0.24%) 0.45%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34780932 34858751 77819 (0.22%) 0.64%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2140785 2136248 -4537 (-0.21%) 0.77%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34688492 34753489 64997 (0.19%) 0.33%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30746561 30700266 -46295 (-0.15%) 0.27%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31137888 31182971 45083 (0.14%) 0.65%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3376954 3381662 4708 (0.14%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13809218 13791726 -17492 (-0.13%) 0.73%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3917100 3912619 -4481 (-0.11%) 0.22%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3920380 3916216 -4164 (-0.11%) 0.29%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30707346 30732243 24897 (0.08%) 0.34%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8897458 8890378 -7080 (-0.08%) 0.94%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46377043 46408803 31760 (0.07%) 0.41%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32947754 32967641 19887 (0.06%) 0.61%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80665372 80637389 -27983 (-0.03%) 0.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8898515 8896011 -2504 (-0.03%) 0.96%
handshake_tickets_ring_1.3_ecdsap256_aes_server 44035238 44045486 10248 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42408468 42417137 8669 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32972449 32978920 6471 (0.02%) 0.51%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46424399 46432970 8571 (0.02%) 0.42%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1916665 1917001 336 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30743863 30738702 -5161 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2016887 2017207 320 (0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2951953 2951525 -428 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2957181 2957552 371 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58326322 58333276 6954 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46430653 46436134 5481 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58249008 58242373 -6635 (-0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4283835 4284320 485 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41959402 41964067 4665 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3383514 3383888 374 (0.01%) 0.26%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43955910 43960729 4819 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31126807 31123502 -3305 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42341155 42345422 4267 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58237251 58231430 -5821 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1920082 1919894 -188 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92692349 92701356 9007 (0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4704855 4704402 -453 (-0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4267486 4267090 -396 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4026447 4026075 -372 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4442249 4442658 409 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43459941 43463847 3906 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92657594 92664167 6573 (0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2853815 2854013 198 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2235415 2235565 150 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4390007 4390300 293 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31146532 31144756 -1776 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80499703 80504134 4431 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30732963 30734562 1599 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4393628 4393402 -226 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31105732 31104178 -1554 (-0.00%) 0.40%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2228048 2228152 104 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 33002013 33003417 1404 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34768962 34767818 -1144 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 33003092 33002042 -1050 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41956986 41958228 1242 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12180008 12180364 356 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32962031 32961091 -940 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41881570 41880381 -1189 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41974409 41975409 1000 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43367025 43366016 -1009 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13744430 13744723 293 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42423757 42424647 890 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34767757 34768482 725 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43367709 43366887 -822 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43959990 43959205 -785 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31169147 31168677 -470 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32962285 32962759 474 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46438424 46439074 650 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41893485 41894065 580 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43464103 43464682 579 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42340285 42340845 560 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11991896 11992051 155 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43461108 43461581 473 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4557142 4557098 -44 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30716587 30716291 -296 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46427316 46426899 -417 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41876224 41876588 364 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42406168 42405817 -351 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34787659 34787937 278 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30759344 30759587 243 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92703827 92703109 -718 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34788530 34788263 -267 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46447270 46446961 -309 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80607630 80608147 517 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35475854 35476061 207 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80606285 80606684 399 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 44037345 44037134 -211 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43957057 43957267 210 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31192774 31192904 130 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58328297 58328529 232 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92705498 92705165 -333 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68666100 68665857 -243 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46353135 46352980 -155 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43363324 43363186 -138 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58209043 58208932 -111 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58247791 58247686 -105 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42358698 42358629 -69 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80515980 80515860 -120 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13742357 13742337 -20 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92660465 92660364 -101 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46428687 46428644 -43 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80507400 80507462 62 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35473665 35473678 13 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 44040777 44040764 -13 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12186237 12186240 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92664794 92664800 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58331945 58331945 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.48 ms 4.52 ms 0.04 ms (0.96%) 5.40%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.19 ms 5.24 ms 0.05 ms (0.92%) 4.94%
transfer_no_resume_ring_1.2_rsa_aes 6.70 ms 6.75 ms 0.05 ms (0.77%) 3.90%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.41 ms 5.45 ms 0.04 ms (0.77%) 3.77%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 479.55 µs 483.16 µs 3.61 µs (0.75%) 3.05%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.41 ms 5.45 ms 0.04 ms (0.72%) 4.82%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.38 ms 5.42 ms 0.04 ms (0.68%) 1.73%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.36 ms 5.40 ms 0.04 ms (0.67%) 1.47%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.30 ms 6.34 ms 0.04 ms (0.67%) 3.43%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.21 ms 6.25 ms 0.04 ms (0.64%) 1.15%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.50 ms 5.53 ms 0.04 ms (0.64%) 1.77%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 480.29 µs 483.33 µs 3.04 µs (0.63%) 3.58%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.09 ms 6.12 ms 0.04 ms (0.63%) 1.37%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.50 ms 5.53 ms 0.03 ms (0.63%) 1.08%
handshake_no_resume_ring_1.3_ecdsap256_chacha 505.50 µs 508.66 µs 3.16 µs (0.62%) 2.54%
handshake_no_resume_ring_1.3_ecdsap256_aes 508.08 µs 511.20 µs 3.12 µs (0.61%) 3.14%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.07 ms 6.10 ms 0.04 ms (0.60%) 1.22%
transfer_no_resume_ring_1.3_rsa_aes 6.78 ms 6.82 ms 0.04 ms (0.59%) 3.44%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.31 ms 6.35 ms 0.04 ms (0.59%) 1.19%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.20 ms 6.24 ms 0.04 ms (0.58%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.44 ms 6.48 ms 0.04 ms (0.55%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.34 ms 6.37 ms 0.03 ms (0.53%) 1.54%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.45 ms 6.48 ms 0.03 ms (0.52%) 1.46%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.39 ms 9.44 ms 0.05 ms (0.50%) 2.37%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.20 ms 0.01 ms (0.48%) 1.26%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.93 ms 12.98 ms 0.05 ms (0.37%) 2.02%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.65 ms 13.70 ms 0.05 ms (0.37%) 1.67%
handshake_session_id_ring_1.3_ecdsap256_aes 6.77 ms 6.79 ms 0.02 ms (0.35%) 1.09%
handshake_no_resume_ring_1.3_rsa_aes 989.52 µs 992.74 µs 3.22 µs (0.33%) 1.61%
handshake_no_resume_ring_1.3_rsa_chacha 990.73 µs 993.95 µs 3.22 µs (0.32%) 1.27%
handshake_no_resume_ring_1.2_rsa_aes 978.77 µs 981.90 µs 3.12 µs (0.32%) 1.38%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.88 ms 13.92 ms 0.04 ms (0.31%) 2.03%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.95 ms 12.99 ms 0.04 ms (0.30%) 1.85%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.20 ms 1.20 ms 0.00 ms (0.28%) 1.29%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms 0.00 ms (0.27%) 4.30%
transfer_no_resume_ring_1.3_rsa_chacha 13.44 ms 13.47 ms 0.04 ms (0.27%) 2.09%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.73 ms 6.75 ms 0.02 ms (0.26%) 1.01%
handshake_tickets_ring_1.3_ecdsap256_aes 6.83 ms 6.85 ms 0.02 ms (0.26%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.31 ms 7.33 ms 0.02 ms (0.26%) 1.12%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.42 ms 0.00 ms (0.25%) 3.88%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.04 ms 16.08 ms 0.04 ms (0.25%) 1.20%
handshake_session_id_ring_1.3_rsa_aes 7.26 ms 7.27 ms 0.02 ms (0.21%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.21 ms 7.23 ms 0.01 ms (0.20%) 1.27%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.81 ms 9.83 ms 0.02 ms (0.19%) 1.06%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.79 ms 6.80 ms 0.01 ms (0.19%) 1.19%
handshake_session_id_ring_1.3_ecdsap384_aes 9.85 ms 9.87 ms 0.02 ms (0.18%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 7.27 ms 7.28 ms 0.01 ms (0.18%) 1.17%
handshake_session_id_ring_1.2_rsa_aes 1.57 ms 1.57 ms 0.00 ms (0.17%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.41 ms 0.00 ms (0.14%) 4.47%
handshake_tickets_ring_1.3_ecdsap384_aes 9.91 ms 9.92 ms 0.01 ms (0.12%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.12%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.07 ms 2.07 ms 0.00 ms (0.10%) 4.11%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.10%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.87 ms 9.88 ms 0.01 ms (0.09%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.66 ms 1.66 ms 0.00 ms (0.05%) 1.17%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.28 ms 2.28 ms -0.00 ms (-0.05%) 1.65%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (2676a60) to head (d521f85).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2106   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files         102      102           
  Lines       23514    23514           
=======================================
  Hits        22283    22283           
  Misses       1231     1231

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz
Copy link
Member Author

ctz commented Sep 2, 2024

I think this is pretty minor, merging with one approval.

@ctz ctz added this pull request to the merge queue Sep 2, 2024
Merged via the queue into main with commit 46555f1 Sep 2, 2024
71 checks passed
@ctz ctz deleted the jbp-logging-macros branch September 2, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctz @djc