Skip to content

ci: trim daily-tests powerset #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2024
Merged

ci: trim daily-tests powerset #2093

merged 1 commit into from
Aug 28, 2024

Conversation

cpu
Copy link
Member

@cpu cpu commented Aug 27, 2024 •
edited
Loading

Reduces the runtime of the cargo hack check step of the daily-tests.yml workflow by grouping/excluding certain feature combos. Follow-up from #2091

Since the number of features in Rustls has grown the powerset check task has been getting very long, requiring ~940 builds without further configuration. In some cases we know certain features imply another, or are somewhat mutually exclusive in intent.

This commit adds --group-features and --mutually-exclusive-features configuration to the cargo hack check invocation, reducing the runtime greatly. Here's a completed run with the updated configuration (4m duration).

@cpu cpu self-assigned this Aug 27, 2024
cpu
cpu commented Aug 27, 2024
View reviewed changes
cpu
cpu commented Aug 27, 2024
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.78%. Comparing base (daf31e5) to head (6242ffd).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2093   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files         102      102           
  Lines       23497    23497           
=======================================
  Hits        22271    22271           
  Misses       1226     1226

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Aug 28, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5172268 5113776 -58492 (-1.13%) 2.17%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3897409 3930596 33187 (0.85%) 3.70%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8870753 8909337 38584 (0.43%) 1.29%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13477082 13435355 -41727 (-0.31%) 1.36%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 33024859 32951062 -73797 (-0.22%) 0.76%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30748558 30680914 -67644 (-0.22%) 0.30%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34785947 34711029 -74918 (-0.22%) 0.44%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2138509 2134026 -4483 (-0.21%) 0.78%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34843607 34771349 -72258 (-0.21%) 0.62%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13820693 13848510 27817 (0.20%) 0.91%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2136518 2140681 4163 (0.19%) 0.74%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31132591 31076379 -56212 (-0.18%) 0.45%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13806670 13831238 24568 (0.18%) 0.84%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31175087 31127076 -48011 (-0.15%) 0.33%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3916312 3920838 4526 (0.12%) 0.37%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3919066 3914785 -4281 (-0.11%) 0.44%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3378877 3381891 3014 (0.09%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46354772 46392864 38092 (0.08%) 0.31%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58261263 58219630 -41633 (-0.07%) 0.24%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30715341 30698438 -16903 (-0.06%) 0.48%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46433823 46414343 -19480 (-0.04%) 0.34%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32979857 32992149 12292 (0.04%) 0.58%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42349269 42338839 -10430 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3383915 3384648 733 (0.02%) 0.26%
handshake_session_id_ring_1.2_rsa_aes_client 4284781 4285689 908 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43963225 43954248 -8977 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92694364 92709631 15267 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2017041 2017345 304 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1920143 1919877 -266 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 44034056 44039200 5144 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41885230 41880509 -4721 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2957305 2957632 327 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43369497 43365079 -4418 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31123429 31120452 -2977 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42405365 42409332 3967 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46446904 46451199 4295 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30744445 30741654 -2791 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2235331 2235144 -187 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92703138 92695722 -7416 (-0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4557229 4557589 360 (0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4266192 4266529 337 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8888657 8889329 672 (0.01%) 0.72%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58326725 58330958 4233 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4025934 4025646 -288 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2228190 2228345 155 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58247977 58244439 -3538 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80503869 80499892 -3977 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80606078 80602238 -3840 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80632216 80636039 3823 (0.00%) 0.21%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92663550 92659471 -4079 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30760000 30758704 -1296 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4390240 4390076 -164 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1916417 1916486 69 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13742057 13742550 493 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 44036664 44035106 -1558 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2951646 2951549 -97 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31167492 31168441 949 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4393427 4393556 129 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 44039424 44038195 -1229 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42358484 42357361 -1123 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41961492 41960400 -1092 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43462684 43463624 940 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31145748 31145093 -655 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11992249 11991997 -252 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 33001125 33001816 691 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42406021 42405136 -885 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30733644 30734272 628 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43955070 43955958 888 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42423634 42422801 -833 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34787592 34786987 -605 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43463449 43462722 -727 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41893592 41894178 586 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34767029 34766556 -473 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41876366 41876908 542 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4703594 4703652 58 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30713749 30713376 -373 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34786253 34786639 386 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4442436 4442485 49 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43362283 43361814 -469 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31193066 31193388 322 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41974199 41974598 399 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46454213 46453876 -337 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58328736 58328337 -399 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46428346 46428657 311 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32961371 32961155 -216 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68666334 68665885 -449 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43459746 43459472 -274 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12185833 12185901 68 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46368077 46368332 255 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32960573 32960397 -176 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43365020 43365245 225 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34767306 34767478 172 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58208917 58209184 267 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35473531 35473690 159 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41956820 41956642 -178 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46427496 46427683 187 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2853950 2853961 11 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35475671 35475770 99 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 33002576 33002495 -81 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42340757 42340662 -95 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80607851 80607673 -178 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43959014 43959091 77 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92705765 92705603 -162 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92660525 92660650 125 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58247779 58247743 -36 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13744214 13744221 7 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12180087 12180081 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80507744 80507775 31 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92665062 92665031 -31 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80515780 80515790 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58331765 58331770 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46462648 46462651 3 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.53 ms 4.59 ms 0.05 ms (1.19%) 5.62%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.50 ms 5.56 ms 0.06 ms (1.05%) 4.25%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.50 ms 5.55 ms 0.06 ms (1.04%) 4.36%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.26 ms 5.31 ms 0.05 ms (0.98%) 5.16%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 484.51 µs 488.92 µs 4.41 µs (0.91%) 3.18%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.37 ms 6.43 ms 0.05 ms (0.82%) 3.83%
transfer_no_resume_ring_1.2_rsa_aes 6.76 ms 6.82 ms 0.05 ms (0.80%) 3.23%
transfer_no_resume_ring_1.3_rsa_aes 6.87 ms 6.92 ms 0.05 ms (0.73%) 3.64%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 483.44 µs 486.92 µs 3.49 µs (0.72%) 2.51%
handshake_no_resume_ring_1.3_ecdsap256_aes 509.91 µs 513.30 µs 3.39 µs (0.66%) 3.48%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.11 ms 2.12 ms 0.01 ms (0.60%) 2.61%
handshake_session_id_ring_1.2_rsa_aes 1.57 ms 1.58 ms 0.01 ms (0.59%) 1.13%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.31 ms 2.32 ms 0.01 ms (0.57%) 1.84%
handshake_no_resume_ring_1.3_ecdsap256_chacha 507.72 µs 510.44 µs 2.72 µs (0.54%) 2.48%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.47 ms 9.52 ms 0.05 ms (0.53%) 2.58%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.99 ms 13.05 ms 0.06 ms (0.47%) 1.89%
handshake_tickets_ring_1.2_rsa_aes 1.66 ms 1.67 ms 0.01 ms (0.43%) 1.78%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.72 ms 13.78 ms 0.06 ms (0.42%) 1.74%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.01 ms 13.06 ms 0.05 ms (0.41%) 1.87%
transfer_no_resume_ring_1.3_rsa_chacha 13.51 ms 13.56 ms 0.05 ms (0.40%) 1.79%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.97 ms 14.02 ms 0.05 ms (0.39%) 1.84%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.10 ms 16.16 ms 0.06 ms (0.35%) 1.40%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.44 ms 1.44 ms 0.00 ms (0.32%) 5.90%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.20 ms 1.20 ms 0.00 ms (0.31%) 1.02%
handshake_no_resume_ring_1.2_rsa_aes 979.85 µs 982.86 µs 3.01 µs (0.31%) 1.35%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.20 ms 1.20 ms 0.00 ms (0.30%) 1.04%
handshake_no_resume_ring_1.3_rsa_aes 1.00 ms 1.01 ms 0.00 ms (0.30%) 1.48%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.49 ms 6.51 ms 0.02 ms (0.26%) 1.01%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.50 ms 6.51 ms 0.01 ms (0.23%) 1.43%
handshake_session_id_ring_1.3_ecdsap256_aes 6.75 ms 6.76 ms 0.01 ms (0.20%) 1.60%
handshake_session_id_ring_1.3_rsa_aes 7.24 ms 7.26 ms 0.01 ms (0.20%) 1.52%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.45 ms 1.45 ms 0.00 ms (0.20%) 5.66%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.71 ms 6.72 ms 0.01 ms (0.19%) 1.27%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.24 ms 6.25 ms 0.01 ms (0.18%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.52 ms 5.53 ms 0.01 ms (0.18%) 1.41%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.24 ms 6.25 ms 0.01 ms (0.17%) 1.24%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.76 ms 6.77 ms 0.01 ms (0.17%) 1.27%
handshake_tickets_ring_1.3_rsa_aes 7.30 ms 7.31 ms 0.01 ms (0.17%) 1.12%
handshake_no_resume_ring_1.3_rsa_chacha 1.00 ms 1.01 ms 0.00 ms (0.17%) 1.31%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.39 ms 5.40 ms 0.01 ms (0.15%) 1.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.37 ms 6.38 ms 0.01 ms (0.15%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.20 ms 7.21 ms 0.01 ms (0.15%) 1.48%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.40 ms 6.41 ms 0.01 ms (0.14%) 1.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.53 ms 5.53 ms 0.01 ms (0.13%) 1.11%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.80 ms 9.81 ms 0.01 ms (0.13%) 1.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.12 ms 6.13 ms 0.01 ms (0.12%) 1.41%
handshake_tickets_ring_1.3_ecdsap384_aes 9.89 ms 9.90 ms 0.01 ms (0.12%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.81 ms 6.82 ms 0.01 ms (0.10%) 1.39%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.85 ms 9.85 ms 0.01 ms (0.09%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.83 ms 9.84 ms 0.01 ms (0.09%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 7.25 ms 7.26 ms 0.01 ms (0.09%) 1.31%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.61 ms 0.00 ms (0.07%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.42 ms 5.42 ms 0.00 ms (0.07%) 1.61%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.10 ms 6.11 ms 0.00 ms (0.07%) 1.17%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.39 ms 1.39 ms 0.00 ms (0.05%) 5.92%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.02%) 1.00%

Additional information

Historical results

Checkout details:

@cpu
ci: trim daily-tests powerset
6242ffd 
Reduces the runtime of the `cargo hack check` step of the
`daily-tests.yml` workflow by grouping/excluding certain feature combos.

Since the number of features in Rustls has grown the powerset check task
has been getting very long, requiring ~940 builds. In some cases we know
certain features imply another, or are somewhat mutually exclusive in
intent.

This commit adds `--group-features` and `--mutually-exclusive-features`
configuration to the `cargo hack check` invocation, reducing the runtime
greatly.
@cpu cpu force-pushed the cpu-too-much-power branch from 75d57e4 to 6242ffd Compare August 28, 2024 14:36
@cpu cpu added this pull request to the merge queue Aug 28, 2024
Merged via the queue into rustls:main with commit cc40342 Aug 28, 2024
24 checks passed
@cpu cpu deleted the cpu-too-much-power branch August 28, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

@djc djc djc approved these changes

Assignees

@cpu cpu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpu @djc @ctz